Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2498923ybz; Sun, 19 Apr 2020 02:52:53 -0700 (PDT) X-Google-Smtp-Source: APiQypL7TJlLtVUDiHz2cRXamlCVLiKyJoAyGQafcBqB2OmWyOBS4gY8NWlKe4PCVNWEEAeGdsHr X-Received: by 2002:a17:906:85c2:: with SMTP id i2mr11355298ejy.147.1587289973617; Sun, 19 Apr 2020 02:52:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587289973; cv=none; d=google.com; s=arc-20160816; b=gRveZsQKNMpU+BlJeAlc31ReviayYnrph8H+70swN3eOgSTwl2d2PXohOHX2S/pDEa hE3sanpD4tAyPJ7np6KTHiD36BBDLF50ehdl0oU9GRAA1cehND5AxI78V1r8ylgO8rvI YJP+XJaMTX2kHWch5pOTOH7OFe/1w7XzoC7qYEewnOoTr4tDg3mk7Enkt6QVyfl7tc3I kzUr5dsVMCvAJ6uWv7UeoKY2JgXyod9N4uSIfZyFnJ9k+qacIhyEqGEidmyVuE/XECz+ jN8s5M2nBtmq9RTmIgD5Gv6sVCh71zGCRj47v3fOiaSMQd2vZRv0yIqpoIqbQEPaDW2/ 34bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=N9JI33hna/+DxESkUc7SCOMzfYQhchoF06eN0/wfACI=; b=aj8nO1/dyoUwsEzm58k8XSz7SkfMYhiBrV9rFA3+0BdxMVZD7YWDoJY3xcJPohItiU McslEfnaoT6rUne1kp0xmyNd+toQr+MKocigAc7urvGVrnuBn+IyXO21i1enphsYbqlK YXShLud11XYGs6rFcyOzCPLu8JWeOReRSGYqNAwMu6NI6EBR7SHW6bXPSbVgiegx0JCd 1id3okVz/QNjrQDUMTD4/VLNVpcBdzLkC+KNC8nUOfjjK3oXMQ2lP45jIeBTinCEqvJ2 snHI86h8wOLHzahX9LSD7bVXPGoqlgmT46MVWzOpYA1FqmhoQIbHbpk2x3GYEvuaIhv1 84uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p3g9j1xn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c17si11125502ejm.84.2020.04.19.02.52.30; Sun, 19 Apr 2020 02:52:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=p3g9j1xn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725950AbgDSJvg (ORCPT + 99 others); Sun, 19 Apr 2020 05:51:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725905AbgDSJvg (ORCPT ); Sun, 19 Apr 2020 05:51:36 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85014C061A0F for ; Sun, 19 Apr 2020 02:51:34 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id w145so5420728lff.3 for ; Sun, 19 Apr 2020 02:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N9JI33hna/+DxESkUc7SCOMzfYQhchoF06eN0/wfACI=; b=p3g9j1xnjdCtzhbgZS6lVhDB+mXR+o9+FTp1/dXRbri/Wmu8K7EsTY54Buw14cqV/t VKxBLkOHqGwNawDndp5tVo/S7shTTp5VMCP5HXlx8k/HYr2tWG8IWRdGbpqCALRIZzQM Uz+TJKMudQF8GP6epv9M+qUY0yPfFOA3Rtftp5MoijLCN0kLYX66lDmQHN005k+sIOr/ 4WL3/aPNX72Hze9blP2PGXgcyc7ChGVoR33ORT9uk0i6aKO5Tp5fvInqHRq/KFyuRFxh 70sd1Nm6cx1GNlcjDDS6kH2o/l0cYZ87Zsa8nqUlRZhyHhUD5FqIDNJ3V6gaweMl1PwH Ge+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N9JI33hna/+DxESkUc7SCOMzfYQhchoF06eN0/wfACI=; b=PdfkTXzF41FMiNilC8ETAxP4oBuVzfRmIAcHNtwEOJk5VeDh1yAs597tcSvRxvEBEJ sliPtWMs5cpANPoZN47ZopCKcMLhQaeewGQcHpGO1Pof4Z/MnJO0h7+xvo12ojhw5alG uQTGxwtKajNAHOfmLZaztzIbf9ToLl6sxoNwNDcAcGySEtwO1mfO4GAdZlTtYVMUC6od 6xyRoVTcc7eScAwId9c2wlaLjKPv0pE4JxA+ww5QGro6t+5S/HSZWMMDo0IskEqzbGGC TP6MKbuEYRj3CmVBHCxLc5bGsBtyjYRb8PzRaT41m5rqvzWyaAUAjPyf7W88KKTF4QYB NNFw== X-Gm-Message-State: AGi0PuZtgTStrOc/UZ9Pk+3i/aMVBB1DbGt8aiF+70JCgB2E33ut+vnD rOUtOsd4YffKIwF259IHxPHcAC5QqWEGutoOuL1CGg== X-Received: by 2002:a05:6512:685:: with SMTP id t5mr7019601lfe.47.1587289892894; Sun, 19 Apr 2020 02:51:32 -0700 (PDT) MIME-Version: 1.0 References: <20200418081637.1585-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200418081637.1585-1-christophe.jaillet@wanadoo.fr> From: Linus Walleij Date: Sun, 19 Apr 2020 11:51:21 +0200 Message-ID: Subject: Re: [PATCH] PCI: v3-semi: Fix a memory leak in some error handling paths in 'v3_pci_probe()' To: Christophe JAILLET Cc: Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , linux-pci , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 18, 2020 at 10:16 AM Christophe JAILLET wrote: > IF we fails somewhere in 'v3_pci_probe()', we need to free 'host'. > Use the managed version of 'pci_alloc_host_bridge()' to do that easily. > The use of managed resources is already widely used in this driver. > > Fixes: 68a15eb7bd0c ("PCI: v3-semi: Add V3 Semiconductor PCI host driver") > Signed-off-by: Christophe JAILLET Acked-by: Linus Walleij Yours, Linus Walleij