Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200419041651.GD166864@dtor-ws> <20200419074624.9955-1-priv.luk@gmail.com>
 <20200419180136.GK166864@dtor-ws> <CAJmEJMzzFO1G=iQy=EfwQ89iWMjpcpupBjBkG29aigqYsc36bA@mail.gmail.com>
In-Reply-To: <CAJmEJMzzFO1G=iQy=EfwQ89iWMjpcpupBjBkG29aigqYsc36bA@mail.gmail.com>
From:   LuK1337 <priv.luk@gmail.com>
Date:   Sun, 19 Apr 2020 20:22:48 +0200
Message-ID: <CAJmEJMxDsPmOpYHYYzUXYxknFe6Uwo6OuF+=Q3bzUmqxK3Psag@mail.gmail.com>
Subject: Re: [PATCH] Input: xpad - Update xboxone fw2015 init packet
Cc:     LuK1337 <priv.luk@gmail.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Allison Randal <allison@lohutok.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Richard Fontana <rfontana@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I had this issue with official Microsoft Xbox One S Controler (model: 1708)=
;
It might also be firmware version related as I recently updated my firmware
to the latest one but I'm not sure about that.

(also sorry for duplicate msgs that you might have received from me;
I'm new to lkml)
On Sun, Apr 19, 2020 at 8:14 PM LuK1337 <priv.luk@gmail.com> wrote:
>
> I had this issue with official Microsoft Xbox One S Controler (model: 170=
8);
> It might also be firmware version related as I recently updated my firmwa=
re
> to the latest one but I'm not sure about that.
>
> On Sun, Apr 19, 2020 at 8:01 PM Dmitry Torokhov <dmitry.torokhov@gmail.co=
m> wrote:
>>
>> On Sun, Apr 19, 2020 at 09:46:23AM +0200, LuK1337 wrote:
>> > From: =C5=81ukasz Patron <priv.luk@gmail.com>
>> >
>> > Appending { 0x05, 0x20, 0x02, 0x0f, 0x06 } to
>> > xboxone_fw2015_init fixes an issue where the
>> > controller is somewhat stuck in bluetooth
>> > mode until you plug it into Windows PC.
>> >
>> > Signed-off-by: =C5=81ukasz Patron <priv.luk@gmail.com>
>>
>> Thank you =C5=81ukasz. Could you please tell me what device(s) have you
>> observed the issue with? I am a bit worried if this may interfere with
>> other devices that currently work fine with the driver. Cameron, Mark,
>> do you have any concerns here?
>>
>> > ---
>> >  drivers/input/joystick/xpad.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xp=
ad.c
>> > index 6b40a1c68f9f..894fa81f717a 100644
>> > --- a/drivers/input/joystick/xpad.c
>> > +++ b/drivers/input/joystick/xpad.c
>> > @@ -455,7 +455,8 @@ struct xboxone_init_packet {
>> >   * or later firmware installed (or present from the factory).
>> >   */
>> >  static const u8 xboxone_fw2015_init[] =3D {
>> > -     0x05, 0x20, 0x00, 0x01, 0x00
>> > +     0x05, 0x20, 0x00, 0x01, 0x00,
>> > +     0x05, 0x20, 0x02, 0x0f, 0x06
>> >  };
>> >
>> >  /*
>> > --
>> > 2.26.0
>> >
>>
>> Thanks.
>>
>> --
>> Dmitry