Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964772AbWCBSQc (ORCPT ); Thu, 2 Mar 2006 13:16:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964773AbWCBSQb (ORCPT ); Thu, 2 Mar 2006 13:16:31 -0500 Received: from nproxy.gmail.com ([64.233.182.196]:47482 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S964772AbWCBSQa convert rfc822-to-8bit (ORCPT ); Thu, 2 Mar 2006 13:16:30 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=bF01eRPbml3WgsgyCYbK71wzCQ0gwFX68lTzKTjG2kVwX40tYKlRGFg8mCwAqaAsv9q0dw22sWfey17kC1nBgn8Fod+gZpHPHDF3oTPF24FS8PLjsMBenpXlxX0qZ1XQUjg/bQ4E/VwVPjUADMnRnorIxbAKB+NjyZV469J5X2I= From: Jesper Juhl To: Steffen Weber Subject: Re: Another compile problem with 2.6.15.5 on AMD64 Date: Thu, 2 Mar 2006 19:16:49 +0100 User-Agent: KMail/1.9.1 Cc: linux-kernel@vger.kernel.org, Andi Kleen , Christoph Lameter , J.E.J.Bottomley@hansenpartnership.com, stable@kernel.org References: <44071AF3.1010400@steffenweber.net> <200603021859.29728.jesper.juhl@gmail.com> <4407347F.1000209@steffenweber.net> In-Reply-To: <4407347F.1000209@steffenweber.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200603021916.50053.jesper.juhl@gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3017 Lines: 83 On Thursday 02 March 2006 19:07, Steffen Weber wrote: > Jesper Juhl wrote: > > On Thursday 02 March 2006 18:49, Steffen Weber wrote: > >> Jesper Juhl wrote: > >>> On 3/2/06, Steffen Weber wrote: > >>>> Jesper Juhl wrote: > >>>>> On Thursday 02 March 2006 17:18, Steffen Weber wrote: > >>>>>> I?m getting a compile error with 2.6.15.5 on x86_64 using GCC 3.4.4 > >>>>>> (does not seem to be related to the NFS one): > >>>>>> > >>>>>> CC mm/mempolicy.o > >>>>>> mm/mempolicy.c: In function `get_nodes': > >>>>>> mm/mempolicy.c:527: error: `BITS_PER_BYTE' undeclared (first use in > >>>>>> this function) > >>>>>> mm/mempolicy.c:527: error: (Each undeclared identifier is reported only > >>>>>> once > >>>>>> mm/mempolicy.c:527: error: for each function it appears in.) > >>>>>> [snip] > > > > Try this patch instead : > This patch solves the problem! :-) I have not yet rebooted the machine > (it?s a busy webserver), but in case I do not reply again within one day > you can assume that it works fine. Thank you very much! > Thank you for the feedback. Andi, Christoph : would this make sense as a fix for -stable ? How about mainline ? Fix build error in mm/mempolicy.c due to missing `BITS_PER_BYTE'. Signed-off-by: Jesper Juhl --- arch/i386/mach-voyager/voyager_cat.c | 1 - include/linux/types.h | 2 ++ mm/mempolicy.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) --- linux-2.6.15.5/mm/mempolicy.c~ 2006-03-02 18:05:18.000000000 +0100 +++ linux-2.6.15.5/mm/mempolicy.c 2006-03-02 18:05:18.000000000 +0100 @@ -82,7 +82,7 @@ #include #include #include -#include +#include #include #include --- linux-2.6.15.5/arch/i386/mach-voyager/voyager_cat.c~ 2006-03-02 18:55:47.000000000 +0100 +++ linux-2.6.15.5/arch/i386/mach-voyager/voyager_cat.c 2006-03-02 18:55:47.000000000 +0100 @@ -114,7 +114,6 @@ static struct resource qic_res = { * It writes num_bits of the data buffer in msg starting at start_bit. * Note: This function assumes that any unused bit in the data stream * is set to zero so that the ors will work correctly */ -#define BITS_PER_BYTE 8 static void cat_pack(__u8 *msg, const __u16 start_bit, __u8 *data, const __u16 num_bits) { --- linux-2.6.15.5/include/linux/types.h~ 2006-03-02 18:54:57.000000000 +0100 +++ linux-2.6.15.5/include/linux/types.h 2006-03-02 18:54:57.000000000 +0100 @@ -8,6 +8,8 @@ (((bits)+BITS_PER_LONG-1)/BITS_PER_LONG) #define DECLARE_BITMAP(name,bits) \ unsigned long name[BITS_TO_LONGS(bits)] + +#define BITS_PER_BYTE 8 #endif #include - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/