Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next 01/10] net: hns3: split out
 hclge_fd_check_ether_tuple()
To:     David Miller <davem@davemloft.net>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
        <linuxarm@huawei.com>, <kuba@kernel.org>, <shenjian15@huawei.com>
References: <1587192429-11463-1-git-send-email-tanhuazhong@huawei.com>
 <1587192429-11463-2-git-send-email-tanhuazhong@huawei.com>
 <20200418.201746.783676213458110248.davem@davemloft.net>
From:   tanhuazhong <tanhuazhong@huawei.com>
Message-ID: <d6cdcc43-94a9-318c-fec1-b26b0eb70015@huawei.com>
Date:   Mon, 20 Apr 2020 09:04:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20200418.201746.783676213458110248.davem@davemloft.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/4/19 11:17, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@huawei.com>
> Date: Sat, 18 Apr 2020 14:47:00 +0800
> 
>> +static int hclge_fd_check_spec(struct hclge_dev *hdev,
>> +			       struct ethtool_rx_flow_spec *fs,
>> +			       u32 *unused_tuple)
>> +{
>> +	int ret = 0;
> 
> There is no code path that uses 'ret' without it first being
> assigned.  If I let this code in, then someone is going to
> submit a fixup patch removing the initialization.
> 

Yes, will modify it.
Thanks.

> .
>