Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3215297ybz; Sun, 19 Apr 2020 21:02:05 -0700 (PDT) X-Google-Smtp-Source: APiQypLaAVbxbFYvv7Zc69UzoktFfcW0khnShFGH9dkwJnjMgNA9lUnX0yH/ZSBLPg2KaJFUB/zM X-Received: by 2002:a17:906:2ccc:: with SMTP id r12mr14349433ejr.47.1587355325842; Sun, 19 Apr 2020 21:02:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587355325; cv=none; d=google.com; s=arc-20160816; b=mp8sdeOJNH/UCZ48cWHswrFV2xaGxRtPmBnK6XnoYdtrjxSX54FDdU0aOFI+BatUeW QZuwpkGG4Y0o06henbg83CwMRJ1ACyywLU+qe2zzkgyc4pEa7NWh+wshDXEjB5HNmRKZ n34SWDuBPOqPiVrJwlyZG/1+MkoyLfJUFTVlXKm14kWoDfjA6dlMWW7esxNY9E2AYL7B YYCga4t+/bIKFu2mRvKCve7tehLfzHRFXA9r51ZdIWGwpH5Z+qlisuVE4F1pYsJJt9dU JZU0dw8yczVrdVx/1V9czLM6tUXmfCB6GSAQqbGTQEm3NxPsBsVkMZj7GSoDX9KwOZst SE1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=W0jPBHTAC5bBH/FcV/2w7Gmi2D9HYXqK891JaCdMM1k=; b=Q3r58+Y2TY/aYfmpRymJG0vFKsHFDZ8k6dbXYwKw3KC5r0Ur71e0c/Xfuq0hiTz30m 3HZy/L1xfbLa1FP7lqajydqiPHN7oq5zPoGgV4PJB5VNe0Os6zGLI8lTXlvf7SZa29YN FcdLhaLqJZIRgAZx9qO7VxXiNqCwS7+xi+Rziwn4jMys9JhKr7jRHZ22zhZQudP8S3eF cafszVWDJ6/rx43Z6bnrYIdHgtq/pR1GKfZhNSnnk2VmXriU2VATunGQpPjxI+zL9NdX /iw4httYXXGODCFrx79HmA0FepX9CHSonZ84SYtEWyfzDcwzSHBnrhFLuIeGu9KUXu7/ u2DQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn14si23709664ejc.261.2020.04.19.21.01.43; Sun, 19 Apr 2020 21:02:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726043AbgDTEA2 (ORCPT + 99 others); Mon, 20 Apr 2020 00:00:28 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2805 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725681AbgDTEA2 (ORCPT ); Mon, 20 Apr 2020 00:00:28 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 27E02A16B7C134081862; Mon, 20 Apr 2020 12:00:25 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 20 Apr 2020 12:00:16 +0800 From: Jason Yan To: , , , , , , Subject: [PATCH] rtlwifi: rtl8723ae: fix warning comparison to bool Date: Mon, 20 Apr 2020 12:26:58 +0800 Message-ID: <20200420042658.18733-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c:617:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c:622:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c:627:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c:632:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c:937:5-13: WARNING: Comparison to bool Signed-off-by: Jason Yan --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c index 655460f61bbc..7a46c6a9deae 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c @@ -614,22 +614,22 @@ static bool _rtl8723e_llt_table_init(struct ieee80211_hw *hw) for (i = 0; i < (txpktbuf_bndy - 1); i++) { status = _rtl8723e_llt_write(hw, i, i + 1); - if (true != status) + if (!status) return status; } status = _rtl8723e_llt_write(hw, (txpktbuf_bndy - 1), 0xFF); - if (true != status) + if (!status) return status; for (i = txpktbuf_bndy; i < maxpage; i++) { status = _rtl8723e_llt_write(hw, i, (i + 1)); - if (true != status) + if (!status) return status; } status = _rtl8723e_llt_write(hw, maxpage, txpktbuf_bndy); - if (true != status) + if (!status) return status; rtl_write_byte(rtlpriv, REG_CR, 0xff); @@ -934,7 +934,7 @@ int rtl8723e_hw_init(struct ieee80211_hw *hw) rtlpriv->intf_ops->disable_aspm(hw); rtstatus = _rtl8712e_init_mac(hw); - if (rtstatus != true) { + if (!rtstatus) { pr_err("Init MAC failed\n"); err = 1; goto exit; -- 2.21.1