Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michal Kalderon <mkalderon@marvell.com>
To:     Jason Yan <yanaijie@huawei.com>, Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] qed: use true,false for bool variables
Thread-Topic: [EXT] [PATCH] qed: use true,false for bool variables
Thread-Index: AQHWFshMdBvpX8m6sE6ahXBKJnXf6qiBbhow
Date:   Mon, 20 Apr 2020 04:41:02 +0000
Message-ID: <MN2PR18MB31825BA5D9769293119AB240A1D40@MN2PR18MB3182.namprd18.prod.outlook.com>
References: <20200420042720.18815-1-yanaijie@huawei.com>
In-Reply-To: <20200420042720.18815-1-yanaijie@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 627470f7-4e3b-4557-1fd7-08d7e4e507aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2020 04:41:02.2708
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B580cYzH87OwukS83kW4LwXr5/e1kaHL3wbJkb8ez1q3SEqq6P4ZM5hTkmCCYQTzTlzx6EB1PaDoGGvd/QUXHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2494
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-04-20_01:2020-04-17,2020-04-20 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Yan <yanaijie@huawei.com>
> Sent: Monday, April 20, 2020 7:27 AM
>=20
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
>=20
> drivers/net/ethernet/qlogic/qed/qed_dev.c:4395:2-34: WARNING:
> Assignment of 0/1 to bool variable
> drivers/net/ethernet/qlogic/qed/qed_dev.c:1975:2-34: WARNING:
> Assignment of 0/1 to bool variable
>=20
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> index 38a65b984e47..7119a18af19e 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
> @@ -1972,7 +1972,7 @@ static int qed_init_qm_sanity(struct qed_hwfn
> *p_hwfn)
>  		return 0;
>=20
>  	if (QED_IS_ROCE_PERSONALITY(p_hwfn)) {
> -		p_hwfn->hw_info.multi_tc_roce_en =3D 0;
> +		p_hwfn->hw_info.multi_tc_roce_en =3D false;
>  		DP_NOTICE(p_hwfn,
>  			  "multi-tc roce was disabled to reduce requested
> amount of pqs\n");
>  		if (qed_init_qm_get_num_pqs(p_hwfn) <=3D
> RESC_NUM(p_hwfn, QED_PQ)) @@ -4392,7 +4392,7 @@
> qed_get_hw_info(struct qed_hwfn *p_hwfn,
>  	}
>=20
>  	if (QED_IS_ROCE_PERSONALITY(p_hwfn))
> -		p_hwfn->hw_info.multi_tc_roce_en =3D 1;
> +		p_hwfn->hw_info.multi_tc_roce_en =3D true;
>=20
>  	p_hwfn->hw_info.num_hw_tc =3D NUM_PHYS_TCS_4PORT_K2;
>  	p_hwfn->hw_info.num_active_tc =3D 1;
> --
> 2.21.1

Thanks,=A0

Acked-by: Michal Kalderon=A0<michal.kalderon@marvell.com>