Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Michal Kalderon <mkalderon@marvell.com>
To:     Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>,
        Ariel Elior <aelior@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] net: qed: Remove unneeded cast from memory
 allocation
Thread-Topic: [EXT] [PATCH] net: qed: Remove unneeded cast from memory
 allocation
Thread-Index: AQHWFmwoeqWB1WncF0miF4Eo8ULEd6iBd3iQ
Date:   Mon, 20 Apr 2020 05:11:54 +0000
Message-ID: <MN2PR18MB318225752E61524F09CE1331A1D40@MN2PR18MB3182.namprd18.prod.outlook.com>
References: <20200419162917.23030-1-aishwaryarj100@gmail.com>
In-Reply-To: <20200419162917.23030-1-aishwaryarj100@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f6fc88e6-6a7e-4417-a073-08d7e4e95802
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2020 05:11:55.0055
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N4qL+EFE/Hg+UF4Y0x6dJxk0amQYHlaaBlFTH1U9pcftHaPy3ggNdCjdEM6BNYU1BSgxJGOpG9PcN5mWnXysIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2480
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-04-20_01:2020-04-17,2020-04-20 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
> Sent: Sunday, April 19, 2020 7:29 PM
>=20
> ----------------------------------------------------------------------
> Remove casting the values returned by memory allocation function.
>=20
> Coccinelle emits WARNING: casting value returned by memory allocation
> function to struct pointer is useless.
>=20
> This issue was detected by using the Coccinelle.
>=20
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_roce.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_roce.c
> b/drivers/net/ethernet/qlogic/qed/qed_roce.c
> index 37e70562a964..475b89903f46 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_roce.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_roce.c
> @@ -736,9 +736,9 @@ static int qed_roce_sp_destroy_qp_responder(struct
> qed_hwfn *p_hwfn,
>=20
>  	p_ramrod =3D &p_ent->ramrod.roce_destroy_qp_resp;
>=20
> -	p_ramrod_res =3D (struct roce_destroy_qp_resp_output_params *)
> -	    dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
> sizeof(*p_ramrod_res),
> -			       &ramrod_res_phys, GFP_KERNEL);
> +	p_ramrod_res =3D dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
> +					  sizeof(*p_ramrod_res),
> +					  &ramrod_res_phys, GFP_KERNEL);
>=20
>  	if (!p_ramrod_res) {
>  		rc =3D -ENOMEM;
> @@ -872,10 +872,10 @@ int qed_roce_query_qp(struct qed_hwfn
> *p_hwfn,
>  	}
>=20
>  	/* Send a query responder ramrod to FW to get RQ-PSN and state */
> -	p_resp_ramrod_res =3D (struct roce_query_qp_resp_output_params
> *)
> -	    dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
> -			       sizeof(*p_resp_ramrod_res),
> -			       &resp_ramrod_res_phys, GFP_KERNEL);
> +	p_resp_ramrod_res =3D
> +		dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
> +				   sizeof(*p_resp_ramrod_res),
> +				   &resp_ramrod_res_phys, GFP_KERNEL);
>  	if (!p_resp_ramrod_res) {
>  		DP_NOTICE(p_hwfn,
>  			  "qed query qp failed: cannot allocate memory
> (ramrod)\n"); @@ -920,8 +920,7 @@ int qed_roce_query_qp(struct
> qed_hwfn *p_hwfn,
>  	}
>=20
>  	/* Send a query requester ramrod to FW to get SQ-PSN and state */
> -	p_req_ramrod_res =3D (struct roce_query_qp_req_output_params *)
> -			   dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
> +	p_req_ramrod_res =3D dma_alloc_coherent(&p_hwfn->cdev->pdev-
> >dev,
>  					      sizeof(*p_req_ramrod_res),
>  					      &req_ramrod_res_phys,
>  					      GFP_KERNEL);
> --
> 2.17.1

Thanks,=A0

Acked-by: Michal Kalderon=A0<michal.kalderon@marvell.com>