Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Apr 2020 08:13:39 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     Tang Bin <tangbin@cmss.chinamobile.com>,
        Shengju Zhang <zhangshengju@cmss.chinamobile.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: asic3: Add error checking return in
 asic3_mfd_probe()
Message-ID: <20200420071339.GG3737@dell>
References: <b9626e96-4bdb-e7e1-51e7-a99210de4c32@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b9626e96-4bdb-e7e1-51e7-a99210de4c32@web.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 19 Apr 2020, Markus Elfring wrote:

> > In the function asic3_mfd_probe(), when get resource or irq
> > failed, the value returned just detected and debug error message,
> > but there were no error checking return. So add the right error
> > checking return.
> 
> I suggest to improve the commit message.
> Would you like to adjust the patch subject?
> 
> 
> > And remove the redundant 'ret = 0'.
> 
> I propose to reconsider this interpretation of the source code here.
> How do you think about to move the mentioned statement into an else branch
> at the end?

Could you please fix your mailer.

If you do not, your replies will be lost/discounted!

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog