Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3352747ybz; Mon, 20 Apr 2020 00:41:49 -0700 (PDT) X-Google-Smtp-Source: APiQypLTec18+aRfepq5kn8xgXI7aqf1dcse38GMzkYbHA5d4AHOM/kQAg4P9ntBJI7X/rqit0xK X-Received: by 2002:a50:a2e5:: with SMTP id 92mr13427545edm.139.1587368509015; Mon, 20 Apr 2020 00:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587368509; cv=none; d=google.com; s=arc-20160816; b=n5zKMgF9yxN6pg9BYEeAabOYlBrq/OboTiGBMPC/xMTUAcrjKkT0JAGMH8YFMUNzIH tQE3d1t2suXjPFZ8JePYSEQa22BgLNSYIpTtWH+JBnatoZavhdnfjNMdj5VUNI92i2aA 8kW12FKCkqBdloKSkGwkuPp5qnYJqJAbtnH6rXBtEJo/2LerSUFiDjbx1iz07YAqjPp0 T/TA6Faj9nOddoeoIX4J0w6kNybzrtu286QgRcplLO+aKcUmVnSZCd9HlqTYZM7F5C08 1mu0OPOzMZpDGMCJeTf6/SvLSOs6vrI9td/qbEhMmPJQjcCrqD5gIda48/2+b1AXdd8v lwxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=SHrAyI4hY3YiSkAxTvag1lf+wMv8nkw9/JV2RkaFOOE=; b=BBEAJY0z1cR46NMCV8+j+6kFF0XfCAbu0gwgekpwwb3G3dbESvXk4sx1tPyfgfT5Yc uWbRc5XVNi+iT6fjaQrPBUcEvBvlAoRHtLjkCuw3TKZ/WAVf8UKj+ewi09yokLWLZl/I KfDXOOLl335FwvYzSH8fdNG7f/qxFUhA0Gv2bJRWhlmOE01vHzCrz2sWWepjMoeT1zFZ F67yIb6CJtPtcbC3c5OYexOqDfM8IDkWOCv679BLWoH38/TGnLodRQslKwcA75tafQbm RFrrXEeqDH4sZ0BP2AFdg9ScBerh33ut1ovH9BU9Dft2Nn9mL3yhXzt4JqyHuXI7Mtii BEIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m11si73095edq.373.2020.04.20.00.41.25; Mon, 20 Apr 2020 00:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726025AbgDTHkY (ORCPT + 99 others); Mon, 20 Apr 2020 03:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725773AbgDTHkY (ORCPT ); Mon, 20 Apr 2020 03:40:24 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC15EC061A0C; Mon, 20 Apr 2020 00:40:23 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 0FEDC2A0A21; Mon, 20 Apr 2020 08:40:21 +0100 (BST) Date: Mon, 20 Apr 2020 09:40:18 +0200 From: Boris Brezillon To: "Ramuthevar, Vadivel MuruganX" Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, arnd@arndb.de, brendanhiggins@google.com, tglx@linutronix.de, anders.roxell@linaro.org, masonccyang@mxic.com.tw, piotrs@cadence.com, robh+dt@kernel.org, linux-mips@vger.kernel.org, hauke.mehrtens@intel.com, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, cheol.yong.kim@intel.com Subject: Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Message-ID: <20200420094018.6fdbda68@collabora.com> In-Reply-To: <79e186a8-68fb-0e75-910b-9f1b40679ca2@linux.intel.com> References: <20200417082147.43384-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200417082147.43384-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20200418105533.477ce529@collabora.com> <79e186a8-68fb-0e75-910b-9f1b40679ca2@linux.intel.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Apr 2020 12:18:34 +0800 "Ramuthevar, Vadivel MuruganX" wrote: > >> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig > >> index a80a46bb5b8b..9efc4bbaf4a3 100644 > >> --- a/drivers/mtd/nand/raw/Kconfig > >> +++ b/drivers/mtd/nand/raw/Kconfig > >> @@ -457,6 +457,13 @@ config MTD_NAND_CADENCE > >> Enable the driver for NAND flash on platforms using a Cadence NAND > >> controller. > >> > >> +config MTD_NAND_INTEL_LGM > >> + tristate "Support for NAND controller on Intel LGM SoC" > >> + depends on X86 > > Do we have a hard dependency on x86 here? Maybe 'depends on HAS_MMIO' > > would be enough. > yes Boris, we have hard dependency on x86. Given that the driver will also be used on a MIPS platform I would say no :P. Just to be clear, I was suggesting to replace the soon to emerge depends on X86 || MIPS || COMPILE_TEST depends HAS_IOMEM rule by depends on OF || COMPILE_TEST depends HAS_IOMEM