Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3353978ybz; Mon, 20 Apr 2020 00:43:50 -0700 (PDT) X-Google-Smtp-Source: APiQypK75qqyhtIz5A3TkwDD+BfLaF3ToJlw5x6KqeUsEIet0XuiaP29te2smeJsJgzQqcHmElUn X-Received: by 2002:a50:ef09:: with SMTP id m9mr4535695eds.321.1587368630699; Mon, 20 Apr 2020 00:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587368630; cv=none; d=google.com; s=arc-20160816; b=oe2fivO8JH4s4hIVgndpBRBfS4scDRVurB5m2A/1BV1jAATeuoq2TyDKUNDlT4Gkqh BUKAMU2ppEXvCSRk6aI6wFDkcExnteaePADFY+k7IiF1E+a0DZ4r13WrIGm4x/na6+mz PGDKZrIaD79tiUIy8xDpXBQ2VJet7ffNuGJRb8zvhnGmhgZ64XNiZjHpf5cT9UMkC7Ph 4aaG3rXWye7kE+MKnH/TynMah67bEUct0H1ztZuOAxU/V+peG1tOuojj/Asg40O8kGuk s9UMmTngkHu2NQJW6fVRGeOrbw3XUBQnokpkofz/++jEIFlnFax0apD83ycNldye4PZ8 g3tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=GYBOsS7NEsura90sDNyvyIsp+ZOEQ1cBRo4tEsInb1M=; b=tgXiebUhpXOAB4DCTQlcYuVH+iX28GRvkpCtAJejXfKAE8PVTwpSyKjqJu+IgB4+fq YNWAbikpr8etu887byFKk1qORMn0122DcTT3Usl5d6kdPPy1GFrbmm2gdyC+5W3dLQIh QZ8pMF8Zy0xvVYfTGN9qs5k24htilAY7ITzVAzTvI4ZMNFMyMT8/woccbo6kK+sotsXB 7ydVGbAJuKgKhpOcUJUErI7M7QdIMCiTgUohejtlHylB57+cIimD8T9f37JfhpU+dXK7 KbxN5joucIJfqfrUG3iN9L4fF7sYSFs6+Z4j5/RN8hpeH8mV87g3qgKRHx8B3z7fLmQu Yp7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ShUWMxl0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m11si73095edq.373.2020.04.20.00.43.27; Mon, 20 Apr 2020 00:43:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ShUWMxl0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726048AbgDTHmS (ORCPT + 99 others); Mon, 20 Apr 2020 03:42:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:37643 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725815AbgDTHmS (ORCPT ); Mon, 20 Apr 2020 03:42:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587368536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GYBOsS7NEsura90sDNyvyIsp+ZOEQ1cBRo4tEsInb1M=; b=ShUWMxl0dcU6+kTSPv8GC0kNtgXVr8iwTf11udjCpFHnu/dn3qiKN/9jLdR2qy9fSYUKLE j3/Slk1T+jHHYK7X4wBx0uJkAOHjKEhrwCb9n0a0ABd+R7SqNzf0p/bXyiImxdJ/HHtHQN 6ShUgTi8h7F6V1hMpnOCUirEqAcL3Fk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-xHPYXHKtOQSK9UwMKR4aaQ-1; Mon, 20 Apr 2020 03:42:08 -0400 X-MC-Unique: xHPYXHKtOQSK9UwMKR4aaQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C07E28E5E1; Mon, 20 Apr 2020 07:42:06 +0000 (UTC) Received: from [10.36.114.7] (ovpn-114-7.ams2.redhat.com [10.36.114.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 12B2F92FA2; Mon, 20 Apr 2020 07:42:03 +0000 (UTC) Subject: Re: [PATCH v2] mm/page_alloc: fix watchdog soft lockups during set_zone_contiguous() To: Michal Hocko , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pavel Tatashin , Pankaj Gupta , Baoquan He , Shile Zhang , Kirill Tkhai , Daniel Jordan , Alexander Duyck , Oscar Salvador References: <20200416073417.5003-1-david@redhat.com> <20200417151247.0068d5aa3f026ced2289ce31@linux-foundation.org> <20200420073434.GE27314@dhcp22.suse.cz> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <4672023c-dacd-0b72-a45d-f42a660604e6@redhat.com> Date: Mon, 20 Apr 2020 09:42:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200420073434.GE27314@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.04.20 09:34, Michal Hocko wrote: > On Fri 17-04-20 15:12:47, Andrew Morton wrote: >> On Thu, 16 Apr 2020 09:34:17 +0200 David Hildenbrand wrote: >> >>> Without CONFIG_PREEMPT, it can happen that we get soft lockups detected, >>> e.g., while booting up. >>> >>> ... >>> >>> --- a/mm/page_alloc.c >>> +++ b/mm/page_alloc.c >>> @@ -1607,6 +1607,7 @@ void set_zone_contiguous(struct zone *zone) >>> if (!__pageblock_pfn_to_page(block_start_pfn, >>> block_end_pfn, zone)) >>> return; >>> + cond_resched(); >>> } >>> >>> /* We confirm that there is no hole */ >> >> I added cc:stable to this one. Please let me know if that wasn't a >> good idea. > > Really large memory setups tend to run on distribution kernels so > backporting to old kernels doesn't really harm. > Yeah, shouldn't hurt. -- Thanks, David / dhildenb