Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3397740ybz; Mon, 20 Apr 2020 01:50:01 -0700 (PDT) X-Google-Smtp-Source: APiQypJ8mBWXMWritNZsU0mDoF296oGKeoOr0Ub0gDKsaNgt4jczChx6sFskCjXC9kXpSnzSFYn4 X-Received: by 2002:a50:950a:: with SMTP id u10mr13747401eda.45.1587372601187; Mon, 20 Apr 2020 01:50:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587372601; cv=none; d=google.com; s=arc-20160816; b=DQsq/eWm7d8IqWy8ckQAIkX8GSgWbvA5u2ZsaZM3j0mJ1EiWU+NjGfHISkCy3eoTvR Ni23tBKKHQxEDFe8cDu3TXvje3Waic+9gz7oGa9DdQjVLZ5yFB09MlT6RW2UU/EdcpvV HX8pAUN8Kc99fps430mL7bRMeUk/MSTmOmiAR5ytsXfLcL8A4XK+V8ydQfbtyd83KGyu 6GjkOPWBq78UcXQqeEnnbNHIUutEVkzRGRXr9kg08YEZuT8c5EzQxHhe6vvvNG9tUOZt cxrf18wDTCXO5QiSJ/xTnvhPqExe6TtCJ80pSM+uJBjfF1NmUxQEFbXJ/0JgOC7m1chB 2ENg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=nROlfWRH9W8nLYXQI9f1gSOsE+u5fKGUlSBD/brz8E8=; b=EG4UOoqTM9BxvEouIbuAvi5lzp55f5rLKqSgJ1QAYKbV4eCWDaHP7RIA4fzrgeal1m UHeB0f+WCiG+06IsukseHA47DTspw7t0IepEqH1G5EuSRRkvHh0xQgvS8/y2LwdotKSk 9HXLfh3xqbhdQSuNcgJYjK6BwdMYlmDcqy7DvBw7+ZX2/osjjvOPhpoRPdsPhr3hlhL3 zwk1PQRdyL7AgI3pzuxaOIsuBO/p9elePRN+lzH8tyNv0v0o1MYx4ZjYxzG4Qu3sCZH4 JPWRRUUq9KW+trRbA8UYNc6/vwvNFUEciMUjg+VWImDC7CCh3/9WzvUfrQ5ZYBik9xis qcSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=X7UpOJas; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l9si138132ejh.463.2020.04.20.01.49.38; Mon, 20 Apr 2020 01:50:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=X7UpOJas; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726023AbgDTIsj (ORCPT + 99 others); Mon, 20 Apr 2020 04:48:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725865AbgDTIsj (ORCPT ); Mon, 20 Apr 2020 04:48:39 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A668AC061A0C for ; Mon, 20 Apr 2020 01:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nROlfWRH9W8nLYXQI9f1gSOsE+u5fKGUlSBD/brz8E8=; b=X7UpOJasJeY0uR/Gz/XARnaeAM 8E+EPRWvK9hk7Trcqic2JJEiFisRF08dBEtJT1zVDVpFBz4vdhCKHOa2Fktnq7aXuQpIDmUcamJz5 PbGfTJGF75LQyAMEr6zBxqgysYmql5PWBBOOLg1/jNKNznHTtrglr7UdgdBj4hAxPcTl+j9AsDs4n N5/15uViDafc8rMuF5SHSKAUhw7VFYvx2PhAOBwNivOFlxcFtmLQCC798GZzIxBfV5ZsJCUbfIaO9 PRHeKUr9DzysgeJnumwfTXMdYdHwY8EQJyMSKM72P6Skpty+CJRpAD6FZcGf1JgOeaY6xs6S6JGSp bvEqTm3Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQS6W-0006bO-SL; Mon, 20 Apr 2020 08:48:36 +0000 Date: Mon, 20 Apr 2020 01:48:36 -0700 From: Christoph Hellwig To: Sidong Yang Cc: Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: qlge: replace deprecated apis pci_dma_* Message-ID: <20200420084836.GA24518@infradead.org> References: <20200419010816.29125-1-realwakka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200419010816.29125-1-realwakka@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 19, 2020 at 10:08:16AM +0900, Sidong Yang wrote: > direction = > - (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? PCI_DMA_TODEVICE : > - PCI_DMA_FROMDEVICE; > + (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) ? DMA_TO_DEVICE : > + DMA_FROM_DEVICE; Can you unobsfucate this while you are at it? if (bit & (CFG_LRQ | CFG_LR | CFG_LCQ)) direction = DMA_TO_DEVICE; else direction = DMA_FROM_DEVICE; Otherwise this looks good: Reviewed-by: Christoph Hellwig