Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 4Z96JFkWbAIR+MhQYI+YtTyJfz6nI8/W3QCzFVKLwOt2RslIrs/yltCSfjgJjY+KzX5gVLo8u9
 uTuXVoL5QdBGHdIkOAoXnn+nqZA6jVJbPhLI2NR+fBdIiIRm4gCShYW7kFfNjmTqK5RDi/5eRM
 EkREoWM9zdQXisIDdZPSnOXFo00WTRe5+V0bpqzHbxFIayl2RjH/mJKxn+3uR1vA4MQBwNYzKe
 RRF1xDfuLXCbx2hCcVaHDR3XUAbpySm8PLjNzFBt1SoM8aixHT1Xil/9BMYLGk9w5AE7pidW0s
 bhw=
From:   <Tudor.Ambarus@microchip.com>
To:     <masonccyang@mxic.com.tw>
CC:     <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
        <juliensu@mxic.com.tw>, <linux-kernel@vger.kernel.org>,
        <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support
Thread-Topic: [PATCH 2/2] mtd: spi-nor: macronix: Add mx25u51245g support
Thread-Index: AQHWFvHANv13lIezFkiOi0jmtp6uRQ==
Date:   Mon, 20 Apr 2020 08:57:42 +0000
Message-ID: <3097723.HxHl8gbcWJ@192.168.0.120>
References: <1586163611-4565-1-git-send-email-masonccyang@mxic.com.tw>
 <1586163611-4565-3-git-send-email-masonccyang@mxic.com.tw>
In-Reply-To: <1586163611-4565-3-git-send-email-masonccyang@mxic.com.tw>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <57C680001698114395CA3E1C226FA7BB@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ab0366f5-b2f1-46df-4608-08d7e508e32a
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2020 08:57:42.8832
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gPdHAq6HiyBjsjCQlsb61Lruv2g+nVHsVW2UkNC1LV8ZUzK36XLH/e2jsaK0nDSBWTpO1tCGrslfUU0lmSYJiZlH1uLqoQV7ppbH3ajkMNY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3878
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Mason,

On Monday, April 6, 2020 12:00:11 PM EEST Mason Yang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> mx25u51245g is a mass production for new design and
> replace mx66u51235f(phase out).
>=20
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
>  drivers/mtd/spi-nor/macronix.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/mtd/spi-nor/macronix.c b/drivers/mtd/spi-nor/macroni=
x.c
> index c864ac8..e685aec 100644
> --- a/drivers/mtd/spi-nor/macronix.c
> +++ b/drivers/mtd/spi-nor/macronix.c
> @@ -73,6 +73,9 @@
>         { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024,
>                               SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>                               SPI_NOR_4B_OPCODES) },
> +       { "mx25u51245g", INFO(0xc2253a, 0, 64 * 1024, 1024,

Shouldn't the ID be 0xc2953a?

We usually don't add new flashes if they are not tested. Please specify in =
the=20
commit message with which controller you tested the flash. Please do the sa=
me=20
for the previous patch.

The minimal test is a read, erase, read back, write and read back. This=20
sequence should verify if read, erase and pp work fine.

Cheers,
ta