Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3421944ybz; Mon, 20 Apr 2020 02:24:19 -0700 (PDT) X-Google-Smtp-Source: APiQypKw2np/yY9jLG8jufaEbClOaME4Ll/TJ7R8gx+v8tWq4UEQC7XRw4xOoulEqL+6KCTvvD2y X-Received: by 2002:aa7:d689:: with SMTP id d9mr10793903edr.22.1587374658954; Mon, 20 Apr 2020 02:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587374658; cv=none; d=google.com; s=arc-20160816; b=u95U2oxMviOGyxt2k4hcoO+qpU4ELuThlJ1cPX2ZZREfrptFPUthqX9kn/gJcsAJp0 ooJDEjJRW5MbOGcL60RBUs1p+ut1xSqm38EZtY9riWsx1NcH9cz+WwF8Y5oPXZ5Evw0j 2DPccA/xnuHwqp2DAjJ8x+11IYlwtDrfiv9dJTbGjUMsiO9SIzkpl7LNiY0weFmGuatr aZdftdZ4+XGeTt8XUsztHMB3vtNqFmMcBRzsYgoD3dt1fehRznq+4BNLEaUYoMqqa01W OIVr+c+dx0d/WKHRvFEyMVdWOw5MypaWQSe0Z7eOLJUgAqyVkIHJN2rDc4L430GPZbo3 dh/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=xsDgFULRevrMl2sYWxpKGSHmJwAeC5VY0bWDB58Zd2A=; b=WfhUIj1Da+p6gBnjQMgq/ZoPvWEOHBPe6B/ldcgXtUrYeJ/pJjSIumoW9M8EfQyTTg UMnKOSe7P5TqC+xaXQY+NMw41uO5zimiImMsKZ1YjF90H0rocrHVq/zkhRZ+Q0BG0QVT dgeAqCQSVdoQfzWSbAi+cGOM+ofKX3ljtQOQMetD1d5BMeAL3wzb/A99PFbo1VSSeV5k vUBPPF18C/Hrl7VgCG3a3lBPCcBjXnRc6TY+wgWcuDzZrZnDLC7ipetNmixEUqfHTfOj uk6wc8BpPWL1TT+yhzxZoMU0LGdBjFF4Mb55hQFX5uoOzvV/RK2jjsYRSP3RphjYhtoy 3iMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MZrLkzLP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n23si184728edt.420.2020.04.20.02.23.56; Mon, 20 Apr 2020 02:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MZrLkzLP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726048AbgDTJUq (ORCPT + 99 others); Mon, 20 Apr 2020 05:20:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725773AbgDTJUq (ORCPT ); Mon, 20 Apr 2020 05:20:46 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82957C061A0C for ; Mon, 20 Apr 2020 02:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xsDgFULRevrMl2sYWxpKGSHmJwAeC5VY0bWDB58Zd2A=; b=MZrLkzLPpycDjQP6LwIrPimNRM 5L8jsbG/Mo/aSiWJWStljnn2qE06Q5cgrHi6ryTY8LuSjSGBRtHSIb1gGf65z0dZMwQ9Uv5JIGL1f qK1I5blOxqykYjfzrJ7UrzcbYZAKhmeVw1JVt6216hkQUsgTdb0VZOj09iowMR5fcBkIHLWcbsqDM JpsNoZWlI2Lv5MZ/y2+nFKkCimMZBfhbS4wpZEQz0NXYH/EMT1itRPifzI9AKIGAMmwx+TlF1emPf Vb3SiXzESC0epAhuWHEhlvZpLuLu96rcdyY1lpgcsrebCcnz+ohepTncH84NZEtpJchv6CHhfUmDb BwvjitWw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQSbd-0007ea-N1; Mon, 20 Apr 2020 09:20:45 +0000 Date: Mon, 20 Apr 2020 02:20:45 -0700 From: Christoph Hellwig To: Thomas Gleixner Cc: LKML , x86@kernel.org, Kees Cook , Paolo Bonzini , Thomas Lendacky , Juergen Gross , Boris Ostrovsky Subject: Re: [patch 00/15] x86/tlb: Unexport per-CPU tlbstate Message-ID: <20200420092045.GC24518@infradead.org> References: <20200419203137.214111265@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200419203137.214111265@linutronix.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just looking over some exports at the end of the series (and thus ignoring bisection issues): - Is there any good reason to keep __flush_tlb_all inline vs moving it out of line and kill the flush_tlb_local and flush_tlb_global exports. Also there is just a single modular users in SVM, I wonder if there is any way to get rid of that one as well. Also I think cpu_tlbstate itself could be marked static in tlb.c with a few more changes, I wonder if would be worth it?