Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3468811ybz; Mon, 20 Apr 2020 03:24:53 -0700 (PDT) X-Google-Smtp-Source: APiQypJDWX9UHmY17QyS69aIiGW1sTauLOAh3KprJORB3rWz+oxtaWNqmUU3gllZAVSlyYp4IZPJ X-Received: by 2002:a17:906:af94:: with SMTP id mj20mr14912143ejb.347.1587378293556; Mon, 20 Apr 2020 03:24:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587378293; cv=none; d=google.com; s=arc-20160816; b=RayqtjG7p27QN0AOcuGbeSmkX/S5ML8iXpqHfspgdlnFtTrWFKN3cPgx5tVB5kTA7o ofGBsiok/o+NeKKarUYQpBkC+lPIKVhdId3wFs7I2eh1Rd1o/pf0YaERUY2er5ndPlAB egg9r9rNIOd30EPKDgUnbnSWmutguPs5gzAHRz6H+muWcZgATMI47tyEM4PwFOSnTlvb d4XRt6kRKt3SeQPq+UFmM27ISGppzQnpp9F3M7jv6COgGM3MbSBOOCUSlhx1/ojjXabf EYa7GX0+w2KD9ug8dShRgei5YISS6qowyVPhPpplWucUCjErG/hU9PsdHUnZnCJfklXC KAjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=1ZknaaCRqM8ok1TumQJFw1bFXB8g2z2jmJQA2V99IEA=; b=V7qVxQQolPpuTX5cABDC6Q3zuzWTKIAcrC5rQKirRCZmJpBvIDwdCvWRHLYp+LcQLj 6shhmwGJqyvJciwp5yldhfT09MLfq9tHN5Eb0FR0hgh4JneRH0hcU1b+VEmu5aL28afm EYGDHqq2ASHCV/Fr6cqrvZdbloRR3ufR/pXz48eNL841Q2UfCfGHVcGL9bc3n4duqlhx X5fijG4ScVOTlR/GP7caomrWiiRWdY89X4PHeAlP3sGYJDizqV7juu/qJMavow7Yoogk aNharuWe4l+6c5Fch/gLqytLkFROSwdfxeBN3Sgf+/f0xtjF7HuhvPP2K6D2mzzP7PUT N0fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="X/dPq2lG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si270620eje.61.2020.04.20.03.24.30; Mon, 20 Apr 2020 03:24:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b="X/dPq2lG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbgDTKVa (ORCPT + 99 others); Mon, 20 Apr 2020 06:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725775AbgDTKV3 (ORCPT ); Mon, 20 Apr 2020 06:21:29 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE145C061A0C for ; Mon, 20 Apr 2020 03:21:28 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id 188so4213481wmc.2 for ; Mon, 20 Apr 2020 03:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1ZknaaCRqM8ok1TumQJFw1bFXB8g2z2jmJQA2V99IEA=; b=X/dPq2lGh45WCtM8GbUNRLpiUGJ8jisge3aCCjcOQW05bLmBlqHzJT2GMLGRrWd3sO YjNbUG63hP1vykXrzcvpwIXbXb/93+OxR/jSx2CBM0gaXZc39NyM7t8A8g/2kAF5KaHK 5MoJYfegZ0Bo5hjy6p+R5Ym/ccbN4FvbU+LfNQHdgV3NH3yS561J2jtEOAmeS4OI6Qkr aerWzUHHOouZtSSedJANSDdVJhwiKEKNlFBhC/Q7fkln4NZ6jkZWdErJ/SsgVAo6mki+ 5XsvfMg/158WuDiNMiAqpuURLmy8mhxi1KMX/FLnYAdYh5rIM/ysgLKpUZWLE4twmteI bJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1ZknaaCRqM8ok1TumQJFw1bFXB8g2z2jmJQA2V99IEA=; b=smzzSnv7tKtQcL1Lb+rf/wvlxaqC+R87YPqBJXn7g39nU7A9pPh2D3vmgBkAinW/2H gmbN9kzIS1O6TPJh6DXj4JOGNvbo+tvFAHTVGoto6w1phXD0XyS3N0RRDtNm6+Ubn3kB JL6agiQvRf35PEbGCOr4OsOWVlCEwNLt8izKB6Hld9yFoDCrSWUoaOnINrKKvy76CNtn W+y9wD7bx/6bFnU3t+jKBkJ6udzmxCd79bXviX6Yj9ol4c3/NQbsDxkRc4ZgF6o2ThuE cZ2qOy6Cthnt/NIRONd65JSRiv3i3u9xrN/8Re83ti43yHT/C/E2b7IN8rOa3hWvBM9z LgdA== X-Gm-Message-State: AGi0PuaIgmroqfIBg35hMejzcvgUwkQJZO06VI+pz/iIyzDaRa8gcXoc wrXSmuL1q+1XjzRjwALaeq78LQ== X-Received: by 2002:a05:600c:29c2:: with SMTP id s2mr16808408wmd.111.1587378087149; Mon, 20 Apr 2020 03:21:27 -0700 (PDT) Received: from ?IPv6:2a01:e35:2ec0:82b0:39cc:a07:8b48:cc56? ([2a01:e35:2ec0:82b0:39cc:a07:8b48:cc56]) by smtp.gmail.com with ESMTPSA id m15sm700512wmc.35.2020.04.20.03.21.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 03:21:26 -0700 (PDT) Subject: Re: [PATCH v5 1/8] drm/fourcc: Add modifier definitions for describing Amlogic Video Framebuffer Compression To: Daniel Vetter Cc: dri-devel , linux-amlogic@lists.infradead.org, Linux ARM , Linux Kernel Mailing List , Kevin Hilman References: <20200416152500.29429-1-narmstrong@baylibre.com> <20200416152500.29429-2-narmstrong@baylibre.com> <20200417150729.GP3456981@phenom.ffwll.local> <65879a34-2e31-2908-3cc4-183f62c70ca0@baylibre.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwU0EVid/pAEQAND7AFhr 5faf/EhDP9FSgYd/zgmb7JOpFPje3uw7jz9wFb28Cf0Y3CcncdElYoBNbRlesKvjQRL8mozV 9RN+IUMHdUx1akR/A4BPXNdL7StfzKWOCxZHVS+rIQ/fE3Qz/jRmT6t2ZkpplLxVBpdu95qJ YwSZjuwFXdC+A7MHtQXYi3UfCgKiflj4+/ITcKC6EF32KrmIRqamQwiRsDcUUKlAUjkCLcHL CQvNsDdm2cxdHxC32AVm3Je8VCsH7/qEPMQ+cEZk47HOR3+Ihfn1LEG5LfwsyWE8/JxsU2a1 q44LQM2lcK/0AKAL20XDd7ERH/FCBKkNVzi+svYJpyvCZCnWT0TRb72mT+XxLWNwfHTeGALE +1As4jIS72IglvbtONxc2OIid3tR5rX3k2V0iud0P7Hnz/JTdfvSpVj55ZurOl2XAXUpGbq5 XRk5CESFuLQV8oqCxgWAEgFyEapI4GwJsvfl/2Er8kLoucYO1Id4mz6N33+omPhaoXfHyLSy dxD+CzNJqN2GdavGtobdvv/2V0wukqj86iKF8toLG2/Fia3DxMaGUxqI7GMOuiGZjXPt/et/ qeOySghdQ7Sdpu6fWc8CJXV2mOV6DrSzc6ZVB4SmvdoruBHWWOR6YnMz01ShFE49pPucyU1h Av4jC62El3pdCrDOnWNFMYbbon3vABEBAAHCwn4EGAECAAkFAlYnf6QCGwICKQkQFpq3saTP +K7BXSAEGQECAAYFAlYnf6QACgkQd9zb2sjISdGToxAAkOjSfGxp0ulgHboUAtmxaU3viucV e2Hl1BVDtKSKmbIVZmEUvx9D06IijFaEzqtKD34LXD6fjl4HIyDZvwfeaZCbJbO10j3k7FJE QrBtpdVqkJxme/nYlGOVzcOiKIepNkwvnHVnuVDVPcXyj2wqtsU7VZDDX41z3X4xTQwY3SO1 9nRO+f+i4RmtJcITgregMa2PcB0LvrjJlWroI+KAKCzoTHzSTpCXMJ1U/dEqyc87bFBdc+DI k8mWkPxsccdbs4t+hH0NoE3Kal9xtAl56RCtO/KgBLAQ5M8oToJVatxAjO1SnRYVN1EaAwrR xkHdd97qw6nbg9BMcAoa2NMc0/9MeiaQfbgW6b0reIz/haHhXZ6oYSCl15Knkr4t1o3I2Bqr Mw623gdiTzotgtId8VfLB2Vsatj35OqIn5lVbi2ua6I0gkI6S7xJhqeyrfhDNgzTHdQVHB9/ 7jnM0ERXNy1Ket6aDWZWCvM59dTyu37g3VvYzGis8XzrX1oLBU/tTXqo1IFqqIAmvh7lI0Se gCrXz7UanxCwUbQBFjzGn6pooEHJYRLuVGLdBuoApl/I4dLqCZij2AGa4CFzrn9W0cwm3HCO lR43gFyz0dSkMwNUd195FrvfAz7Bjmmi19DnORKnQmlvGe/9xEEfr5zjey1N9+mt3//geDP6 clwKBkq0JggA+RTEAELzkgPYKJ3NutoStUAKZGiLOFMpHY6KpItbbHjF2ZKIU1whaRYkHpB2 uLQXOzZ0d7x60PUdhqG3VmFnzXSztA4vsnDKk7x2xw0pMSTKhMafpxaPQJf494/jGnwBHyi3 h3QGG1RjfhQ/OMTX/HKtAUB2ct3Q8/jBfF0hS5GzT6dYtj0Ci7+8LUsB2VoayhNXMnaBfh+Q pAhaFfRZWTjUFIV4MpDdFDame7PB50s73gF/pfQbjw5Wxtes/0FnqydfId95s+eej+17ldGp lMv1ok7K0H/WJSdr7UwDAHEYU++p4RRTJP6DHWXcByVlpNQ4SSAiivmWiwOt490+Ac7ATQRN WQbPAQgAvIoM384ZRFocFXPCOBir5m2J+96R2tI2XxMgMfyDXGJwFilBNs+fpttJlt2995A8 0JwPj8SFdm6FBcxygmxBBCc7i/BVQuY8aC0Z/w9Vzt3Eo561r6pSHr5JGHe8hwBQUcNPd/9l 2ynP57YTSE9XaGJK8gIuTXWo7pzIkTXfN40Wh5jeCCspj4jNsWiYhljjIbrEj300g8RUT2U0 FcEoiV7AjJWWQ5pi8lZJX6nmB0lc69Jw03V6mblgeZ/1oTZmOepkagwy2zLDXxihf0GowUif GphBDeP8elWBNK+ajl5rmpAMNRoKxpN/xR4NzBg62AjyIvigdywa1RehSTfccQARAQABwsBf BBgBAgAJBQJNWQbPAhsMAAoJEBaat7Gkz/iuteIH+wZuRDqK0ysAh+czshtG6JJlLW6eXJJR Vi7dIPpgFic2LcbkSlvB8E25Pcfz/+tW+04Urg4PxxFiTFdFCZO+prfd4Mge7/OvUcwoSub7 ZIPo8726ZF5/xXzajahoIu9/hZ4iywWPAHRvprXaim5E/vKjcTeBMJIqZtS4u/UK3EpAX59R XVxVpM8zJPbk535ELUr6I5HQXnihQm8l6rt9TNuf8p2WEDxc8bPAZHLjNyw9a/CdeB97m2Tr zR8QplXA5kogS4kLe/7/JmlDMO8Zgm9vKLHSUeesLOrjdZ59EcjldNNBszRZQgEhwaarfz46 BSwxi7g3Mu7u5kUByanqHyA= Organization: Baylibre Message-ID: <25f5ed14-2caf-6b2b-2cd4-3dbf0dd9a03c@baylibre.com> Date: Mon, 20 Apr 2020 12:21:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/04/2020 20:14, Daniel Vetter wrote: > On Fri, Apr 17, 2020 at 6:05 PM Neil Armstrong wrote: >> >> On 17/04/2020 17:07, Daniel Vetter wrote: [...] > > Yup there's a number of parametried modifiers. As long as the stuff > you get from a DRM_FORMAT_MOD_ ... macro is a full modifier with > everything it should be all fine. Would something like that be ok ? #define __fourcc_mod_amlogic_layout_mask 0xf #define __fourcc_mod_amlogic_options_shift 8 #define __fourcc_mod_amlogic_options_mask 0xf #define DRM_FORMAT_MOD_AMLOGIC_FBC(__layout, __options) \ fourcc_mod_code(AMLOGIC, \ ((__layout) & __fourcc_mod_amlogic_layout_mask) | \ ((options) & __fourcc_mod_amlogic_options_mask \ << __fourcc_mod_amlogic_options_shift)) /* Amlogic FBC Layouts */ /* bla */ #define AMLOGIC_FBC_LAYOUT_BASIC (1ULL) /* bla */ #define AMLOGIC_FBC_LAYOUT_SCATTER (2ULL) /* Amlogic FBC Layout Options Bit Mask */ /* bla */ #define AMLOGIC_FBC_OPTION_MEM_SAVING (1ULL << 0) Neil > -Daniel > >> Neil >> >>> -Daniel >>> >>>> + >>>> #if defined(__cplusplus) >>>> } >>>> #endif >>>> -- >>>> 2.22.0 >>>> >>> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > >