Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3468861ybz; Mon, 20 Apr 2020 03:24:58 -0700 (PDT) X-Google-Smtp-Source: APiQypKEawhkfT+Ab9qPJvJZ+Gwl1l9mUTKD1E0dip0gx6IugnrnxnfFQEC3so//jIregF1JlgiD X-Received: by 2002:a05:6402:2025:: with SMTP id ay5mr13324252edb.315.1587378298751; Mon, 20 Apr 2020 03:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587378298; cv=none; d=google.com; s=arc-20160816; b=EuNltD0HMtiRwP0qOFi2E7PMgvpprvslTNW+Jq6VGRX0EC/+kHngk4U0Br3JJnhrna AnNNdtIctYjiAwah9StN+wgfG7ElZUthx8M3RI9Obd/O1NDSJP0VL9TnVa7RRQICCdV2 P8b+CHk7vEHlhZMElQhUE/uRqw5Hq1W6jdnTWmxnq9h0gKxDT6HuLRznHZkIY8iDI3aP aNYuJ5+esqFz83B9EcvXhTD3MW32Prgu4yHpXtJwJiUVyGki//ByzvmtbJLFnBrRx6Xx gM7yO9fhvA/kfHDryIVpOAYM5dP0s3cqoKwRDN7Ufx08yaIyVC0kDIl/miXp1IkSOQBP gb/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=mgfTqPWpI28qJPKQRS6dma5CrISAimpMlANceCOogUg=; b=kfhykglRyBiicZDRio+YnLo1JjMtsjCZKjKNGFcSrjXVU7RmMcG0DK8fbrADv3ckdX HXoy1ig42JNeduYaAvYZuNc68Ee34gmxOdNJFfPhNtFh6gnmlYn5mfj2xeZrKvmLcZ46 cP+uRVUUNE50I6ka6G6Ht/Hpa6SoCexAvsnxm5opd8RNwmF2guYutECzgHbH952zd6AC u1N1O8VnOOb8D+YId9uI2ARqoKEs3Ha9BtKBVkclixP2wpp/eGrhfyqnD++ZndG4PNIR dApXwZJD11ojpGHdbY/8PvVCuPMyouBWyLKHsvSvuuXBv0yfRVSIoTcviHPVxEFvJpfP BMKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TJbYcDGU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a8si288453eds.377.2020.04.20.03.24.36; Mon, 20 Apr 2020 03:24:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TJbYcDGU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbgDTKXM (ORCPT + 99 others); Mon, 20 Apr 2020 06:23:12 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:55973 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725773AbgDTKXM (ORCPT ); Mon, 20 Apr 2020 06:23:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587378189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mgfTqPWpI28qJPKQRS6dma5CrISAimpMlANceCOogUg=; b=TJbYcDGU2QbjjMfS0h7iTGUWbgToq+Fr1MojJsD2aW4iGFYgMA+MWAJ5wfa+DPSgWnR1Se OOnvbXVWb/P01pOauKU3ouOdPK14RolINSY+atNrerD9JfYP8IRllTJSISGhdXrllaq1Ha IHUaquGHU1fNLhwhge8TzKnRoR9VaKU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144--ub4mz19P3K9Jq7Nj2RhOg-1; Mon, 20 Apr 2020 06:23:07 -0400 X-MC-Unique: -ub4mz19P3K9Jq7Nj2RhOg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B329013F8; Mon, 20 Apr 2020 10:23:06 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46F8160C84; Mon, 20 Apr 2020 10:23:00 +0000 (UTC) Subject: Re: [dm-devel] [PATCH 0/3] dm raid/raid1: enable discard support when any devices support discard To: Paul Wise , dm-devel@redhat.com Cc: Mike Snitzer , linux-kernel@vger.kernel.org, Alasdair Kergon References: <20200419073026.197967-1-pabs3@bonedaddy.net> <20200419131908.GA22398@redhat.com> <9cb6a39a43178be29af2f47a92c2e84754b62b69.camel@bonedaddy.net> <6bbf9d94-2fbb-f96f-ea85-a480ba109c55@redhat.com> From: Ondrej Kozina Message-ID: <6e458e2a-f8aa-d6e3-0e6d-7c11ad2a6825@redhat.com> Date: Mon, 20 Apr 2020 12:22:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/20/20 12:13 PM, Paul Wise wrote: > On Mon, 2020-04-20 at 09:35 +0200, Ondrej Kozina wrote: > >> Did you have discard allowed on both dm-crypt devices? dm-crypt >> (kernel) does not allow discards by default. > > I did not, I guess that explains why I got no errors. > FYI if you use LUKS2 metadata format for encrypted drives, you can enable discards by default once and for all by following command: cryptsetup open /dev/sdx sdx_unlocked --allow-discards --persistent Any following unlock will enable discards automatically. Regards O.