Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3538376ybz; Mon, 20 Apr 2020 04:56:28 -0700 (PDT) X-Google-Smtp-Source: APiQypLw2rchN50TEVaRE3MSwwWTdPvlOz4OtBhFj0pZaWJx2xCtOLuah3aGQFsJgrECMfaxVQPr X-Received: by 2002:aa7:c608:: with SMTP id h8mr4920207edq.232.1587383787946; Mon, 20 Apr 2020 04:56:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587383787; cv=none; d=google.com; s=arc-20160816; b=kUKZXcC3sPfJ/ytb2HC7qYB7kLIvhsDwHzaWCMY/YN4DzyXmmN015iGBBui23eDZBN mjmZvL9Sq0FbGnuvshoDGAK0psb7CeM2Ib66utS8fweiVj395b4QXzPBYKAY2qWNQ5em XWdEYyP2ORM1bNIl8d7AV2Rf/z2hNY0T3DsIaJhiFAMQWuKZwr/eLzz3ckXpY6Zg0Xai 7+H9/vyGpzxwg0+fSochEjC504iPxlq6OVEi3QN9/hihi632RIIxDrZqQU1d/Cj3sY8C 2sPX7qNswRsZHXLwKC6CH0W86OPWAV/r44mljIoS4/GTHC60X+U92z90PK8GRwLrtPNb 55Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7makzs2cbr9fUZHSJVgO/RWyhkWdoMidWy5Zb/JpNgk=; b=UwNfliWRXiYdUu42PWNK49Yfz7ZNmKWw1oTz03lPSA+NktjGSqZ43M5Pcz9GbDmoiH a20pWD3/G4HtxBgyzuMtGJeCTJmK0Tl2aOEFQgGdvBN/Ygi81gfid2kd8/RdVtM9QS7D WOYLletggSRPzJtGGuw0pWeIOGUUIECbGTpLFTzPuiN/6IprFoirN4f8ReJoU3T7c/J/ ABQ8QxQyT+BruJpkA3FCEZtx3mj1usXDR6XWZcHkaYaq69FjrCjLOMLdZIWyd5VSSyFk 5CAxTvfQuyIYLQebDD7dZw0CxodviW9+M/G0zONSXxI+v2Pf8NyfUNXn35J8fYwWZq66 C8Ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KmY2u1K5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs23si380334edb.203.2020.04.20.04.56.04; Mon, 20 Apr 2020 04:56:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KmY2u1K5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726476AbgDTLyg (ORCPT + 99 others); Mon, 20 Apr 2020 07:54:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:38294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbgDTLye (ORCPT ); Mon, 20 Apr 2020 07:54:34 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 91A9B22209; Mon, 20 Apr 2020 11:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587383673; bh=y2LqQNgk7M38l+vhlpVjFxZa1rdjNePBdEMgUzSLdhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KmY2u1K51EPLK1W4HkWcxiMu51TD9ZSXYb13zKWfCWjai70Q8Mt9Cvt770iInsbtQ g8AVOWUObccLD/NwmWGV+gIdZkaAz7MecddQ4jlxq6zU+aw17sKhaDzzULzvSH/cZw ZDamnr+dVgOJGTQJ2HEZWdyGij56MK6jUwv5mAeg= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Alexey Budankov , James Morris , Will Deacon , Alexei Starovoitov , Andi Kleen , Igor Lubashev , Jiri Olsa , Peter Zijlstra , Serge Hallyn , Song Liu , Stephane Eranian , intel-gfx@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-man@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 13/60] drivers/perf: Open access for CAP_PERFMON privileged process Date: Mon, 20 Apr 2020 08:52:29 -0300 Message-Id: <20200420115316.18781-14-acme@kernel.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200420115316.18781-1-acme@kernel.org> References: <20200420115316.18781-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexey Budankov Open access to monitoring for CAP_PERFMON privileged process. Providing the access under CAP_PERFMON capability singly, without the rest of CAP_SYS_ADMIN credentials, excludes chances to misuse the credentials and makes operation more secure. CAP_PERFMON implements the principle of least privilege for performance monitoring and observability operations (POSIX IEEE 1003.1e 2.2.2.39 principle of least privilege: A security design principle that states that a process or program be granted only those privileges (e.g., capabilities) necessary to accomplish its legitimate function, and only for the time that such privileges are actually required) For backward compatibility reasons access to the monitoring remains open for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure monitoring is discouraged with respect to CAP_PERFMON capability. Signed-off-by: Alexey Budankov Reviewed-by: James Morris Acked-by: Will Deacon Cc: Alexei Starovoitov Cc: Andi Kleen Cc: Igor Lubashev Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Serge Hallyn Cc: Song Liu Cc: Stephane Eranian Cc: Thomas Gleixner Cc: intel-gfx@lists.freedesktop.org Cc: linux-doc@vger.kernel.org Cc: linux-man@vger.kernel.org Cc: linux-security-module@vger.kernel.org Cc: selinux@vger.kernel.org Link: http://lore.kernel.org/lkml/4ec1d6f7-548c-8d1c-f84a-cebeb9674e4e@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo --- drivers/perf/arm_spe_pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index b72c04852599..0e0961a2b405 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -274,7 +274,7 @@ static u64 arm_spe_event_to_pmscr(struct perf_event *event) if (!attr->exclude_kernel) reg |= BIT(SYS_PMSCR_EL1_E1SPE_SHIFT); - if (IS_ENABLED(CONFIG_PID_IN_CONTEXTIDR) && capable(CAP_SYS_ADMIN)) + if (IS_ENABLED(CONFIG_PID_IN_CONTEXTIDR) && perfmon_capable()) reg |= BIT(SYS_PMSCR_EL1_CX_SHIFT); return reg; @@ -700,7 +700,7 @@ static int arm_spe_pmu_event_init(struct perf_event *event) return -EOPNOTSUPP; reg = arm_spe_event_to_pmscr(event); - if (!capable(CAP_SYS_ADMIN) && + if (!perfmon_capable() && (reg & (BIT(SYS_PMSCR_EL1_PA_SHIFT) | BIT(SYS_PMSCR_EL1_CX_SHIFT) | BIT(SYS_PMSCR_EL1_PCT_SHIFT)))) -- 2.21.1