Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: SgSkmHq4STMJCu3iwrRgHq5Bei4GiQaoRip1SGZC+pV9zQf+KHoEnamLWYWOuImN3oNAOI9fCs
 YTvmtRluJ0xsDgXZ8xJVD5xL3tHHk9oJ8vHGToQFPUM5T34xnkCfoPAw1PvPg8kux9F98SwDNm
 6DIzvZ5SgGw6CZBA8e3t6w8WdGgLgfUv2eHgFH1Hq+Od12/RbO+hZiPYdOr8wYqX8yW8MAuJHU
 iLICSSsa/kz9ftOG6/WgN7B1p5j1tWS3HehzEe9NJUa6lAiAahGtJ9vwKo7DwczABznnJWwV8Y
 pLA=
From:   <Tudor.Ambarus@microchip.com>
To:     <cleger@kalray.eu>
CC:     <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Add support for is25lp01g
Thread-Topic: [PATCH] mtd: spi-nor: Add support for is25lp01g
Thread-Index: AQHWFw0/tWJ4ISRUwk6rGADNBybaDA==
Date:   Mon, 20 Apr 2020 12:14:31 +0000
Message-ID: <1950407.5XCTmqoEVg@192.168.0.120>
References: <20200417160839.25880-1-cleger@kalray.eu>
In-Reply-To: <20200417160839.25880-1-cleger@kalray.eu>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4B2E29904E118641B933F430C110B0ED@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 17ed8a48-1945-48df-3c31-08d7e52461a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2020 12:14:31.4302
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EF89kxBBbgkkheETL+76Tu8QIoOWXfPtXejyVQlUhYLwolEuWhaa1XcvyhnYDy97MTtX5mLcT+npu8g+CQFQ4WRxgb8cFtnqRbylueOjdNg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4136
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Clement,

On Friday, April 17, 2020 7:08:39 PM EEST Clement Leger wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Update the issi_parts table for is25lp01g (128MB) device from ISSI.
> Tested on Kalray K200 board.
>=20
> Signed-off-by: Clement Leger <cleger@kalray.eu>
> ---
>  drivers/mtd/spi-nor/issi.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> index ffcb60e54a80..c3c3438e3d08 100644
> --- a/drivers/mtd/spi-nor/issi.c
> +++ b/drivers/mtd/spi-nor/issi.c
> @@ -49,6 +49,8 @@ static const struct flash_info issi_parts[] =3D {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_R=
EAD
> | SPI_NOR_4B_OPCODES)
>                 .fixups =3D &is25lp256_fixups },
> +       { "is25lp01g",  INFO(0x9d601b, 0, 64 * 1024, 2048,

There is a "K" flavor of this flash which has 512 Byte Page size with 256 K=
B
Block size. While the page size can be determined by parsing SFDP, I think =
we=20
will have some problems with sector_size because as of now, the sector_size=
 is=20
always set to 64KB. An incorrect sector_size will affect erases and locking=
.

Cheers,
ta