Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3577066ybz; Mon, 20 Apr 2020 05:39:25 -0700 (PDT) X-Google-Smtp-Source: APiQypJ48HBsd7byI8mAhDipphP4ek8/HN4WlqdPZ+bfUe6fIdhg0WpPXr6z8x4LLmW4/qKvpgTm X-Received: by 2002:a17:907:20ce:: with SMTP id qq14mr15414684ejb.10.1587386365762; Mon, 20 Apr 2020 05:39:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587386365; cv=none; d=google.com; s=arc-20160816; b=eP/jUrnTtK9CwXcwmnkdo2VdnDrim2khfayl1EW001GMfwIE0WsGYZigoxWbvKzJE7 7V8yC0OTnLL4g7Bq20ZWqUL5RuCrplVyjNbnYCjq8YPYWUixtyWYtLjK3sgznz2yDO/m kLquTbE0ANInb6exksRQZQsOeVgTQ4WK8d8EqGqqhFf93coB2hE5DqvyJ1FWVUYPJxes DScwtDu65BpYr5VbtXTDNmmoYyk6v3ywYrg1NvwGRmhzGWTFUZnZZlAkQjoDqc5c5ZWq FLvxHznxmqNmkRWRAEwacvPWVVrOcUzT0QvlELN0d0kBaVWJegIknpgl7/ufKAf6h254 s5fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=3CbBWYh3hEo1SFuuYgcjEPFrVgBlthpwlzKPfvsK3P8=; b=PU4B6aHfxoK9xWtZ759fLhPvhxis2vjtOtHpuWsQnSTkGkVpMh7fsiigam1VSbioMU IHm0on3uieaPdqwJYDmG3Wn0MRIOSMWrt0hIL9n7tBwM97maT7y8YNTjhVCsMZmdeylV drBCzvKDx2nBITAyzz0c6rdEEgbQgEVm4Ngr+IBGdFQfJrrM6nHLDtF6WcqfTFSK4UKd WOnAyIsSFV6UHBMHPow3xyL/JloM+H29lzYfzuj7txFpgMkYlMkf4Zu5KsSN9JQ1SPEz iDd47COuPABaN/sL0Nf5Uo/s+5tH5CcldrZTHVJxrDFdYcvOT/Hz497vFzD9VTX5x5Vf QwFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OnKx+7tM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si528517edn.229.2020.04.20.05.39.02; Mon, 20 Apr 2020 05:39:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=OnKx+7tM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbgDTMgo (ORCPT + 99 others); Mon, 20 Apr 2020 08:36:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725886AbgDTMgo (ORCPT ); Mon, 20 Apr 2020 08:36:44 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15989C061A0F; Mon, 20 Apr 2020 05:36:44 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id s10so8801057iln.11; Mon, 20 Apr 2020 05:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=3CbBWYh3hEo1SFuuYgcjEPFrVgBlthpwlzKPfvsK3P8=; b=OnKx+7tMLS9s7A35dAv/MXJHdXi9YmU0JJngPdWlBRJbsp72/7AK1nIUIq5NLA1x0b 4AY1rZIBKD++FBAWGobX88d/U2lEQSNH6GwdGormJXygNhWfmr1I0JhLqTUKt04LlGUI vfzUqLuOl04JQNi0CHCZquQHcekDYvpH8SFHIXD+iTuR1cRGzL36UBQ/R+OARcJ7LUW9 R6Ojjm/taf/ATJ0UMHZwcpr+LTnkEsqgPZ+tLMEjNjBfTK++C6DprOuT5+qekXICL8Dq S7z8oqcOsBAtsBN8DRVtLMTNkz+hMBzoaE6dgU4/3Jz+dJ0qxQkMNIJJuwaWKR/KwU52 OGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=3CbBWYh3hEo1SFuuYgcjEPFrVgBlthpwlzKPfvsK3P8=; b=od+OcaXZuf+gOqSZ6PQAVrBRppS481lgIMTjfdH9TkmaMuTGn04wtuqvu4+tSrPDlS 0Tgbb4RA0qNVvS0oudmSRx3dW+caCwLbH+GSjAHK8dM0a4Xuk2Ckg4rXJm1CW8KXbKSI xKMtxpTSagVkHtcXaFP8f814/zdRJutp0HpjCsYPHV4DidrCX+byAy8YHgtTtn4k3UtY 1KuBMFlO2uhyUTMKajE32PKynq4fGmzt1yGuDT3O0ikZqxIvGypbJONMrS3HOLUgpzTX 9H7SFFW/oIehGRFK5nalCzZu6h7wmp4asFUXHsByTprJ2qekGkTkdtyVmIt975tHRimB b+Cw== X-Gm-Message-State: AGi0Pua5zEfYJ4gPOusN5r/FErPjSKEGm0WsKw0EJL8sUujCc0Kdyy2F Lqe87DKqGeuMSVfAj+740QXuk39feGR+hVKfu+I= X-Received: by 2002:a05:6e02:111:: with SMTP id t17mr4674601ilm.59.1587386203290; Mon, 20 Apr 2020 05:36:43 -0700 (PDT) MIME-Version: 1.0 References: <20200419135011.18010-1-peron.clem@gmail.com> <20200420084547.q5xqlbnmug7l45p2@gilmour.lan> <20200420103927.uvzotrolz2inz6q2@core.my.home> In-Reply-To: <20200420103927.uvzotrolz2inz6q2@core.my.home> From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Date: Mon, 20 Apr 2020 14:36:32 +0200 Message-ID: Subject: Re: [PATCH v3 0/7] Add support for Allwinner H6 DVFS To: =?UTF-8?Q?Ond=C5=99ej_Jirman?= , Maxime Ripard , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Chen-Yu Tsai , Rob Herring , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ondrej, Maxime, On Mon, 20 Apr 2020 at 12:39, Ond=C5=99ej Jirman wrote: > > Hi Maxime, > > On Mon, Apr 20, 2020 at 10:45:47AM +0200, Maxime Ripard wrote: > > Hi, > > > > On Sun, Apr 19, 2020 at 03:50:04PM +0200, Cl=C3=A9ment P=C3=A9ron wrote= : > > > Now that required drivers are merged we can contibute on DVFS > > > support for Allwinner H6. > > > > > > This serie is based on Yangtao Li serie[0] and Ond=C5=99ej Jirman wor= k[1]. > > > > > > Most of the OPP tables are taken from original vendor kernel[2]. > > > Plus there are new CPU frequencies at 1.6GHz, 1.7GHz and 1.8GHz. > > > > > > I wrote a simple script to randomly set a frequency during > > > a random time[3]. This script is quite stressfull and set some high > > > frequency without checking temperature. This can result on behavior > > > that whould not occurs with the real cpufreq framework. > > > As Maxime point out I also tested with cpufreq-ljt-stress-test > > > (found here https://github.com/ssvb/cpuburn-arm). > > > This script doesn't trigger any issue. > > > I also test that that offlining CPU0 and doing DVFS on other CPUs > > > works. As CPU regulator is only set for CPU0. > > > > > > The GPU devfreq was drop as the regulator is still not properly > > > drive by panfrost driver[4]. > > > I will re-introduce it later. > > > > > > Ond=C5=99ej Jirman has an Orange Pi 3, Jernej has a PineH64 and a Tan= ix > > > TX6 boards and I have a Beelink GS1 board so I have enable these > > > boards. But CPU Devfreq is really touchy has it depends on: > > > board design, SoC speed_grade and environement which can affect > > > thermal cooling and have different behavior for different user. > > > > > > If people can test this serie and give feedback, I will try to > > > introduce this in LibreElec tree, so LE community can test it. > > > > Applied all of them, thanks! > > Please also apply "[PATCH v2 1/7] arm64: dts: allwinner: h6: Add > clock to CPU cores" from the v2 series, otherwise cpufreq will > not work. > > I can also send a missing patch adding the trip points, and cpu > as a cooling device, that I linked in my other reply to this patch > series afterwards, if Cl=C3=A9ment wants. Indeed I have sent using the following cmd : "git send-email --to=3DXXXX HE= AD~7" from the previous version. I should had do Instead: "git send-email --to=3DXXXX next/master " Sorry for that :( Cl=C3=A9ment > > regards, > o. > > > Maxime > >