Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3589050ybz; Mon, 20 Apr 2020 05:54:31 -0700 (PDT) X-Google-Smtp-Source: APiQypL0YhRT4OTYgf1V4u+WueTTdUfFNa2oP3aY/4thNEGRHhD58pLo9XGZSfkOrp2XO6UZ5M0A X-Received: by 2002:a17:906:361a:: with SMTP id q26mr16444270ejb.292.1587387270958; Mon, 20 Apr 2020 05:54:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587387270; cv=none; d=google.com; s=arc-20160816; b=Gq3AmQDH0WS4Yd99RyCZLZYmv8bmFvctym0DlZTK189iAp0DZlR+Fsc3B8+a7P84IV 7Ij+n53fTn+DbSITaz9kGrtIQJDaklEoKN19hycx+8hZHMjZG517Ox1SOEEdAUxy7u09 oSFG3O+d/dribQoW58hLUtJVn6s8a3Q+HCKuzu1e576Hpzqd/zG3iX2YxTeXhIwquTfy QUDEsQravlaym23wRKCkYVBUcyJhqaLq+tCALuphZd6IPFl4DxN/onQFs6k+bE+MuRg8 YmlvRe89syMc2NzKTLTTasC3YI4zjkG0EBxOX8Nk4C2gEoHnx4Ie3StLyB0iWGvfqZO2 1ZnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SlDEfCyvLo/hZnp6SmIqADLY+twHwkKrmsVfgK1D+9k=; b=Ur6MqJIFOhTVBXNM3x3ofKK+BNUg0n20YIPkIDs1e4MJH5iqRgzu1H89vQRSrsFZtI jla70KMTbyOwex2efEnsxrwMmwb2+9MXOYi0d9+k0DLPO7+pjcwTNr9dvjnEwKIxOLH/ u42UlmEFbpL1lftwJ2ED0BXDVsw5RZ3pg8AOLviH1xwcgKVk5M8+V8VKxl2sY+fw+44w alUr9aGRlGAmZ1uDgKP2v/9afbAMMl1QmTuhJWdGwVObR6swx5dz80O/m1v4A3iGGA3Y GWDuCFHCoBaLW1NZ+mmw3SBmx0+f4LDqD2qnh/HxInleSwIZZxVV3h+SGc2rJN4qQ2VJ 8W5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="idVN/zce"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si436993edj.180.2020.04.20.05.54.08; Mon, 20 Apr 2020 05:54:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="idVN/zce"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729525AbgDTMuU (ORCPT + 99 others); Mon, 20 Apr 2020 08:50:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:46544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729438AbgDTMtc (ORCPT ); Mon, 20 Apr 2020 08:49:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF38420735; Mon, 20 Apr 2020 12:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587386972; bh=Hn0U4pmCNhBknpAyThDaRg6mspD+Ec4E9tYsGdhYWUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=idVN/zce7/byX9ibi3SKnOce5AnJ4hbUNrkMEyYG7cL065CINeCoqsEQWf+SeO+Rk HdaYuqQfMOC3O6Dqis3WU1mbmuYPpI3vhRr9nKEEchkBi2Vq0IIfSoDLB98hTTy6zc sY5hHFQSQYXaDAQazfepM/5KgB1tX0lIVv3Ndu/U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andreas Dilger , Josh Triplett , Theodore Tso Subject: [PATCH 4.19 14/40] ext4: fix incorrect inodes per group in error message Date: Mon, 20 Apr 2020 14:39:24 +0200 Message-Id: <20200420121456.864243972@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200420121444.178150063@linuxfoundation.org> References: <20200420121444.178150063@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josh Triplett commit b9c538da4e52a7b79dfcf4cfa487c46125066dfb upstream. If ext4_fill_super detects an invalid number of inodes per group, the resulting error message printed the number of blocks per group, rather than the number of inodes per group. Fix it to print the correct value. Fixes: cd6bb35bf7f6d ("ext4: use more strict checks for inodes_per_block on mount") Link: https://lore.kernel.org/r/8be03355983a08e5d4eed480944613454d7e2550.1585434649.git.josh@joshtriplett.org Reviewed-by: Andreas Dilger Signed-off-by: Josh Triplett Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4031,7 +4031,7 @@ static int ext4_fill_super(struct super_ if (sbi->s_inodes_per_group < sbi->s_inodes_per_block || sbi->s_inodes_per_group > blocksize * 8) { ext4_msg(sb, KERN_ERR, "invalid inodes per group: %lu\n", - sbi->s_blocks_per_group); + sbi->s_inodes_per_group); goto failed_mount; } sbi->s_itb_per_group = sbi->s_inodes_per_group /