Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND 1/5] MIPS: Loongson64: Remove dead RTC code
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
References: <20200420073347.157230-1-jiaxun.yang@flygoat.com>
 <20200420073347.157230-2-jiaxun.yang@flygoat.com>
 <15923f8b-7278-f510-e06a-99751bd68048@loongson.cn>
 <20200420201312.7afe1bb7@flygoat-x1e>
Cc:     linux-mips@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Huacai Chen <chenhc@lemote.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
From:   maobibo <maobibo@loongson.cn>
Message-ID: <cd4b67eb-d689-793b-93b3-1ba2b3741b5b@loongson.cn>
Date:   Mon, 20 Apr 2020 21:04:52 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20200420201312.7afe1bb7@flygoat-x1e>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 04/20/2020 08:13 PM, Jiaxun Yang wrote:
> Hi Bibi,
> 
> Thanks for your review.
> 
> Pretty sure. It is mc146818 specified, it can never work on LS7A/LS2K
> which have another RTC implementation.
> 
> I have performed boot test with this patch.
> Kernel have safety fallback on platforms without this callback. 
Although it boots ok, the wall time will be 0 for every boot since it does not read from rtc

regards
bibo, mao