Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3653495ybz; Mon, 20 Apr 2020 07:04:36 -0700 (PDT) X-Google-Smtp-Source: APiQypJWsOyWTjCwHk+Jl9VrmBa6Ti55tSiAWOZWYIzWGpmUGEbzneR+T07D2h7mofiJ5pApVzXW X-Received: by 2002:a17:906:2a86:: with SMTP id l6mr16397872eje.273.1587391476045; Mon, 20 Apr 2020 07:04:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587391476; cv=none; d=google.com; s=arc-20160816; b=0VJpFOLEg0xvjSCg2KHMfjDKe3A1ysoJKU+hfWidSHVNLPU1X6hacw0jzs0kJ69TSu qQH94Fm09xYwJojtwntey71ADw6sBOzjEIvaVpQxTN3Z8nqnVv3ZX6LI5quU6ObxZRFM kb8VXHeUzjzIsNqUs5FNldJul7wnJJcYWae02U8sTTnRhwJ8hm1V4jtCAUGJNym+h8oN 5M3g81s2HHP49acui8G+32sdqXWERJgpo/tYJ8VJZBw3AmqDPlbL714gyWGSjsVQk3JL wLurQBWT0aRndqKftXEKdoYhxOznN41evxoKXnQ/NVw0zl/ZAbKl+F7sWtudMHEgdw/p SMJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vl/WYF9LlnlHkC9dcIYj/2J5gopjoNQt/GK249qzOS0=; b=w5V964JDeCvuAn/v9ulbSa9nlpdhFUE35Y3L0Qu0mvfiGSxgf1Wv5Wqn/VL9A0s9LI ohd7DhXPY9ZNad9HWUfhvWA5iWGYEQoPe5XFh7xcbwc35L96ji6P/m/y6zXHOCO+kXkw eJ1GIMhclI+jVx5mLfZxAho2PRqGzqof3cJXJI2w+QKjecPNnBc7MrllWlvHherkRHHs ygNEjSky1S8NT2qnunu+gNqecSRGxf+G0EVMlhrDBSOdI6mszPXgEeanAoP8fepGz1CL kJ42I4IbF+YvnMyM1bYsOR1+D80wC9ysfBbVGOnhhMbvxdOgoTnA4CM8M+YJkTnNDdTv YkTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OdT6OaiS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 3si661593ejz.2.2020.04.20.07.03.59; Mon, 20 Apr 2020 07:04:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OdT6OaiS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727768AbgDTMms (ORCPT + 99 others); Mon, 20 Apr 2020 08:42:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:35900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727027AbgDTMmn (ORCPT ); Mon, 20 Apr 2020 08:42:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D03EC20724; Mon, 20 Apr 2020 12:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587386563; bh=bCDq43JudMUVyE16zfPz7jVRgValKuqje5YUNUC1vdY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OdT6OaiSPipye3qWDUemA13IZXpQCUMgGF0W4qLojbu17Cb1L6i2qlN6wv9n3WbNQ 1Fs/FfiGG2bTWLbUUAPOOd0sZ5eN9eSgTveX5BIIuXxyj6mpCmIstjpvbPMEKObCCV ojMyfoAFKUDqSlPtMGzMMRAGBdbawyelU+khux/4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thinh Nguyen , Felipe Balbi Subject: [PATCH 5.5 37/65] usb: dwc3: gadget: Dont clear flags before transfer ended Date: Mon, 20 Apr 2020 14:38:41 +0200 Message-Id: <20200420121514.336991863@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200420121505.909671922@linuxfoundation.org> References: <20200420121505.909671922@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thinh Nguyen commit a114c4ca64bd522aec1790c7e5c60c882f699d8f upstream. We track END_TRANSFER command completion. Don't clear transfer started/ended flag prematurely. Otherwise, we'd run into the problem with restarting transfer before END_TRANSFER command finishes. Fixes: 6d8a019614f3 ("usb: dwc3: gadget: check for Missed Isoc from event status") Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2567,10 +2567,8 @@ static void dwc3_gadget_endpoint_transfe dwc3_gadget_ep_cleanup_completed_requests(dep, event, status); - if (stop) { + if (stop) dwc3_stop_active_transfer(dep, true, true); - dep->flags = DWC3_EP_ENABLED; - } /* * WORKAROUND: This is the 2nd half of U1/U2 -> U0 workaround.