Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3676508ybz; Mon, 20 Apr 2020 07:29:20 -0700 (PDT) X-Google-Smtp-Source: APiQypJOYOut9fABXJ0v/FhY3z0Q92VXU5sxBY7hMRafcvOEN3Ih3//BXqb8Z7YggVZ7j2cmYHmW X-Received: by 2002:aa7:d28a:: with SMTP id w10mr2892377edq.206.1587392960521; Mon, 20 Apr 2020 07:29:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587392960; cv=none; d=google.com; s=arc-20160816; b=NrBDtRUcvMg7IL5yoHcgDBT1O90nsDSYMvWVTVacl/bqKCqVp9rYWVkZPi39fBBbsu gVJiDhP5EdKn6cn4rGq9Sw9/yPTedBYg3Cjhwv9rnkh6J7DXClrTHcsfzbfkzOj5OOqN 4DyddjGr0JIXfmuL3VwFdxiHk9E4EykKmtz5NR9ooblGQct45qZCHaMvfb9r+WhWJ8rF kwTdwTk+iRtAzWwwfQSAdwhklqziUqghRAFZBVfdG/wUvNTRHEI1QcbaWUynF6sx4ka3 ddWiucma3LkC1uQfK898AwQuzyl6R5+NWrRo+a6KfgmlSDqOxvyLgO1Uy6MLpAXzEsoY wC+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vl/WYF9LlnlHkC9dcIYj/2J5gopjoNQt/GK249qzOS0=; b=OABaTXfIvOn/goGgY2GXfXBPpei0D7Kza4ZDpLdP5g/OcS2/5ssDrvw/9271E8SUXY 9g6gNZlTiW0mjR6eWNvz9tpfOkAu5r9j+aJztC7pLCATquFfpXYvh4gDshPxqMtji8Ls Ep2bu2xlXdWMr0YHeAlRUOz2VlYylEK+0+Zu62l/vbIQ964Qk2gfNgjE1mLYxsZ+a/kA nOCn1nGne2K3qxdFmL+gW78Ep4WXffabR1VUmbZlnHWm3yOpCBY7k23sH+YHoQNqkG+B j9q9ZMDy97Py/RogPxy2/4IvRPtJXsS9hrYcs9/aXyC928ZJMRL6XlV1tkDEe3TIYeJX dWEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WJS66V0v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x21si650320ejc.141.2020.04.20.07.28.57; Mon, 20 Apr 2020 07:29:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WJS66V0v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729518AbgDTMxQ (ORCPT + 99 others); Mon, 20 Apr 2020 08:53:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:42418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728207AbgDTMqr (ORCPT ); Mon, 20 Apr 2020 08:46:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A639206DD; Mon, 20 Apr 2020 12:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587386807; bh=bCDq43JudMUVyE16zfPz7jVRgValKuqje5YUNUC1vdY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WJS66V0vzphSMuy+gEKC/I60WjwNaOOsusuLhaneAaOY9sdR5PZKms4J5lLZTMMo8 bPBu14eLwIPasr6dgupUNal1KT+aKTi0NEMEPmAahmmOk5ZP5g0ARQGKq9A3+w1b9Z vbrsf+jUZ3KlJDV6alS0Q29TEDfmGhOBqQPlKJos= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thinh Nguyen , Felipe Balbi Subject: [PATCH 5.4 33/60] usb: dwc3: gadget: Dont clear flags before transfer ended Date: Mon, 20 Apr 2020 14:39:11 +0200 Message-Id: <20200420121510.387048885@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200420121500.490651540@linuxfoundation.org> References: <20200420121500.490651540@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thinh Nguyen commit a114c4ca64bd522aec1790c7e5c60c882f699d8f upstream. We track END_TRANSFER command completion. Don't clear transfer started/ended flag prematurely. Otherwise, we'd run into the problem with restarting transfer before END_TRANSFER command finishes. Fixes: 6d8a019614f3 ("usb: dwc3: gadget: check for Missed Isoc from event status") Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2567,10 +2567,8 @@ static void dwc3_gadget_endpoint_transfe dwc3_gadget_ep_cleanup_completed_requests(dep, event, status); - if (stop) { + if (stop) dwc3_stop_active_transfer(dep, true, true); - dep->flags = DWC3_EP_ENABLED; - } /* * WORKAROUND: This is the 2nd half of U1/U2 -> U0 workaround.