Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3695136ybz; Mon, 20 Apr 2020 07:49:42 -0700 (PDT) X-Google-Smtp-Source: APiQypLxO5juVPDP47hAz2t/VXrgSZY6VOoG1m/pGcGOna8cJjRS8m1OFAljgd0rjbeLy7pGFLcC X-Received: by 2002:a50:b003:: with SMTP id i3mr14609142edd.303.1587394182415; Mon, 20 Apr 2020 07:49:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587394182; cv=none; d=google.com; s=arc-20160816; b=e/6fdF9yi011/okM5OLoEuBwM9ptC2/xiZX6MRP+F5y2A4ZN0NNNcY35EAZQXbQgJj F5/dL0fnsAakYr/0GmhBvbm9DL/sYnhZB37dRY3H+AGNh/oykLOHIsnqUf7maLA0E4U0 UINgjNlvRiquY4u5rzSrSs+5Dlwhj/IgJd97eGsdw1WRODRlD6YN1giG5H7FBlNkYAgQ FvrHJIQwCzEe/5EWE+a6txEO3T7Knws69sL8B59f00kbmrNUqoKcXodHr4G1LKE3vJNg Mcusvm8bk/6bfeDKfHjwktYC4sbiinoRpyWR6JGeaXOAavZ488bnPfyCfDJWfguAUvAN rR3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=mCC0RZjH0tWjVWaI2hJm1rpTGc87Cf6IUivho7FqF9Y=; b=NiLZaT0kczon+iX418rmFR3xZGzSf956yx2ZIrUHL0w8UPZDfG4+Ww/PGkPoKB75au WI4v3wU6x1fC9Nl6tTpxbjdCjQrb6IHSjMrguInmZLsvI1tzPc6ctBe9X3HP/MW+ByKk 6obMep+ER2ylgXAFaTChKuuHFvBwkWmGlbGV+0SEqHzpE+9x4bdmZZKhAVP0wDOfLZJq iKc74brNpz0i4xYYBpKAiI1P4toe1UgwrMccwyaBiVIMzgofzFOXBpit3OwV69OFXWAJ /3FEzQcC/zErp0j9hxSf1yrMvjpAZzDhoXSXd7zOMK5FLaCBL3eNt719koZXP9FIlOQ4 a9iQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si676683ejk.0.2020.04.20.07.49.18; Mon, 20 Apr 2020 07:49:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728278AbgDTNhT (ORCPT + 99 others); Mon, 20 Apr 2020 09:37:19 -0400 Received: from mga04.intel.com ([192.55.52.120]:42846 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbgDTNhR (ORCPT ); Mon, 20 Apr 2020 09:37:17 -0400 IronPort-SDR: 33bRO4NTGozpJYbMy+zieYJRsfB6IiZZffd8ZakZRR+xALttUCcF7361iJmKLxefsdxJNxpWY/ CqsYHXdmYKKQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 06:37:17 -0700 IronPort-SDR: vt2Cpxgf/VyAygW430U5YyGa47SK2s/6vIwyWW+Y1T1iX68HonZOtbt8Uu23Tuc4lXlPEJ83q8 lTYVzBCgebyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,406,1580803200"; d="scan'208";a="279241230" Received: from avandeve-mobl.amr.corp.intel.com (HELO [10.135.0.43]) ([10.135.0.43]) by fmsmga004.fm.intel.com with ESMTP; 20 Apr 2020 06:37:16 -0700 Subject: Re: [PATCH 9/9] module: Reorder functions To: Ard Biesheuvel , Kristen Carlson Accardi Cc: Kees Cook , Thomas Gleixner , Ingo Molnar , Borislav Petkov , hpa@zytor.com, Jessica Yu , X86 ML , Linux Kernel Mailing List , kernel-hardening@lists.openwall.com, rick.p.edgecomb@intel.com References: <20200415210452.27436-1-kristen@linux.intel.com> <20200415210452.27436-10-kristen@linux.intel.com> From: Arjan van de Ven Message-ID: Date: Mon, 20 Apr 2020 06:37:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/20/2020 5:01 AM, Ard Biesheuvel wrote: > Is that the only prerequisite? I.e., is it sufficient for another > architecture to add -ffunction-sections to the module CFLAGS to get > this functionality? (assuming it defines CONFIG_FG_KASLR=y) I suspect you also need/want at least normal KASLR enabled as a "does it even make sense" common sense threshold