Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3708628ybz; Mon, 20 Apr 2020 08:04:16 -0700 (PDT) X-Google-Smtp-Source: APiQypKdrCMbhuCNeXJyU9uXn8DIGx2IyvSYuMi02A7xPxI73czDnSCImzTgJvRmpX0KvJlRz+Zs X-Received: by 2002:a17:906:4e8a:: with SMTP id v10mr15975277eju.63.1587395055807; Mon, 20 Apr 2020 08:04:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587395055; cv=none; d=google.com; s=arc-20160816; b=lsLVz5RKJD8P8c9p3gePX1K2f+TlBCjxU+AI3YqNdCUOAykfL+fV4WT306Ix+fSkp+ vAcQkflbQnBT7bGDBHLJgqjlrCqSFowfJ4A7HPp5EjNstRFdT680J7UjUsV3yaHwWYRo FlztG4w9GdYWPP23SAGSIV9+vr4dT/mPuCvyz6b1UyonnpqMx693u7CQycffUb3ayTJn v5Pd8njkv/3K2j86I19A0L4ibh4AUjWsfSL/T6IKd5owjazlLV36vkNWkkWqdx6FBFNH M7lK9lpOh4xEivwdF0SIN1hM3X2ig5vh3RTSqsxbD9zhIMjS6t2oC13HGZLdQ2kcSDVg 9ghA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=yCy3dPHbVYsNeWrCXuKatN12x59489+ViDDlx4K6qxY=; b=nG330+S6NMf+WBMjrdab6nSzVonJhEXfWcmZVGbhSWQgU+ZhtE6HZqYpZWw7oUIuGH T9PNk4YLZyZ6vABjmao5o5pkd6fgi6d/ffnQSJo2N0OnhBVbbF3YI1p+/hQyiOKqf4ak Czjil5I84btJBWQqibRNHN8NLMY/bLiyfA7UGpdq097+5dyKc5XEsIMbbu8oYa3UcEy0 6gIqrRw3FB62V8vIrZu2WRGnWUfu/26Bc7LIHcwJ0fyQJxmyM0q2SktJ0rU+4nstCi+J cxH48VwEpAbEbqti34nmlT3KgP5ZI3/0dsHuOcBHGlKZzNe+KcMKTGsz38bmG07RDr9+ Zcgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si668109ejk.464.2020.04.20.08.03.40; Mon, 20 Apr 2020 08:04:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728937AbgDTNwR (ORCPT + 99 others); Mon, 20 Apr 2020 09:52:17 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:4378 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728018AbgDTNwQ (ORCPT ); Mon, 20 Apr 2020 09:52:16 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.17]) by rmmx-syy-dmz-app02-12002 (RichMail) with SMTP id 2ee25e9da8f9a32-d6d3e; Mon, 20 Apr 2020 21:51:54 +0800 (CST) X-RM-TRANSID: 2ee25e9da8f9a32-d6d3e X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.1.173.179]) by rmsmtp-syy-appsvr09-12009 (RichMail) with SMTP id 2ee95e9da8f73fc-c6f20; Mon, 20 Apr 2020 21:51:54 +0800 (CST) X-RM-TRANSID: 2ee95e9da8f73fc-c6f20 From: Tang Bin To: axboe@kernel.dk, b.zolnierkie@samsung.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] ata: omit superfluous error message Date: Mon, 20 Apr 2020 21:53:42 +0800 Message-Id: <20200420135342.11984-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the probe function, when get irq failed, the function platform_get_irq() logs an error message, so remove redundant message here. Signed-off-by: Tang Bin --- drivers/ata/pata_rb532_cf.c | 4 +--- drivers/ata/sata_highbank.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c index 479c4b29b..dcde84f57 100644 --- a/drivers/ata/pata_rb532_cf.c +++ b/drivers/ata/pata_rb532_cf.c @@ -115,10 +115,8 @@ static int rb532_pata_driver_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(&pdev->dev, "no IRQ resource found\n"); + if (irq <= 0) return -ENOENT; - } gpiod = devm_gpiod_get(&pdev->dev, NULL, GPIOD_IN); if (IS_ERR(gpiod)) { diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c index ad3893c62..efd1925a9 100644 --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c @@ -469,10 +469,8 @@ static int ahci_highbank_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(dev, "no irq\n"); + if (irq <= 0) return -EINVAL; - } hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL); if (!hpriv) { -- 2.20.1.windows.1