Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3719008ybz; Mon, 20 Apr 2020 08:13:53 -0700 (PDT) X-Google-Smtp-Source: APiQypJPRCSfhSjD+JTeEX05OX5FduOsyMHW0/C8cLXr/QKlwDeIVSdDnnRCLJjTCV/ZYVPlIOcK X-Received: by 2002:a17:906:9494:: with SMTP id t20mr15947239ejx.51.1587395633646; Mon, 20 Apr 2020 08:13:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587395633; cv=none; d=google.com; s=arc-20160816; b=BHy7gnGdGWjd+E3oltAxF+0MQnMc3PpV4oSi+GHLgCq69pBgfFC/D/YapZYMzUVqO4 jUs3Q+I4LMPLFtStOXsRYlWTynWgRDvnGAWidKIjQ2ffwGrqLlFmwaQA8xVNa3jOPfT5 X3JIdz9HwiVe7bClPwGmAVwPQzhlNVNx7m9T//dhXTeLUlKTtMJASvkyiLcR+EDVazLx 4xWiwdf/c6VXUYjeWcTLA2eAzQCR1mUqm/P9Spn++droWM5CXhK42zBtneVUVlZ/5sEN fnXN/Ebv7NgC0+egEOgwC2vx+3Z3ir6i25JTttWtJhnUYuX8/3lXw5z1ZeRRJNTpOZGU /7sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dAKkhwUoPa4OzOuqOjCtfNVWPgzKG/RSgUn7HPwT4aw=; b=I1jRVocqidY6Zd6vS3FhDEo/58KRiGCEMytZmsIlSPIi0Pp3Ovv7VfGN/ymaX4SWS0 t7VMaX1fB97Fgen2XeI0PnWrPkjNrjeB1DR+CG/c6bT9ZACqcoEzI54LnQXc68Qe3gg+ DOnDDhQ16KVeg4lFfuEBwh71v3fgygvpT8uN2Xi8A12luIz9oa36KdjGNv9UUQ1jQhND kfsEvRxuFFfTREc9SK1VkVw82fg+LQvKZlnjZL55Rxi3WZFY/54NBPuViWqM4U2421ha 4p7+x3Cxbp/JQbcgJ6A2jGcfY/UBDMobUMo0HIgxRsQgU1zLNE8E40yzxxaPkPjjQpkg 4Jtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 62si666687edc.448.2020.04.20.08.13.29; Mon, 20 Apr 2020 08:13:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729398AbgDTOXo (ORCPT + 99 others); Mon, 20 Apr 2020 10:23:44 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:3509 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728948AbgDTOXo (ORCPT ); Mon, 20 Apr 2020 10:23:44 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee15e9db059e8a-d6ef1; Mon, 20 Apr 2020 22:23:21 +0800 (CST) X-RM-TRANSID: 2ee15e9db059e8a-d6ef1 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[112.1.173.179]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee25e9db056663-c7edf; Mon, 20 Apr 2020 22:23:21 +0800 (CST) X-RM-TRANSID: 2ee25e9db056663-c7edf From: Tang Bin To: broonie@kernel.org, perex@perex.cz, tiwai@suse.com, shawnguo@kernel.org, s.hauer@pengutronix.de, lgirdwood@gmail.com Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin , Shengju Zhang Subject: [PATCH] ASoC: mxs-saif: Avoid unnecessary check Date: Mon, 20 Apr 2020 22:25:09 +0800 Message-Id: <20200420142509.9728-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function mxs_saif_probe() is only called with an openfirmware platform device. Therefore there is no need to check that it has an openfirmware node. Signed-off-by: Shengju Zhang Signed-off-by: Tang Bin --- sound/soc/mxs/mxs-saif.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c index 1e38ce858..64c095b91 100644 --- a/sound/soc/mxs/mxs-saif.c +++ b/sound/soc/mxs/mxs-saif.c @@ -736,9 +736,6 @@ static int mxs_saif_probe(struct platform_device *pdev) int irq, ret = 0; struct device_node *master; - if (!np) - return -EINVAL; - saif = devm_kzalloc(&pdev->dev, sizeof(*saif), GFP_KERNEL); if (!saif) return -ENOMEM; -- 2.20.1.windows.1