Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200419192339.32023-1-kdasu.kdev@gmail.com> <20200419192339.32023-4-kdasu.kdev@gmail.com>
 <63176468-53b6-c11a-9e33-2ca9dd06f7a3@gmail.com>
In-Reply-To: <63176468-53b6-c11a-9e33-2ca9dd06f7a3@gmail.com>
From:   Kamal Dasu <kdasu.kdev@gmail.com>
Date:   Mon, 20 Apr 2020 11:12:21 -0400
Message-ID: <CAC=U0a1mOWo3ucMJ7x5wuWQ44NRA2+Dj6fKAi1dbevNaxcYJzA@mail.gmail.com>
Subject: Re: [Patch v2 3/9] spi: bcm-qspi: Handle lack of MSPI_REV offset
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        Mark Brown <broonie@kernel.org>,
        linux-spi <linux-spi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Yes missed this one.
Should I send a v3 of the entire set.

Kamal

On Sun, Apr 19, 2020 at 3:44 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Hi Kamal,
>
> On 4/19/2020 12:23 PM, Kamal Dasu wrote:
> > Older MIPS chips have a QSPI/MSPI controller that does not have the
> > MSPI_REV offset, reading from that offset will cause a bus error. Match
> > their compatible string and do not perform a read from that register in
> > that case.
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
>
> This patch should also have a From: that is from me.
> --
> Florian