Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3794759ybz; Mon, 20 Apr 2020 09:34:18 -0700 (PDT) X-Google-Smtp-Source: APiQypLXl19xzksN6TvZNC2ZTG+qSPFC/QAoN0PQebTAnSPSk+v4m66KoiDSoVUNF+hrfhgBHf9H X-Received: by 2002:a50:eac7:: with SMTP id u7mr14805254edp.190.1587400458681; Mon, 20 Apr 2020 09:34:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587400458; cv=none; d=google.com; s=arc-20160816; b=N3HvJQ80OMFkzj+TZYyaBf2GjUquVGlRb1sbuUAuMafru/ziXArxvQdT0zIZDUFBQF RV89wbQVidz7q1u+UvINMzF9k4Wnh101CPvBo7lHNLOgx3hImL8jnDNq6GN4zTp7AHQk cZ6DyCkJnb1ZxEF06KqwkYeLWh9rbkcJc7XX0JI6Gsw07fpJm+MRI6oju9M494I0wzuo wPyXI3AiBu4Y7yJVHUYrOI9zCiB9Epr+elfGFXmEED3fnk7wjJp3sDbH8+RIoHeQCDRB 7sQRVDgQrsxVkohOslQ8zZ5c0OBTQ0z8QbLSMtZe8TTMcBUqjBXjHVMDDbCjxCDVl7sj XHWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2jcKknn8YIgEszp4LpI9jQaXIWucmW6e5MhcoXIdtq8=; b=sNHLol6FyEsEmiuyvUbOROhpRvwUMu5pCV0AL1LpydaLNIuV0OrNxnmxk8d3E61AS4 FDoSX8g8jyzGRXU78ZcPCG0HWIf5WeDpNRa+IIY9/roUQtzOWX9lpXSbDr4jkVGq5WYA 3AXYHvRBjN3Ar1X9QqmclI7uRA4bNl6CyOsnIfaYUNRlaDc733IikWcMVPrpcs+cOkLD a/3HqyDSauh6w/YgWHRIdXK790FemWADq7WFJEYxbvM7Zhtek8yDaS1Xj+4S/vXaxvl8 +kqEuSGSWa6zyLklJjfj+XYwAuyT7grYOtHvMsakSZFsdks859AMmltwa0Y3toPaBZBc qRiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xOZSa0T3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si813531ejz.377.2020.04.20.09.33.55; Mon, 20 Apr 2020 09:34:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xOZSa0T3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729519AbgDTMuM (ORCPT + 99 others); Mon, 20 Apr 2020 08:50:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:46726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729453AbgDTMth (ORCPT ); Mon, 20 Apr 2020 08:49:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A614720735; Mon, 20 Apr 2020 12:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587386977; bh=fhMCzs+5oAeNDilCXNjN57Y84x/pplV7/I0kKxgTNjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xOZSa0T3YmSy5xosrJL/HiCYa4N6Bm7pwm8fgu9rwcb1yLt6ehfuqLA3NBVT0bsVf 7xo0ypnjarUwlmZDLyUJi/G2EyXPejPDDBUPf+CkiAOUjk6ON7x++qVR7ZTiNT8tj9 TTsY14fkXVihcm7R/MjgzJ37TPtZ5OWioupD+eV0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Cezary Rojewski , Pierre-Louis Bossart , Mark Brown Subject: [PATCH 4.19 16/40] ASoC: Intel: mrfld: return error codes when an error occurs Date: Mon, 20 Apr 2020 14:39:26 +0200 Message-Id: <20200420121458.268430959@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200420121444.178150063@linuxfoundation.org> References: <20200420121444.178150063@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King commit 3025571edd9df653e1ad649f0638368a39d1bbb5 upstream. Currently function sst_platform_get_resources always returns zero and error return codes set by the function are never returned. Fix this by returning the error return code in variable ret rather than the hard coded zero. Addresses-Coverity: ("Unused value") Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part") Signed-off-by: Colin Ian King Acked-by: Cezary Rojewski Acked-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20200208220720.36657-1-colin.king@canonical.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/intel/atom/sst/sst_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/intel/atom/sst/sst_pci.c +++ b/sound/soc/intel/atom/sst/sst_pci.c @@ -107,7 +107,7 @@ static int sst_platform_get_resources(st dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram); do_release_regions: pci_release_regions(pci); - return 0; + return ret; } /*