Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3796242ybz; Mon, 20 Apr 2020 09:35:55 -0700 (PDT) X-Google-Smtp-Source: APiQypLf6grXnZok1JzxojFunS063yMsPGJFUcWXn55kltiXcLgyfXCiRo47LcknP/uMFOCnvBv/ X-Received: by 2002:aa7:d344:: with SMTP id m4mr15338669edr.297.1587400555187; Mon, 20 Apr 2020 09:35:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587400555; cv=none; d=google.com; s=arc-20160816; b=wyn3SSxbZh6ybwTdOIBp81LcztdIvFKTQxPZ7/Iy7NOgYN5DCVp2AhVKV67y+WZd70 miB2i0Ab9rCWO8/KyPtSJPrgyVx0soPfgw7u/Ff1bwE1cpO/v0xNMVarONmmXbiCjss0 GmfI+4q931ww1KDOq3wLG8iDYBOGQjOUWi8ByYL4awwTzRwBvCQaTlFF+WEbkUi88mEk DmoX5p5I8gBw324imQPRMH3q/eD0SBpiXXIHxedl5ufD92EWI5GkqAQR5vlbzIqHTlDC WbBl1grtmJF5H1gUK+Zm37SzVoNAGM9dlqwEoO2UUNrd529vNOytvV9fmaj4f8521Zw/ Zw+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A/n5bb4eaj6JwKWKXfp7F+17buH4yQiRnlG3PDSwO9k=; b=bssHA6x43PNNTOc6boz6oXR+8Ymf1jA5OLHvFFoEnO8N8ULKRikfUmFoZsxZOEO3C6 oM2lJsoHKSuCA8F9RQ85tOMHnOK9TIaRN1HjvEt8/q0IW9kEJXuY5r7NNylpvPUyqxF3 l+87A/+9U/SLXWUSL0NSWUt2eckE+SIgaVFx+ue2sDVONsZY9+gsYGZtSYNJ/0BBhiAr 1ceXThQbQNsZMO4eErlgpsHHumByflGk9V1mRJ+pM9exfjQkI6/dUdEgo/FR2AReY5EN 7Fl+G93LeAEalKQGjw8++TPfLK8D45GQLmFdYYCxUhJrKvcdv8kLaMmWU8FXh0RelVnL Y2KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zfK0hiF6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d24si810674edq.199.2020.04.20.09.35.31; Mon, 20 Apr 2020 09:35:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zfK0hiF6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729553AbgDTMyL (ORCPT + 99 others); Mon, 20 Apr 2020 08:54:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:42040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728944AbgDTMqc (ORCPT ); Mon, 20 Apr 2020 08:46:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E75DB2078E; Mon, 20 Apr 2020 12:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587386792; bh=dy4xTZ5FaeiZ7KLejdiSar2ZviNd30StLjwUMjAv1dA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zfK0hiF6hEcsg64Z6QH4C/a9dFBf0OLntPS6PqgxNvUpAMY15feSrJQISwLY0qolh ZVPOzWimsl1ty+HBPQeXUcvqaEZWmr7G7nC3nSCRvqsRfskYuKDatQSDztDS0BSlxY lsjewS5fVRkuZghOLJ1+uREfDVSw09r+r7zwcKRM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andreas Dilger , Josh Triplett , Theodore Tso Subject: [PATCH 5.4 28/60] ext4: fix incorrect inodes per group in error message Date: Mon, 20 Apr 2020 14:39:06 +0200 Message-Id: <20200420121509.113179131@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200420121500.490651540@linuxfoundation.org> References: <20200420121500.490651540@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josh Triplett commit b9c538da4e52a7b79dfcf4cfa487c46125066dfb upstream. If ext4_fill_super detects an invalid number of inodes per group, the resulting error message printed the number of blocks per group, rather than the number of inodes per group. Fix it to print the correct value. Fixes: cd6bb35bf7f6d ("ext4: use more strict checks for inodes_per_block on mount") Link: https://lore.kernel.org/r/8be03355983a08e5d4eed480944613454d7e2550.1585434649.git.josh@joshtriplett.org Reviewed-by: Andreas Dilger Signed-off-by: Josh Triplett Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4109,7 +4109,7 @@ static int ext4_fill_super(struct super_ if (sbi->s_inodes_per_group < sbi->s_inodes_per_block || sbi->s_inodes_per_group > blocksize * 8) { ext4_msg(sb, KERN_ERR, "invalid inodes per group: %lu\n", - sbi->s_blocks_per_group); + sbi->s_inodes_per_group); goto failed_mount; } sbi->s_itb_per_group = sbi->s_inodes_per_group /