Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3797503ybz; Mon, 20 Apr 2020 09:37:13 -0700 (PDT) X-Google-Smtp-Source: APiQypK7KE5Nq/AYeUGDqxPhVW1lpMcRR6UuE4opG+0JzqD+2X+F+MczmvpEQIC4CCPJveaquFb+ X-Received: by 2002:a05:6402:3129:: with SMTP id dd9mr2000013edb.121.1587400633485; Mon, 20 Apr 2020 09:37:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587400633; cv=none; d=google.com; s=arc-20160816; b=b7rCw2OtuZFSTp0q5+Z4I+3ZtHoFx3x2zzG4Bo6IrVOx4k5jF4v5hkSh+CQ+F1i6lx oBZuyPFpxkhyMIoJ1o1pjBq5xENZqLODOnYf+3jM63FbDkYmylOVF9giM3JVy5G1ucXH S91q1kDt00OdtcUvBVOMG1GZHyYHqxMPTsRPn5ihow6nmGF5VIcMKBCcODzxzoPUbhQA MgBoVAWWpPX7B2RIPoUi9kBO8gZf2r+5s5T3s04LhWf1dRAFNMQyNLgZHNc6pqt0I+Q2 DTq7axCBtcVYjWXPrJp5p+THEgFxDK3UG9YOdS8z2h0/cYz46OmIMQrp++zszy5I+3rp 6DoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FBwOQTtBXaayFGPmxPZe67lJZ71RjO3Y1bpke6Vbe6o=; b=hV8MugRoAN05ZR799b4TYeK3eaUkDTYKJ970sC3RNcx57kG81M+HumMCKjilXnxvHG kRu6tmmrS833Nt2ODcRRDLF1vOIL6nW9yU8f5EQ45HEfZET21Tayvt3I2rdCvGo0+Y8q nRJkdTrSHGt3X2Aq5ct2ZAsdQrYk0CkWXIykjMpvACwlO7pk13I9W6+jllReM3FqdT8h /gose3aaOUwO8GCOQ9ev4QdRmsdZV37cUMHgxtwNBJO9nGTMDJ4zNpEicGWg+R+IX4/O v265YW+2PIAvUTz3oq9Wepjod5QkgQbMO9nrspKWnfyEKkhH4t3hteNTKZoIOxnasUQH QhQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=QTe+K0BO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dv25si871091ejb.270.2020.04.20.09.36.48; Mon, 20 Apr 2020 09:37:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=QTe+K0BO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727965AbgDTNYN (ORCPT + 99 others); Mon, 20 Apr 2020 09:24:13 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:28730 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbgDTNYN (ORCPT ); Mon, 20 Apr 2020 09:24:13 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03KDL6Rd019755; Mon, 20 Apr 2020 08:23:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=FBwOQTtBXaayFGPmxPZe67lJZ71RjO3Y1bpke6Vbe6o=; b=QTe+K0BOFgLB0knqTrCLFt2e6EWywViPdie95h4HRK98cmwrAi+dWkwtRkADyis9qNiy xkojtQJ/wgqv4gflMwkCI6Iav8c8Zqk5ARoHz8XJtLMjZLXlo9gARSGKIz6hIyUH+hJv DOtd+VYpbObRUb0Ty5/Qt7R+Mj9/8Abu6LggFuLh7sMMra4uPrEfbfIeUIokSMK7O0zO 1LKnPkXzp7FDeXYaQcUTvfWcY5fIYdKL5cw5CU2ywkGX/ePAe+zuh2rkYM5CIergVV0E dT5v5sX7a1x7yfjIcr9Rr1FyAP0BF9rJ6L/ooQI/pvmBqjAU4sSWx2lwA60097RQvhCE TA== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 30fwyqk3s4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 20 Apr 2020 08:23:22 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Mon, 20 Apr 2020 14:23:20 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1591.10 via Frontend Transport; Mon, 20 Apr 2020 14:23:20 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 7FFF42AB; Mon, 20 Apr 2020 13:23:20 +0000 (UTC) Date: Mon, 20 Apr 2020 13:23:20 +0000 From: Charles Keepax To: YueHaibing CC: , , , , , , Subject: Re: [PATCH] ASoC: wm89xx: Add missing dependency Message-ID: <20200420132320.GC44490@ediswmail.ad.cirrus.com> References: <20200418090853.30340-1-yuehaibing@huawei.com> <20200420125343.20920-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200420125343.20920-1-yuehaibing@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com ip4:5.172.152.52 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 priorityscore=1501 mlxlogscore=788 clxscore=1015 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004200115 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2020 at 08:53:43PM +0800, YueHaibing wrote: > sound/soc/codecs/wm8900.o: In function `wm8900_i2c_probe': > wm8900.c:(.text+0xa36): undefined reference to `__devm_regmap_init_i2c' > sound/soc/codecs/wm8900.o: In function `wm8900_modinit': > wm8900.c:(.init.text+0xb): undefined reference to `i2c_register_driver' > sound/soc/codecs/wm8900.o: In function `wm8900_exit': > wm8900.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' > sound/soc/codecs/wm8988.o: In function `wm8988_i2c_probe': > wm8988.c:(.text+0x857): undefined reference to `__devm_regmap_init_i2c' > sound/soc/codecs/wm8988.o: In function `wm8988_modinit': > wm8988.c:(.init.text+0xb): undefined reference to `i2c_register_driver' > sound/soc/codecs/wm8988.o: In function `wm8988_exit': > wm8988.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' > sound/soc/codecs/wm8995.o: In function `wm8995_i2c_probe': > wm8995.c:(.text+0x1c4f): undefined reference to `__devm_regmap_init_i2c' > sound/soc/codecs/wm8995.o: In function `wm8995_modinit': > wm8995.c:(.init.text+0xb): undefined reference to `i2c_register_driver' > sound/soc/codecs/wm8995.o: In function `wm8995_exit': > wm8995.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' > > Add SND_SOC_I2C_AND_SPI dependency to fix this. > > Reported-by: Hulk Robot > Fixes: ea00d95200d02ece ("ASoC: Use imply for SND_SOC_ALL_CODECS") > Signed-off-by: YueHaibing > --- Acked-by: Charles Keepax Thanks, Charles