Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp3804838ybz; Mon, 20 Apr 2020 09:45:04 -0700 (PDT) X-Google-Smtp-Source: APiQypKLj5Hq5g/I7dUKccAz/xtc3eMTJCsjbt40vieOWl1Yqgfu5g8wLtxFO1YqY6UPM5lKFDZ1 X-Received: by 2002:aa7:c40c:: with SMTP id j12mr14561335edq.169.1587401104474; Mon, 20 Apr 2020 09:45:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587401104; cv=none; d=google.com; s=arc-20160816; b=qDkhFCvK6X0kFHRv2EaPGvIpIcw3QQriTgv0D8Dw3lgf+35u3hKEFNPxXmYTHydw0N pe2lEwA/lNAfogsJ9LcWf1S48Uh15ZsHwN/p/cpDQYBQQ37s8fDCUnok3/pcRZQG3uIY VU3pU/3HJGmWndwwIXwjYiXJQaXgUwnp00Sy0GG79mpoqpAoj2R/Q6Dzz49n9Q88d5+s JtDYjDVAO8MKTwpVsjJD3x/+2r7sw2COQvwA7N3FukghtJofB9AfdAZ50NybHlKgef4U EHw85ZdRzJm0m9Fs7h8l5R47fEHmRJeKhNxA1bdEUyCcTy3tN57EL+lTbEeIH7a5ztTx Jggw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:to:from:subject:cc:date :in-reply-to:content-transfer-encoding:dkim-signature:dkim-signature; bh=tGKhGxcuXz62vF/Dg9q0OABBhDVINldw8jc1jRGeLhc=; b=VOpvUh7CBtJb0erCDTA8TVMmqhiSl6KeXRrUwNCzl1O6H7kZ1epWcWz9Fyg1yHU5vW TeJESgnFfiuK5TggUTml6WH2MWlO4vFnkALM/E5bdt8yFNbK5/vL6+qUaasGcl1builD ySNgYxpxF33RdztjSgRfdWfToS+BLYsQas23ANI+q4ANbPx9ht+wQdyZPLnQ3HC30h// 3ScO2oJT9WKLvEKg1rucCxHZ/1Lkummc529s1+A5OTGeo2Di/kGG5Gro6cd5UxV4wIxe KQcbFGtxXZ7h2xQMjaG2OUSOAvS4hE2V8GlEA9/Eve3++XEVz15NVeQSBJ3ikpymTsK/ XtPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dxuuu.xyz header.s=fm3 header.b="qkOlMFp/"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=jF6OArxt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si799758ejy.347.2020.04.20.09.44.41; Mon, 20 Apr 2020 09:45:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@dxuuu.xyz header.s=fm3 header.b="qkOlMFp/"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=jF6OArxt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbgDTQje (ORCPT + 99 others); Mon, 20 Apr 2020 12:39:34 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:53741 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbgDTQje (ORCPT ); Mon, 20 Apr 2020 12:39:34 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id D53D43FC; Mon, 20 Apr 2020 12:39:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 20 Apr 2020 12:39:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dxuuu.xyz; h= content-transfer-encoding:content-type:in-reply-to:date:cc :subject:from:to:message-id; s=fm3; bh=tGKhGxcuXz62vF/Dg9q0OABBh DVINldw8jc1jRGeLhc=; b=qkOlMFp/X9vY4inHxrr+E4XYt42YrXgAI81JZw9R1 h+XWc9BA3oNMV3zEIDRGsbPKO7rI+EURrl9kpHk4fs+TJu/xXcoTENeHIwjj32ry PTottywSu8CRAYsvTAR4Kf1Y8Y4P4wxxLQhCTA+7BC+SXuPRTk4QrJlatXeJcCw9 +XjJw1knDsjiSmyeDmZ4SQ8c83OQAJEmYojYZVDJ/E4nFLqr4Wje54BNJDwwDIyl 0h+Dec+u+ymCYeHbDuxnCCMfnJtFpyOx7UXFD6wWu3kNgsFI1hpKOZsovzeRILs6 LJYiKi6mZSf0uJjZFgtQ2YRL0qXHsO9rHeX4e60ubl9aQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tGKhGx cuXz62vF/Dg9q0OABBhDVINldw8jc1jRGeLhc=; b=jF6OArxtd/Tba2z2ojqF/Z hOtQWDNurydWxwOQhJj5Tg7/Cql9WCs8+3d/dCMomshSceJt4UmfeURPCcpojPkU /SLItdC9QWITcrUGuipqx9WjMwvuyBsz9Ki3LhxmS/m+vb1ApvkNbzMkAgjXjwkD LsFeWak+5spj9lUfzEheJHyxDjtq+fmpwTW7idWcpGQd9z6jwpPKV4D35L167vuE gVfDTUjN7+rg6EDc14ijDaPxtjHKXNv1LSvHQR9OefcNoKz3MRzA2L82Atr0Rrjc PiZDB0D8XCy9JF36XwBOxyh066fZNTJeTexKrhe6d6bXcDe9fYETmvPZKHUNStWg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeefgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepgfgtjgffuffhvffksehtqhertddttdejnecu hfhrohhmpedfffgrnhhivghlucgiuhdfuceougiguhesugiguhhuuhdrgiihiieqnecukf hppeejfedrleefrddvgeejrddufeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepugiguhesugiguhhuuhdrgiihii X-ME-Proxy: Received: from localhost (c-73-93-247-134.hsd1.ca.comcast.net [73.93.247.134]) by mail.messagingengine.com (Postfix) with ESMTPA id 1F2D63065C30; Mon, 20 Apr 2020 12:39:29 -0400 (EDT) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 In-Reply-To: <20200420083046.GB28749@infradead.org> Date: Mon, 20 Apr 2020 09:37:42 -0700 Cc: , , , , , , Subject: Re: [RFC] uapi: Convert stat.h #define flags to enums From: "Daniel Xu" To: "Christoph Hellwig" Message-Id: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On Sun Apr 19, 2020 at 6:30 PM PST, Christoph Hellwig wrote: > And that breaks every userspace program using ifdef to check if a > symbolic name has been defined. How about shadowing #define's? Like for `enum nfnetlink_groups` in include/uapi/linux/netfilter/nfnetlink.h . Thanks, Daniel