Date: Thu, 2 Mar 2006 18:31:53 -0800
From: Andrew Morton <akpm@osdl.org>
To: Dave Peterson <dsp@llnl.gov>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
       bluesmoke-devel@lists.sourceforge.net
Subject: Re: [PATCH 13/15] EDAC: kobject/sysfs fixes
Message-Id: <20060302183153.452f93d9.akpm@osdl.org>
In-Reply-To: <200603021748.13853.dsp@llnl.gov>
References: <200603021748.13853.dsp@llnl.gov>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 20

Dave Peterson <dsp@llnl.gov> wrote:
>
> - After we unregister a kobject, wait for our kobject release method
>    to call complete().  This causes us to wait until the kobject
>    reference count reaches 0.  Otherwise, a task accessing the EDAC
>    sysfs interface can hold the reference count above 0 until after the
>    EDAC module has been unloaded.  When the reference count finally
>    drops to 0, this will result in an attempt to call our release
>    method inside the EDAC module after the module has already been
>    unloaded.

That's not really the way to do it.  If you have all the correct
module_get()s and try_module_get()s and module_put()s in all the right
places, kenrel/module.c:wait_for_zero_refcount() should do this for you.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/