Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Apr 2020 21:17:28 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [GIT pull] perf/urgent for 5.7-rc2
Message-ID: <20200420191728.GN20730@hirez.programming.kicks-ass.net>
References: <158730459860.31269.9496277256253823777.tglx@nanos.tec.linutronix.de>
 <158730460101.31269.5005570498545135614.tglx@nanos.tec.linutronix.de>
 <CAHk-=wjUS9b-B1n=OCBdqq3mdVTNGz0zqhGnrtMijoB5qT+96g@mail.gmail.com>
 <20200419200758.3xry3vn2a5caxapx@treble>
 <20200420074845.GA72554@gmail.com>
 <CAHk-=wiG=Bz57AUmbTyZYMKU6C+nZpS8P2=vFf5xAAhBzrPuTQ@mail.gmail.com>
 <20200420174031.GM20730@hirez.programming.kicks-ass.net>
 <20200420181730.4bmggezf2zhu4ffb@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200420181730.4bmggezf2zhu4ffb@treble>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 20, 2020 at 01:17:30PM -0500, Josh Poimboeuf wrote:
> On Mon, Apr 20, 2020 at 07:40:31PM +0200, Peter Zijlstra wrote:

> > So my pet peeve is that when objtool errors, or crashes, the .o file
> > gets deleted and it becomes really hard to debug the situation. I'm
> > thinking that your suggestion would actually help with that too.
> 
> I do have the same pet peeve and I'm thinking we should just revert
> 644592d32837 ("objtool: Fail the kernel build on fatal errors") which
> would ease most of the pain.  Those fatal errors don't really buy us
> much IMO.  Agree?

Well, I like that it stops the kernel build on an error; I hate that it
makes it so damn hard to then diagnose and fix the error :/

Also, it doesn't really help for crashes, luckily those are somewhat
rare -- except I had one today as a result of a mis-merge...

> > I just don't have enough Kbuild foo to even attempt this :/
> 
> It's an interesting idea, but it might have its own share of annoyances.
> 
> If you added something bad to a file, and just rebuilt that file, you
> wouldn't see the objtool warning until later when you build the entire
> kernel. 

Moo.. :/