Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Apr 2020 15:23:10 -0500
From:   Patrick Williams <patrick@stwcx.xyz>
To:     Wolfram Sang <wsa@the-dreams.de>
Cc:     Patrick Williams <alpawi@amazon.com>,
        =?iso-8859-1?Q?Bj=F6rn_Ard=F6?= <bjorn.ardo@axis.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: slave-eeprom: support additional models
Message-ID: <20200420202310.GA95151@heinlein.lan.stwcx.xyz>
References: <20191001164009.21610-1-alpawi@amazon.com>
 <20191001164009.21610-2-alpawi@amazon.com>
 <20200420164619.GE3721@ninjato>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3"
Content-Disposition: inline
In-Reply-To: <20200420164619.GE3721@ninjato>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--r5Pyd7+fXNt84Ff3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 20, 2020 at 06:46:19PM +0200, Wolfram Sang wrote:
> On Tue, Oct 01, 2019 at 11:40:06AM -0500, Patrick Williams wrote:
> > Add support for emulating the following EEPROMs:
> >     * 24c01  - 1024 bit
> >     * 24c128 - 128k bit
> >     * 24c256 - 256k bit
> >     * 24c512 - 512k bit
> >=20
> > The flag bits in the device id were shifted up 1 bit to make
> > room for saving the 24c512's size.  24c512 uses the full 16-bit
> > address space of a 2-byte addressable EEPROM.
> >=20
> > Signed-off-by: Patrick Williams <alpawi@amazon.com>
>=20
> Do you really need them or is it just nice to have?
>=20
> I am undecided. I definately don't want all the EEPROM types which
> exist, but the full 16 bit address range makes sense...
>=20
> More opinions welcome.
>=20

I don't remember exactly which ones we needed (and I am no longer at
Amazon), but it was pretty trivial to add them all to the table so I
went ahead and did it.  As long as we had one of the 2-byte addressable
EEPROMs, anything else necessary could be handleded as a small
out-of-tree patch.

--=20
Patrick Williams

--r5Pyd7+fXNt84Ff3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAl6eBKwACgkQqwNHzC0A
wRm+3w/+LxsR2vMn880CT3tcUun6w0nwd9uLyu8glBEEBgpOOLFe8X89BXGNPeJP
Kll58XbbYuOVxLG2jJwrz7K5KRW2tU+7R/hYtOV31jXDldxmEF23IbyJewxghmri
YF4HB33xVDW2Jp9DWzwbgOjOgny6fJwUZ4Fi1OJ+xYNBIi1BRoG1url8qyVugka8
zKumoV2Cn28E/XnSl2w/qMFSA7mqfYZlzo5ChXZMuuNDx9CiZaBmDDv3ymegmD7r
2zvZRIweqex1xsVFWO7HJ0dAryQAez+giAkGS0b8u1pfa1m1ysNyspamJ6+ZRFtL
Xyw2JxlEbdEHSZ+hiinUidOwv52TP8C5Zk8yirzDsVFM+ODCB8Noj3omFoFAgdLS
sRvmzjYCZr31BlznVnF65L6e4O9+kVSU57Olu5FYZb5Wb6cEoJF+NhMxWizT6s5D
Qym/vqSGtcU2jSzHBCTL9qkp6fZuqxdgmZ2TPMOhlgVibhnx6k1hnlnIVbbYuRUl
EsuiTj9GQ9pGRfkpttrUuZd74mHrw8le63LOmmNJvRsEipReH0rcwqMCdQP0vy58
/BnTDpaONj90J2IWtwLwoO1LvGUugTkx4/HiZmHfPFnih+dLjsOVAAunraDd+f8g
0Hdjzg1CilbUJ5hECb4L+IO07K0hc+mBqpAhDUcQMDahdKOJo84=
=6TW6
-----END PGP SIGNATURE-----

--r5Pyd7+fXNt84Ff3--