Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Apr 2020 16:43:59 -0500
From:   Rob Herring <robh@kernel.org>
To:     Anson Huang <Anson.Huang@nxp.com>
Cc:     srinivas.kandagatla@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH 2/3] dt-bindings: nvmem: Convert i.MX IIM to json-schema
Message-ID: <20200420214358.GA13370@bogus>
References: <1586921602-1877-1-git-send-email-Anson.Huang@nxp.com>
 <1586921602-1877-2-git-send-email-Anson.Huang@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1586921602-1877-2-git-send-email-Anson.Huang@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 15, 2020 at 11:33:21AM +0800, Anson Huang wrote:
> Convert the i.MX IIM binding to DT schema format using json-schema.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  .../devicetree/bindings/nvmem/imx-iim.txt          | 22 --------
>  .../devicetree/bindings/nvmem/imx-iim.yaml         | 59 ++++++++++++++++++++++
>  2 files changed, 59 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/nvmem/imx-iim.txt
>  create mode 100644 Documentation/devicetree/bindings/nvmem/imx-iim.yaml
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/imx-iim.txt b/Documentation/devicetree/bindings/nvmem/imx-iim.txt
> deleted file mode 100644
> index 1978c5b..0000000
> --- a/Documentation/devicetree/bindings/nvmem/imx-iim.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Freescale i.MX IC Identification Module (IIM) device tree bindings
> -
> -This binding represents the IC Identification Module (IIM) found on
> -i.MX25, i.MX27, i.MX31, i.MX35, i.MX51 and i.MX53 SoCs.
> -
> -Required properties:
> -- compatible: should be one of
> -	"fsl,imx25-iim", "fsl,imx27-iim",
> -	"fsl,imx31-iim", "fsl,imx35-iim",
> -	"fsl,imx51-iim", "fsl,imx53-iim",
> -- reg: Should contain the register base and length.
> -- interrupts: Should contain the interrupt for the IIM
> -- clocks: Should contain a phandle pointing to the gated peripheral clock.
> -
> -Example:
> -
> -	iim: iim@63f98000 {
> -		compatible = "fsl,imx53-iim", "fsl,imx27-iim";
> -		reg = <0x63f98000 0x4000>;
> -		interrupts = <69>;
> -                clocks = <&clks IMX5_CLK_IIM_GATE>;
> -	};
> diff --git a/Documentation/devicetree/bindings/nvmem/imx-iim.yaml b/Documentation/devicetree/bindings/nvmem/imx-iim.yaml
> new file mode 100644
> index 0000000..0d85d37
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/imx-iim.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/imx-iim.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX IC Identification Module (IIM) device tree bindings
> +
> +maintainers:
> +  - Anson Huang <Anson.Huang@nxp.com>
> +
> +description: |
> +  This binding represents the IC Identification Module (IIM) found on
> +  i.MX25, i.MX27, i.MX31, i.MX35, i.MX51 and i.MX53 SoCs.
> +
> +allOf:
> +  - $ref: "nvmem.yaml#"
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx25-iim
> +      - fsl,imx27-iim
> +      - fsl,imx31-iim
> +      - fsl,imx35-iim
> +      - fsl,imx51-iim
> +      - fsl,imx53-iim
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    description: |
> +      IIM's clock source.

Drop this. Same in patch 3.

> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/imx5-clock.h>
> +
> +    iim: efuse@63f98000 {
> +        compatible = "fsl,imx53-iim";
> +        reg = <0x63f98000 0x4000>;
> +        interrupts = <69>;
> +        clocks = <&clks IMX5_CLK_IIM_GATE>;
> +    };
> +
> +...
> -- 
> 2.7.4
>