Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4058669ybz; Mon, 20 Apr 2020 14:54:15 -0700 (PDT) X-Google-Smtp-Source: APiQypItJK7yF3wBLkDpV9dY2Ucna6gZZdg8mBwuOSleUGGrnvvnHythttoOqeXgiNcib5klEiOp X-Received: by 2002:a50:d78a:: with SMTP id w10mr16697322edi.356.1587419655101; Mon, 20 Apr 2020 14:54:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587419655; cv=none; d=google.com; s=arc-20160816; b=rh4WzoRYJii2DKdPBtSLDVNIL1cQCIFzauzWcogAIDEcWjOn7aK4ZDKEYAGlQ2OjfK DR+qNLMbjDdMXtVGY8P+zgCaQJuSiCneYsyUrVuOOSVqEiMsMNqBtzTxFGetWa8keBCV Abfa3Vy++cVDkWA9RIV/nkEQwoTujZ++qt3DrlRl3vSP8PIg9V2fLTQ+72EucdIvB9eW CNZbdKrjYtaYi2ys0jEPSGoLW8iFUEV9qlPlnRkIVbn6/dInfqV/6q1/HyYYG+NcmmLp qOe01qOJXg/eEhkGavkxVR2LPDMisdIoY4cCSOs9tXpNDoyJqJop2OqEcVz/ZZ97ZN9g QhXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=IfDxotnBvjL6zhaSG9tOYWhxsd8vHBZ5Qp7UGRKlkYE=; b=CcF/SvPgHOlBJl/1y0akOZodo3WJk9iN22MSeIg0uZF1nLSxcNUrFspt2XoXm9z8H1 O4XXkANq2FKdhqMcYoQSZ6CWTEh6qGVv57gIE+aC5fkptI+qn5VkMon/RToxsv7EX/GU 8bBsXoIYcH0nK4jXrQ7kUxIBlGOjwpZM/1DRpZmtl5Hdfa+9AY9/BlLiGLt/C0mfZXE9 s0DzUYuNfUoJimk9R3AcWiHzZSPFcvRsUnoS0BAbL2CJ3CWxMzRocUJ/2mMa7v6D2iJ9 3k/yJgqkvjmK8tzD3aXsWowMAdxEf7DMK8WULrdcDP2CFCsZEkcBvi+eqF1lH29bsC5x UAtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i6si452834edg.339.2020.04.20.14.53.52; Mon, 20 Apr 2020 14:54:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728151AbgDTVwD (ORCPT + 99 others); Mon, 20 Apr 2020 17:52:03 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57112 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbgDTVwD (ORCPT ); Mon, 20 Apr 2020 17:52:03 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jQeKU-00070C-0f; Mon, 20 Apr 2020 21:51:50 +0000 From: Colin King To: "David S . Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jakub Kicinski , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: ipv4: remove redundant assignment to variable rc Date: Mon, 20 Apr 2020 22:51:49 +0100 Message-Id: <20200420215149.98490-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable rc is being assigned with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- net/ipv4/af_inet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index cf58e29cf746..c618e242490f 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1914,7 +1914,7 @@ static int __init inet_init(void) { struct inet_protosw *q; struct list_head *r; - int rc = -EINVAL; + int rc; sock_skb_cb_check_size(sizeof(struct inet_skb_parm)); -- 2.25.1