Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4065294ybz; Mon, 20 Apr 2020 15:02:41 -0700 (PDT) X-Google-Smtp-Source: APiQypJ/LAr0JIkx4nBXjy0F+0BZFDrXp7uND1JN9HR2WgDVVG84qzAX41nP55iuRpkr+eXx4wLh X-Received: by 2002:a05:6402:684:: with SMTP id f4mr16677438edy.240.1587420161588; Mon, 20 Apr 2020 15:02:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587420161; cv=none; d=google.com; s=arc-20160816; b=kMo1PEVdcS1ZYZTWRedW9293hzdS//IC+fLN1inNwlAyvS7p5vtLEMT5NBhKfz5yTO IocNIkgDr5EBQwNmtAmSHQEuDOJTMap/84ttwX7T+1igHbOBW19A6662CvSEKfeTzRC3 PZR+R044iiKmYN18p9AW7ZPzrMMicS/vDRQdqYWrZPt+UAvGRozzbNvS0GVx3lKHM0VV GhHll73FZrTITLKL6FUOnIldvcj8wAfVgAHPvEdBJvlY3D/9BpmZ+9LV9ttW+0gBl+aR ZXpJHnmZnuWkqrOQXFQ05RYbY6iCX5XFKYF7+xuznO6m2A0Zqn2BiXZhm/KKV4Dlenop x5gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=uaBeyNRbAU+F26Isoe9cmWsmOCYbeLBRuKNENQPJUGc=; b=qdY1Qf1ysAarxqjyVIlbBaWgwYPrbctEyVvhmYbwoNDv2j0h/hRj6bk37Xna/ajA7B cohTjrDP+Q4SAzFm3pKaxOaTMuBbFTB9fjoKYRF1GtnNzH8ajmZ2kix8P87V8yDkhBvk M0QFd46D1rzDuqlpEM2JkGCxAztNjiCZRsXdHod4D+U8wIZYWVZ5JpWfLjFeVAy7ARJY DxF/kNm86EASQ+VLUgw3SzXscdLVTzhuyQ9oB5lw6BEEDXkEfeD3YBeBzzgL9J7J4XH8 lg6K4dxHB+mZaaj6XXMu0nIcwJ02nboqNbrTpu5uiorEMlaUZY/NI7UxBFdD8JEW8AtZ 3G4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 5si297724ejv.400.2020.04.20.15.02.09; Mon, 20 Apr 2020 15:02:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbgDTWBB (ORCPT + 99 others); Mon, 20 Apr 2020 18:01:01 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57300 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgDTWBA (ORCPT ); Mon, 20 Apr 2020 18:01:00 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jQeTJ-0007fB-AW; Mon, 20 Apr 2020 22:00:57 +0000 From: Colin King To: Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] f2fs: remove redundant assignment to variable err Date: Mon, 20 Apr 2020 23:00:57 +0100 Message-Id: <20200420220057.98796-1-colin.king@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The variable err is being assigned with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- fs/f2fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index f54119da2217..e4585c3d1a7c 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -564,7 +564,7 @@ static int f2fs_unlink(struct inode *dir, struct dentry *dentry) struct inode *inode = d_inode(dentry); struct f2fs_dir_entry *de; struct page *page; - int err = -ENOENT; + int err; trace_f2fs_unlink_enter(dir, dentry); -- 2.25.1