Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4098440ybz; Mon, 20 Apr 2020 15:46:00 -0700 (PDT) X-Google-Smtp-Source: APiQypLXjLpWZI6N/y6IOknG6Z92fUeRrISxZs5SZgE5Vdmu0UZnuXUZeW+orxz63ku1DruLnSRB X-Received: by 2002:a17:907:20a2:: with SMTP id pw2mr18705597ejb.252.1587422760085; Mon, 20 Apr 2020 15:46:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587422760; cv=none; d=google.com; s=arc-20160816; b=fcBdxxSnmS7BtCX4ElSzN52XklXUnEMRPjRw8CcxXnjBAeB2SMtA0VWslIxJx9ovZ0 EOwaqvE/NBnvTeXHNHW78cOkb59A5+U/vS/7SzaXtDGUEv7j3if+hfJoFBDOhC2DNTN2 /uchUO+drC9/ryfzr0Be3ohWXlyloBFHzDhmk73AposVtjQh+i/9Xw7Z7LEC79ytGj5i +5LvM7JoAdVY5iMCVO2CL5IrkIxvk4RO3xkH59pOM0UQFo5OKSNyr3TS+VG47NQV7esN v71Lei74yNgzHYBz0P4qHLIZ+xmNVeQyG0bF3SnLJdoSc+ofuUZVB1K+TBg3tXA3b8Ly H1qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=3ole8TWcabCnpMGKsqdKip1VZqK6476/UWpp0kgBe70=; b=QdrFwZH52JTO4UobvJVw7YfkmBRBQeUhE0/4q+1Ugd2PHFqNTgo9tdbEUk2+i6VTrN pGb0/pnIAVGU/r2bOR9uXf3Q8sCbEoUdPqq08CBQOyxhy3wRnp79kAC5RH8BJKHNvQar X6r1ulokPDAxxv3tce5F4uTQdUvNEvQSoXnUyaEkkGJ0Wr3rHzGRZlDU70tduD/vcWSc wG77Hs8xgyvL5+OSnSPCFrsI/BAlfYK7+g0kEcb1wLdKTBb5+HDIDFUSenrVm5aeetON 5YPHJNoWdOeRk/dw4RrpQ3OT13xP4IpHyK+xvtFjvOnZNM6xzFJm9LkjULpd5DBjXYFf bMGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=MMwrbHy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cz11si522647edb.383.2020.04.20.15.45.37; Mon, 20 Apr 2020 15:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=MMwrbHy7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728156AbgDTWl4 (ORCPT + 99 others); Mon, 20 Apr 2020 18:41:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726611AbgDTWlz (ORCPT ); Mon, 20 Apr 2020 18:41:55 -0400 Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD019C061A0C; Mon, 20 Apr 2020 15:41:53 -0700 (PDT) Received: by mail-qv1-xf43.google.com with SMTP id v10so1563145qvr.2; Mon, 20 Apr 2020 15:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3ole8TWcabCnpMGKsqdKip1VZqK6476/UWpp0kgBe70=; b=MMwrbHy7Dp4rVk0D31KjbYSihvaSGCE46LuvgK45w4aA65KXKEBm5fU9g2jxCp3iWC 4IjM9j7PdxBWHekfW/LNIE9JGRhJeNvcsSZzOXQL0DWUlIqbgIQD75ivjGUUjyIPTtEn 3vfvgpy5ZTyakNXj21uuoZ0q3YxHszsn+Mrr8jbWD5WcNdhkLX9gN0e5oX9KnyEc1oHj efT7LHIwTuNIuVMlGi+6g8nXbU0/r/YtZ78g6eRvQ4OcsBBW8d32CYiWlb+MQZoc6kFq KhDZtWyYKqUmq4i2iGxkQfZJ3N11KIr0XDyE4giauH++oehVND5feLQ8WkW/dR6UYsj3 p5Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3ole8TWcabCnpMGKsqdKip1VZqK6476/UWpp0kgBe70=; b=son+aLyoKE1kQQ0IXH8Y1BfcQ5mjtsIOlHb72DQ9fUL5r56OqZ07DW9GHxsAX9633U +VEzvsNjga+RwgQaflsc5KHTLgXrI6rOUdJhZOIg9AYnO1Zvsll+k1kcIEu+sWZvQOZN GBIYFqbltVO7N24A1/u5LZaSXCL6YrPeCCzg0TxCteM5sw+WB7DH9wiFizw51tGfoZQL hBcAfZ59hAzSDFp7fAu1TuE/ENV+/AXDN/vgIFtW5q3Ov+8c48oU+pPdk5lo9da6kSig tgg3pGC9iDQLlfbqixO1/abNsvk9+NJTaYMjuYEd3/E4kQSD0EFGpMe43C2iBKOD6tnz c4iA== X-Gm-Message-State: AGi0PuYEqBc01DN/y1LP87CEppIiVS7Me1owIiHso3Vu4b8CQEpFRfQi VlHOSjBxInHueYFT/oLSLc4= X-Received: by 2002:a0c:e305:: with SMTP id s5mr11609464qvl.234.1587422512944; Mon, 20 Apr 2020 15:41:52 -0700 (PDT) Received: from dschatzberg-fedora-PC0Y6AEN.thefacebook.com ([2620:10d:c091:480::1:b0d9]) by smtp.gmail.com with ESMTPSA id j90sm511052qte.20.2020.04.20.15.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 15:41:52 -0700 (PDT) From: Dan Schatzberg Cc: Dan Schatzberg , Johannes Weiner , Jens Axboe , Alexander Viro , Jan Kara , Amir Goldstein , Tejun Heo , Li Zefan , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Shakeel Butt , Chris Down , Yang Shi , Ingo Molnar , "Peter Zijlstra (Intel)" , Mathieu Desnoyers , "Kirill A. Shutemov" , Andrea Arcangeli , Thomas Gleixner , linux-block@vger.kernel.org (open list:BLOCK LAYER), linux-kernel@vger.kernel.org (open list), linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)), cgroups@vger.kernel.org (open list:CONTROL GROUP (CGROUP)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: [PATCH 4/4] loop: Charge i/o to mem and blk cg Date: Mon, 20 Apr 2020 18:39:32 -0400 Message-Id: <20200420223936.6773-5-schatzberg.dan@gmail.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200420223936.6773-1-schatzberg.dan@gmail.com> References: <20200420223936.6773-1-schatzberg.dan@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current code only associates with the existing blkcg when aio is used to access the backing file. This patch covers all types of i/o to the backing file and also associates the memcg so if the backing file is on tmpfs, memory is charged appropriately. This patch also exports cgroup_get_e_css so it can be used by the loop module. Signed-off-by: Dan Schatzberg Acked-by: Johannes Weiner --- drivers/block/loop.c | 59 +++++++++++++++++++++++++------------- drivers/block/loop.h | 3 +- include/linux/memcontrol.h | 6 ++++ kernel/cgroup/cgroup.c | 1 + 4 files changed, 48 insertions(+), 21 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 3a109975d2df..0a4838faf5e6 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -77,6 +77,7 @@ #include #include #include +#include #include "loop.h" @@ -507,8 +508,6 @@ static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) { struct loop_cmd *cmd = container_of(iocb, struct loop_cmd, iocb); - if (cmd->css) - css_put(cmd->css); cmd->ret = ret; lo_rw_aio_do_completion(cmd); } @@ -569,8 +568,6 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, cmd->iocb.ki_complete = lo_rw_aio_complete; cmd->iocb.ki_flags = IOCB_DIRECT; cmd->iocb.ki_ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE, 0); - if (cmd->css) - kthread_associate_blkcg(cmd->css); if (rw == WRITE) ret = call_write_iter(file, &cmd->iocb, &iter); @@ -578,7 +575,6 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, ret = call_read_iter(file, &cmd->iocb, &iter); lo_rw_aio_do_completion(cmd); - kthread_associate_blkcg(NULL); if (ret != -EIOCBQUEUED) cmd->iocb.ki_complete(&cmd->iocb, ret, 0); @@ -924,7 +920,7 @@ struct loop_worker { struct list_head cmd_list; struct list_head idle_list; struct loop_device *lo; - struct cgroup_subsys_state *css; + struct cgroup_subsys_state *blkcg_css; unsigned long last_ran_at; }; @@ -941,7 +937,7 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) spin_lock_irq(&lo->lo_lock); - if (!cmd->css) + if (!cmd->blkcg_css) goto queue_work; node = &lo->worker_tree.rb_node; @@ -949,10 +945,10 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) while (*node) { parent = *node; cur_worker = container_of(*node, struct loop_worker, rb_node); - if (cur_worker->css == cmd->css) { + if (cur_worker->blkcg_css == cmd->blkcg_css) { worker = cur_worker; break; - } else if ((long)cur_worker->css < (long)cmd->css) { + } else if ((long)cur_worker->blkcg_css < (long)cmd->blkcg_css) { node = &(*node)->rb_left; } else { node = &(*node)->rb_right; @@ -964,13 +960,16 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd) worker = kzalloc(sizeof(struct loop_worker), GFP_NOWAIT | __GFP_NOWARN); /* * In the event we cannot allocate a worker, just queue on the - * rootcg worker + * rootcg worker and issue the I/O as the rootcg */ - if (!worker) + if (!worker) { + cmd->blkcg_css = NULL; + cmd->memcg_css = NULL; goto queue_work; + } - worker->css = cmd->css; - css_get(worker->css); + worker->blkcg_css = cmd->blkcg_css; + css_get(worker->blkcg_css); INIT_WORK(&worker->work, loop_workfn); INIT_LIST_HEAD(&worker->cmd_list); INIT_LIST_HEAD(&worker->idle_list); @@ -1221,7 +1220,7 @@ static int __loop_clr_fd(struct loop_device *lo, bool release) idle_list) { list_del(&worker->idle_list); rb_erase(&worker->rb_node, &lo->worker_tree); - css_put(worker->css); + css_put(worker->blkcg_css); kfree(worker); } spin_unlock_irq(&lo->lo_lock); @@ -2030,13 +2029,18 @@ static blk_status_t loop_queue_rq(struct blk_mq_hw_ctx *hctx, } /* always use the first bio's css */ + cmd->blkcg_css = NULL; + cmd->memcg_css = NULL; #ifdef CONFIG_BLK_CGROUP - if (cmd->use_aio && rq->bio && rq->bio->bi_blkg) { - cmd->css = &bio_blkcg(rq->bio)->css; - css_get(cmd->css); - } else + if (rq->bio && rq->bio->bi_blkg) { + cmd->blkcg_css = &bio_blkcg(rq->bio)->css; +#ifdef CONFIG_MEMCG + cmd->memcg_css = + cgroup_get_e_css(cmd->blkcg_css->cgroup, + &memory_cgrp_subsys); +#endif + } #endif - cmd->css = NULL; loop_queue_work(lo, cmd); return BLK_STS_OK; @@ -2048,13 +2052,28 @@ static void loop_handle_cmd(struct loop_cmd *cmd) const bool write = op_is_write(req_op(rq)); struct loop_device *lo = rq->q->queuedata; int ret = 0; + struct mem_cgroup *old_memcg = NULL; if (write && (lo->lo_flags & LO_FLAGS_READ_ONLY)) { ret = -EIO; goto failed; } + if (cmd->blkcg_css) + kthread_associate_blkcg(cmd->blkcg_css); + if (cmd->memcg_css) + old_memcg = memalloc_use_memcg( + mem_cgroup_from_css(cmd->memcg_css)); + ret = do_req_filebacked(lo, rq); + + if (cmd->blkcg_css) + kthread_associate_blkcg(NULL); + + if (cmd->memcg_css) { + memalloc_use_memcg(old_memcg); + css_put(cmd->memcg_css); + } failed: /* complete non-aio request */ if (!cmd->use_aio || ret) { @@ -2132,7 +2151,7 @@ static void loop_free_idle_workers(struct timer_list *timer) break; list_del(&worker->idle_list); rb_erase(&worker->rb_node, &lo->worker_tree); - css_put(worker->css); + css_put(worker->blkcg_css); kfree(worker); } if (!list_empty(&lo->idle_worker_list)) diff --git a/drivers/block/loop.h b/drivers/block/loop.h index 87fd0e372227..3e65acf7a0e9 100644 --- a/drivers/block/loop.h +++ b/drivers/block/loop.h @@ -74,7 +74,8 @@ struct loop_cmd { long ret; struct kiocb iocb; struct bio_vec *bvec; - struct cgroup_subsys_state *css; + struct cgroup_subsys_state *blkcg_css; + struct cgroup_subsys_state *memcg_css; }; /* Support for loadable transfer modules */ diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index d275c72c4f8e..a85cbafae6af 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -923,6 +923,12 @@ static inline struct mem_cgroup *get_mem_cgroup_from_page(struct page *page) return NULL; } +static inline +struct mem_cgroup *mem_cgroup_from_css(struct cgroup_subsys_state *css) +{ + return NULL; +} + static inline void mem_cgroup_put(struct mem_cgroup *memcg) { } diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 06b5ea9d899d..a3c64d961d68 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -587,6 +587,7 @@ struct cgroup_subsys_state *cgroup_get_e_css(struct cgroup *cgrp, rcu_read_unlock(); return css; } +EXPORT_SYMBOL_GPL(cgroup_get_e_css); static void cgroup_get_live(struct cgroup *cgrp) { -- 2.24.1