Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200420084210.14245-1-m.othacehe@gmail.com> <20200420084210.14245-3-m.othacehe@gmail.com>
In-Reply-To: <20200420084210.14245-3-m.othacehe@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 21 Apr 2020 03:41:12 +0300
Message-ID: <CAHp75VektPSwxu3bShk9yQhbNGmYDa2j1Vbapdkrn3rBiaZ0WQ@mail.gmail.com>
Subject: Re: [PATCH v3 2/4] iio: vcnl4000: Add event support for VCNL4010/20.
To:     Mathieu Othacehe <m.othacehe@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 20, 2020 at 11:43 AM Mathieu Othacehe <m.othacehe@gmail.com> wrote:
>
> The VCNL4010 and VCNL4020 chips are able to raise interrupts on proximity
> threshold events. Add support for threshold rising and falling events for
> those two chips.

...

> +       ret = (ret & VCNL4000_SELF_TIMED_EN) > 0;

This can be done outside of lock.
And here is type violation. Use bool for the function.

> +end:
> +       mutex_unlock(&data->vcnl4000_lock);
> +
> +       return ret;
> +}

...

> +       ret = (ret & VCNL4010_INT_THR_EN) > 0;
> +
> +end:
> +       mutex_unlock(&data->vcnl4000_lock);
> +
> +       return ret;
> +}

Ditto.

-- 
With Best Regards,
Andy Shevchenko