Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200420084210.14245-1-m.othacehe@gmail.com> <20200420084210.14245-4-m.othacehe@gmail.com>
In-Reply-To: <20200420084210.14245-4-m.othacehe@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 21 Apr 2020 03:44:02 +0300
Message-ID: <CAHp75Vc+pgSUfFSxHxw7wtPxbDSzO8muv435GWy_2R_d6SOXoA@mail.gmail.com>
Subject: Re: [PATCH v3 3/4] iio: vcnl4000: Add sampling frequency support for VCNL4010/20.
To:     Mathieu Othacehe <m.othacehe@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald <pmeerw@pmeerw.net>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 20, 2020 at 11:44 AM Mathieu Othacehe <m.othacehe@gmail.com> wrote:
>
> Add sampling frequency support for ambient light and proximity data on
> VCNL4010 and VCNL4020 chips.

...

> +static struct attribute *vcnl4010_attributes[] = {
> +       &iio_const_attr_in_illuminance_sampling_frequency_available.dev_attr.attr,
> +       &iio_const_attr_in_proximity_sampling_frequency_available.dev_attr.attr,

> +       NULL,

No comma for terminator line.

> +};
...

> +static const struct attribute_group vcnl4010_attribute_group = {
> +       .attrs = vcnl4010_attributes

Leave comma at the end in struct member definition.

> +};

-- 
With Best Regards,
Andy Shevchenko