Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Avri Altman'" <Avri.Altman@wdc.com>, <robh@kernel.org>
Cc:     <devicetree@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
        <krzk@kernel.org>, <martin.petersen@oracle.com>,
        <kwmad.kim@samsung.com>, <stanley.chu@mediatek.com>,
        <cang@codeaurora.org>, <linux-samsung-soc@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
In-Reply-To: <SN6PR04MB464049754716338FA4202E62FCD40@SN6PR04MB4640.namprd04.prod.outlook.com>
Subject: RE: [PATCH v6 09/10] scsi: ufs-exynos: add UFS host support for
 Exynos SoCs
Date:   Tue, 21 Apr 2020 06:29:20 +0530
Message-ID: <000001d61778$1ad10a70$50731f50$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJQDPill8kAmUENoj8JBCZ49rLenQJwluT7Ac8KJGcDHzROdqdT3pZg
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <20200417175944.47189-1-alim.akhtar@samsung.com>
        <CGME20200417181024epcas5p4231ae3dd2598155854e9b7ee52438bcb@epcas5p4.samsung.com>
        <20200417175944.47189-10-alim.akhtar@samsung.com>
        <SN6PR04MB464049754716338FA4202E62FCD40@SN6PR04MB4640.namprd04.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Avri,

> -----Original Message-----
> From: Avri Altman <Avri.Altman=40wdc.com>
> Sent: 20 April 2020 15:56
> To: Alim Akhtar <alim.akhtar=40samsung.com>; robh=40kernel.org
> Cc: devicetree=40vger.kernel.org; linux-scsi=40vger.kernel.org; krzk=40ke=
rnel.org;
> martin.petersen=40oracle.com; kwmad.kim=40samsung.com;
> stanley.chu=40mediatek.com; cang=40codeaurora.org; linux-samsung-
> soc=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-
> kernel=40vger.kernel.org
> Subject: RE: =5BPATCH v6 09/10=5D scsi: ufs-exynos: add UFS host support =
for Exynos
> SoCs
>=20
> > +       struct exynos_ufs_drv_data *drv_data;
> > +
> > +       u32 opts;
> > +=23define EXYNOS_UFS_OPT_HAS_APB_CLK_CTRL                BIT(0)
> > +=23define EXYNOS_UFS_OPT_SKIP_CONNECTION_ESTAB   BIT(1)
> > +=23define EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL    BIT(2)
> > +=23define EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX       BIT(3)
> > +=23define EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER    BIT(4)
> Could not find where the last 2 are being used.
>=20
The assignment is done on line=23 988 and 989 in exynos_ufs_init() and used=
 in =7Bpre,post=7D_hibern8,=20
let me see if I can add these in the list of .opts in drv_data.
Thanks for pointing this out.

> Thanks,
> Avri