Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4251093ybz; Mon, 20 Apr 2020 19:23:20 -0700 (PDT) X-Google-Smtp-Source: APiQypJ2OuDpH4hOqUVWi1HiMJCsePUGaRo7N2fy8jEotYYniR35z0lOTJgQW3pl2PGi9Jbt0bXi X-Received: by 2002:a50:e3cb:: with SMTP id c11mr8989612edm.105.1587435800135; Mon, 20 Apr 2020 19:23:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587435800; cv=none; d=google.com; s=arc-20160816; b=sSk9/VO7uV+MiK3gmMMOZZX5Il8UbFef74LStADv1CPegvx1iAQ9awF610/Y1kDBOW M6gZqXG1Bl2T0STs2Mr1vHNQTjg/GaPOE1VgVEDLAIEweZKV/zDZps6EMMr/aO3AmQCE zZCBWnvYkiPq4QWJcHtY63It6EXxhu3w9jIIIDSxAZTVmRqOp7O8f9ALH/RRk1e0wVb+ XvhMLFtyhVIGP+xGUHzRHM4Ci4tHnyX5sYjyoL769bzLslK+3huM7mhTt9kKY1yqMwUO uB2pzjDZ1bW7eUWuE4uEu0KGF/CAqPnwSfWVGalspjgu3PQGGUSXkS5nfB0X6ZhtLg6e xxYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=bf0qUv7sX/hAr5iVO/kB1EyGK9DUukbg+qSifBDNx20=; b=vIJCWhYX73UynVm8PqM/zM13eiONlmtlfK0jM1xEqdraSpjMdnqmKEu3S5feeS/zkU 1FPZ8d4OGzamIKSx4jCfVi3uffSf0BKqHqx1nLMx6/65O7F1TJtY7NPs0znTNBGvP3kU wYeo9jQFuw0kE2aTfNGCk4e83qCuJjHluJ31Na0gcz8UFlz7Dfpkk32AInrfuAZ5Mm5R 6TFMSJ0Np/RNh9CZ4az3ZGEtm++gZPw+7kF7gpM7XOvWD2DBDVUyTMOQJo8umY/RvG9+ mHXuASevpJ6JBzoG8LcmB3sOIMVBjtRiE2r30y6nzntfBsqZD9xdZv+tbfsZVyh7eyK2 6dlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e15si677546ejc.208.2020.04.20.19.22.56; Mon, 20 Apr 2020 19:23:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbgDUCTm (ORCPT + 99 others); Mon, 20 Apr 2020 22:19:42 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:38522 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725988AbgDUCTm (ORCPT ); Mon, 20 Apr 2020 22:19:42 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B16F7405F9438133B0B2; Tue, 21 Apr 2020 10:19:40 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 21 Apr 2020 10:19:38 +0800 Subject: Re: [PATCH v2] f2fs: fix to avoid page count leak To: CC: , , References: <20200415021313.95538-1-yuchao0@huawei.com> From: Chao Yu Message-ID: <634e3958-ee48-90b1-f32f-60e2bc4ca88e@huawei.com> Date: Tue, 21 Apr 2020 10:19:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200415021313.95538-1-yuchao0@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, Let's drop this patch, I encounter bad page state (nonzero refcount) reported by vm w/ this patch. On 2020/4/15 10:13, Chao Yu wrote: > In f2fs_read_data_pages(), once we add page into radix tree, we need to > release reference count of that page, however when f2fs_read_multi_pages() > fails, we didn't handle that case correctly, fix it. > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Signed-off-by: Chao Yu