Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Dexuan Cui <decui@microsoft.com>
To:     Ming Lei <ming.lei@redhat.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "hch@lst.de" <hch@lst.de>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
CC:     "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "hare@suse.de" <hare@suse.de>,
        Michael Kelley <mikelley@microsoft.com>,
        Long Li <longli@microsoft.com>
Subject: RE: [PATCH] scsi: core: Allow the state change from SDEV_QUIESCE to
 SDEV_BLOCK
Thread-Topic: [PATCH] scsi: core: Allow the state change from SDEV_QUIESCE to
 SDEV_BLOCK
Thread-Index: AQHWFSr+H/+YbDb0+UyY0wbeDKQCaqiC51HQ
Date:   Tue, 21 Apr 2020 03:01:34 +0000
Message-ID: <HK0P153MB02739AAF1415BCC36D8C4EB2BFD50@HK0P153MB0273.APCP153.PROD.OUTLOOK.COM>
References: <1587170445-50013-1-git-send-email-decui@microsoft.com>
 <20200418024158.GB17090@T590>
In-Reply-To: <20200418024158.GB17090@T590>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-21T03:01:32.9138726Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=cb35d881-2cae-4e5f-8a92-6c9fe43744ec;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=decui@microsoft.com; 
x-originating-ip: [2601:600:a280:7f70:8ad:e9e1:6b1b:63b1]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 48eb23b3-d673-410e-99d5-08d7e5a04d46
x-ms-traffictypediagnostic: HK0P153MB0177:|HK0P153MB0177:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <HK0P153MB01778178F6BFB6390D025E38BFD50@HK0P153MB0177.APCP153.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 038002787A
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0P153MB0273.APCP153.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(64756008)(5660300002)(186003)(66476007)(316002)(53546011)(71200400001)(6506007)(52536014)(76116006)(82960400001)(66446008)(10290500003)(66556008)(66946007)(82950400001)(478600001)(9686003)(86362001)(107886003)(55016002)(4326008)(110136005)(7696005)(8936002)(2906002)(8990500004)(81156014)(33656002)(54906003)(8676002);DIR:OUT;SFP:1102;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: mkTCl0iRzf9u69iX/x9vbokwKzHyIFvAzryiaGgv3WIFNtWlHT3D8mowzCxGB7Kq3FdVZ3hT9CnNxzOExnN7z13YywScnsVU91zALh1rZlXIwM0+auTMDEA4sHruN2vw6CNznkr68BhlKQNAX/mqhQA6OqefT21GpTXgujWbcuiWdQOj9jiNDrLFBWfxiwaGtHN+5Tv5W+s9iRZ+lBPzYJgCtiIAuFeHXJN5TpFXAZ2eKD5tQI/lANonxnEY4itqxWFqc+3FK8f0fQa9Pgl/SCsEWmC/HLJmxIVXSUduKsT7VSU+iHbb+Bt1rxULI4jJ/tpUuzmtPIz8//76JlR4NruUFBdqSDGXesvnjykigcRakvG3HBkPBPn1i2s4Yi3fcVOb5LdHiwAAXpAKfq+Unp4V7O0D9dKTuxejnKQSsz1az6d1Oyk4g6O8umQ8Ga6i
x-ms-exchange-antispam-messagedata: pzllJ8BJH3Dg3uK7vTkyuAjn/IrV8qbCscm8temMtTjx51sHnNojFoJbRVng+E28WkOjMzlLXwDFjpwjBAhHn7ZwaVdO6s4sD9S89xkOza6nm1BWQXiNwZO68KyA4ACbGDA3wo4V7d80buKsryNTxkxuigiypbFVGqXXFRZHZ1Fc8E8eWEO+WDxwBl5Gsl7c54/T23ZwAny+Qh5vDbyrFZHtxlBUvJUqYLF4BVKGp8nk51GPzuT3OLopJNwXuyOHHPbhu25q+ZliH+kIYDULW+WY5P134A6U03mtDFXguz/Pk0uUPMBZ0mpwuJWsFR2bk2Y0YoQ50NiYJZqWs16rxfbAQ7nJxo8CV8ohl/EHbK3SvYNxraXK6t56k5LIdO71EzcJ7bB9IlSa/x7dpbdTNpCp3tkd+mma7/kPEZA+ecBSI9xugoFJWvGbVfSnTyGalOzDv5zHNYAnw5sLHgzm92XvWUDjtad+LlxV0znG1UleMdAkbYwTfgDgnvY+D86Y/q2VTnPEdu9JqK9VXIV4AuojJNTySHfLo5s5vc2URo+5RyJXBisIHpq1H5Jhkj0mHwoOaxzft+Zurtz2ZwYcpO3Zd8ulF4p5LT25Zqh0bitYc1P96O4jkQHfl08Bh7TSKLxeHQ/YZsBYCAi1SpQ/H2fJpBKuF0mm1L3Opcg1zjRHdoekqEvsbMJlTVEBGsp05clNANFnP5lPKsi4VLVaFWaxW2rDptOZXaK5CCKjdDftlYYW8WlqOwST2SCFjzVGN1/8ptBfZWnaXA5pqtPANCMd6nbiG26/zxktmR0xbPT4+bRbdjiwFyuTL6Aqtj/jrWNYIl1xEHBpM8J1xF9m52bXOMRY10zJXSRITePjfp8=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48eb23b3-d673-410e-99d5-08d7e5a04d46
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 03:01:34.5937
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1q8fmkoCrux6qxTonuGJvUn5uGD2BkFy+1XRPN9452Dv6fWLVqOJPPL5/yyQCB2GYz7zJceKn0gprCtReaCXYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0P153MB0177
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Ming Lei <ming.lei@redhat.com>
> Sent: Friday, April 17, 2020 7:42 PM
> To: Dexuan Cui <decui@microsoft.com>
> Cc: jejb@linux.ibm.com; martin.petersen@oracle.com;
> linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; hch@lst.de;
> bvanassche@acm.org; hare@suse.de; Michael Kelley
> <mikelley@microsoft.com>; Long Li <longli@microsoft.com>
> Subject: Re: [PATCH] scsi: core: Allow the state change from SDEV_QUIESCE=
 to
> SDEV_BLOCK
>=20
> On Fri, Apr 17, 2020 at 05:40:45PM -0700, Dexuan Cui wrote:
> > The APIs scsi_host_block()/scsi_host_unblock() are recently added by:
> > 2bb955840c1d ("scsi: core: add scsi_host_(block,unblock) helper functio=
n")
> > and so far the APIs are only used by:
> > 3d3ca53b1639 ("scsi: aacraid: use scsi_host_(block,unblock) to block I/=
O")
> >
> > However, from reading the code, I think the APIs don't really work for
> > aacraid, because, in the resume path of hibernation, when aac_suspend()=
 ->
> > scsi_host_block() is called, scsi_device_quiesce() has set the state to
> > SDEV_QUIESCE, so aac_suspend() -> scsi_host_block() returns -EINVAL.
> >
> > Fix the issue by allowing the state change.
> >
> > Fixes: 2bb955840c1d ("scsi: core: add scsi_host_(block,unblock) helper
> function")
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > ---
> >  drivers/scsi/scsi_lib.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> > index 47835c4b4ee0..06c260f6cdae 100644
> > --- a/drivers/scsi/scsi_lib.c
> > +++ b/drivers/scsi/scsi_lib.c
> > @@ -2284,6 +2284,7 @@ scsi_device_set_state(struct scsi_device *sdev,
> enum scsi_device_state state)
> >  		switch (oldstate) {
> >  		case SDEV_RUNNING:
> >  		case SDEV_CREATED_BLOCK:
> > +		case SDEV_QUIESCE:
> >  		case SDEV_OFFLINE:
> >  			break;
> >  		default:
>=20
> Looks reasonable because SDEV_BLOCK is one more strict state than
> QEIESCE, so:

Thanks, Ming!

> Reviewed-by: Ming Lei <ming.lei@redha.com>
>=20
> Thanks,
> Ming

There should be a small typo: s/redha/redhat :-)

Thanks,
-- Dexuan