Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4293895ybz;
        Mon, 20 Apr 2020 20:27:48 -0700 (PDT)
X-Google-Smtp-Source: APiQypLn6ChQfRsvQnVH1DYH1MOGbzwf/ueMSymfp6unF4skJ3u0LZMyv4xGbX0/pCulkap2Dfbm
X-Received: by 2002:a17:906:3f88:: with SMTP id b8mr19801683ejj.301.1587439668547;
        Mon, 20 Apr 2020 20:27:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587439668; cv=none;
        d=google.com; s=arc-20160816;
        b=U++Dq9nPS9GJAHxBEXI6nZ+kRGzvIpTGeITfmpOqh1j3Lti5cxv+NYZfDhvCkbFbtx
         zptz8x8jwKr7297lfDo2hwVg+ccEh56+UuAQhLzi3s45xW61f2Q0bojrTd+PzFQlIUi1
         xuiksMdHd8gLLsi2lrU7S27jYJIpXImdtJH8R5rE/z7oRsT9SVzQYDNj3ISPm3plCKCa
         FPXwBE3dwH0ijx7aA3NoyULlritwluRLDuqxPBP5O50RTmzfyHjsj+cO07frlh7HDhsW
         EBzbMB0fkTCO1a9Im4RSA37RLrIhle5E0biXRFLKVZYlBZif2M18R01N3Eq5PvQX2Mzm
         Ai3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=yMiQgSp6+44yHi8Y/SiNH79yEV2BxaTZglsheeQ2n48=;
        b=qrglknr5S9MQCpa+/iV8QXGQ+kgyRYSqNcflZuyk0RayR4iSGbZe+b+bV7xnkMTqrS
         RAwQfGUAA5a1IQEcZXLNIouFir5qrOUz5DDXQoJHmbi4M5LXt/IDvWfMpCFaUwMAmMcT
         +J+rhyuT7mMAwhL05DcTmDnR2chZHQqTfwF0PWPx8MZrFGNaYQn21iS5YUghvsTzMKC+
         GSTH2xbSy3tW8+THD/AgV/Dp3hVxQN7hyGzeF9xFx0hath67HnLz6lTgluxL+qZsMJ9g
         3ZjeNnofZVULguOyzvGtN49fc+6l0TmX/xFqqNrDeMuiz/r/SatNd4IOa6mbcGy66aYN
         hJlg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=JG7FSWTd;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id c24si824111eds.119.2020.04.20.20.27.25;
        Mon, 20 Apr 2020 20:27:48 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=JG7FSWTd;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728315AbgDUDZO (ORCPT <rfc822;1dalishi1@gmail.com> + 99 others);
        Mon, 20 Apr 2020 23:25:14 -0400
Received: from mail.kernel.org ([198.145.29.99]:41802 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726958AbgDUDZO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Apr 2020 23:25:14 -0400
Received: from localhost (unknown [104.132.1.66])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 8C310206F9;
        Tue, 21 Apr 2020 03:25:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1587439513;
        bh=H29oCtqsrJtGWyg/QmRKF2AXzQxEwBYJaGQqfrdaBIc=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=JG7FSWTdN2QwjRKOyL04yifSxZUp8D6NrGwqKaBut9eS5w882u7MYS5c1iXvZaWzV
         p6tdkBdfSdH31LdypXsi3BPb4bgmWo4E830nbs5CKfm6qn8/WOZAKBZhpkwSk3yFB7
         bmkquRPoaiAVVlV68lzal/m9OjYpn2eYa4YVTveI=
Date:   Mon, 20 Apr 2020 20:25:13 -0700
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH v2] f2fs: fix to avoid page count leak
Message-ID: <20200421032513.GA134303@google.com>
References: <20200415021313.95538-1-yuchao0@huawei.com>
 <634e3958-ee48-90b1-f32f-60e2bc4ca88e@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <634e3958-ee48-90b1-f32f-60e2bc4ca88e@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/21, Chao Yu wrote:
> Hi Jaegeuk,
> 
> Let's drop this patch, I encounter bad page state (nonzero refcount) reported
> by vm w/ this patch.

Ok.

> 
> On 2020/4/15 10:13, Chao Yu wrote:
> > In f2fs_read_data_pages(), once we add page into radix tree, we need to
> > release reference count of that page, however when f2fs_read_multi_pages()
> > fails, we didn't handle that case correctly, fix it.
> > 
> > Fixes: 4c8ff7095bef ("f2fs: support data compression")
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>