Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2] amdgpu: optimization-- reduce noneed mutex_lock area
To:     1587181464-114215-1-git-send-email-bernard@vivo.com,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Bernard Zhao <bernard@vivo.com>
References: <20200421022528.126437-1-bernard@vivo.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
Message-ID: <16175fa0-4d9b-2de8-e708-22b373a6f7a4@amd.com>
Date:   Tue, 21 Apr 2020 00:20:29 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
In-Reply-To: <20200421022528.126437-1-bernard@vivo.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.2.100] (142.116.63.128) by YTOPR0101CA0061.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:14::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Tue, 21 Apr 2020 04:20:30 +0000
X-Originating-IP: [142.116.63.128]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: e26bbd3d-5747-42af-e9b9-08d7e5ab540c
X-MS-TrafficTypeDiagnostic: DM5PR12MB1882:|DM5PR12MB1882:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM5PR12MB1882FFE8CCF6B4BB85518AFA92D50@DM5PR12MB1882.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-Forefront-PRVS: 038002787A
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB2407.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(110136005)(86362001)(26005)(31696002)(4326008)(8676002)(36756003)(81156014)(8936002)(66946007)(2906002)(16526019)(186003)(16576012)(956004)(5660300002)(478600001)(44832011)(2616005)(31686004)(52116002)(6486002)(316002)(66476007)(66556008);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1R6NTpLPxKqwZeDtBAirtAuTJ1/hsV5IEX2ENiD7aG9SicleGyClcdzBMs2iIJaKIZHuq70jxfm77/k3mAlsMf6bVazp4OfCdQ2yL8IiO/4rOpT6yYsk2yioziopF4boEQROrsM0U1DNt0PfUocU2mFwlfsBW8TkmhzQBO0w9dTg9WPRuKXxAqjsd6jKTjDCNIMYuYY7Z1qufrBZkqDUJgcrGudT269Gp0EhoD3XsBBURAbGGIRKh5n0wWzqytIjhLmlrYeCevOcs+Z7Qd46wIjQ/4cljZHamW658Wp+fChtuK4iQq2iHYnMpRaJ1ekW97Y537YKfR9uGb1NVC6uG1/XO7EWBSB4pOkjCCO+n+tHEVRBNVi1GzT62hgJcqZySpNA0CnR8lqbdVTaRLz/jtyxZ9vHvlnDRWFYiJb1iPiPTXk+FvlRhWWUhncC/Wk3VLT57i9Wd1+UQvlSDMd1wRNHDmYLRPrQBpKMQmX4tMTiTc0oV5urADtd5HJ0Vy3W90nbbIUK+HdpAzSX2AzqBA==
X-MS-Exchange-AntiSpam-MessageData: /V86TuOj5LgXhP6XsnSsmxthsT3qsLt70gz0CV5TW7FMOslqIzphB35XdBDmQP2yXbrYxnl5VS/86SKOrzGliR3v4v/zf0a3Zl0L9pug5WWWffCBbNBedT53d7djK7IGYxRreUsCRWbOHANWBbMYHw==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e26bbd3d-5747-42af-e9b9-08d7e5ab540c
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2020 04:20:31.0684
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DsKFkbjvLl2wJ6a07aOYbqusT2eJ20DJ4BRbMOGgl+6l8Z8n++OhmIJDQ2c8EW49GCStx27GRSTS0Q9yUpBTsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1882
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Bernard,

Thank you for the patch. Please see some comments inline.

Am 2020-04-20 um 10:25 p.m. schrieb Bernard Zhao:
> Maybe we could reduce the mutex_lock(&mem->lock)`s protected code area,
> and noneed to protect pr_debug.

Typo: noneed -> no need


>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Changes since V1:
> *commit message improve
>
> Link for V1:
> *https://lore.kernel.org/patchwork/patch/1226588/
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 327317c54f7c..3c3769e57174 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1285,17 +1285,18 @@ int amdgpu_amdkfd_gpuvm_free_memory_of_gpu(
>  	struct bo_vm_reservation_context ctx;
>  	struct ttm_validate_buffer *bo_list_entry;
>  	int ret;
> +	unsigned int mapped_to_gpu_memory;
>  
>  	mutex_lock(&mem->lock);
> +	mapped_to_gpu_memory = mem->mapped_to_gpu_memory;
> +	mutex_unlock(&mem->lock);
>  
> -	if (mem->mapped_to_gpu_memory > 0) {
> +	if (mapped_to_gpu_memory > 0) {
>  		pr_debug("BO VA 0x%llx size 0x%lx is still mapped.\n",
>  				mem->va, bo_size);
> -		mutex_unlock(&mem->lock);
>  		return -EBUSY;
>  	}
>  
> -	mutex_unlock(&mem->lock);
>  	/* lock is not needed after this, since mem is unused and will
>  	 * be freed anyway
>  	 */

Please move this comment along with the mutex_unlock.

Regards,
  Felix