Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: hb62XXifCNpOHPMXkSDS0nWjNn63yrWZ4WEMWefoImClC2Q38h0cHfJbrvdU9t8YViR8wbewmQ
 SVsaVYNsC9VTbPW3dIopv8jWIFo50O6rGWyB1EXZdedo/rE5AfYY4ceEJekWw902hygfRVgfIt
 d8tct5bpLupp5q0IAV8+TsMelSHFXjWraarg/5/HtbDwZxN5oxTEKFTz6Af+HRvYMInRbbRv8o
 xz2nnhPBwefk6MmLvUz08QE4GwTca+JMyMsunutOm0I0YKaVYC53Qs95atc9TjOgWtq0gN1r85
 3Vo=
From:   <Tudor.Ambarus@microchip.com>
To:     <cleger@kalrayinc.com>
CC:     <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: Add support for is25lp01g
Thread-Topic: [PATCH] mtd: spi-nor: Add support for is25lp01g
Thread-Index: AQHWFw0/tWJ4ISRUwk6rGADNBybaDA==
Date:   Tue, 21 Apr 2020 04:40:56 +0000
Message-ID: <2185268.xDFeLDFsC1@192.168.0.120>
References: <20200417160839.25880-1-cleger@kalray.eu>
 <1950407.5XCTmqoEVg@192.168.0.120>
 <1734428336.16421904.1587394202163.JavaMail.zimbra@kalray.eu>
In-Reply-To: <1734428336.16421904.1587394202163.JavaMail.zimbra@kalray.eu>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <E0B86EF9D4654542BE07C80947FE1F10@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: daae8b8b-864a-4902-6a99-08d7e5ae2ee9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 04:40:56.8724
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: axTalg6ze2KmXGODU54ZYJcd3ptef+ygiWCaYP5mBajkBjPM2aLJgpU4cyTdVeKMdDnwyxMQ1HSu8CQ/vICdfnT8UeR7afH/Yqwj2gqIBic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4483
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, April 20, 2020 5:50:02 PM EEST Cl=E9ment Leger wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Hi Tudor,

Hi, Clement,

>=20
> ----- On 20 Apr, 2020, at 14:14, Tudor Ambarus Tudor.Ambarus@microchip.co=
m=20
wrote:
> > Hi, Clement,
> >=20
> > On Friday, April 17, 2020 7:08:39 PM EEST Clement Leger wrote:
> >> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> >> the
> >> content is safe
> >>=20
> >> Update the issi_parts table for is25lp01g (128MB) device from ISSI.
> >> Tested on Kalray K200 board.
> >>=20
> >> Signed-off-by: Clement Leger <cleger@kalray.eu>
> >> ---
> >>=20
> >>  drivers/mtd/spi-nor/issi.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>=20
> >> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> >> index ffcb60e54a80..c3c3438e3d08 100644
> >> --- a/drivers/mtd/spi-nor/issi.c
> >> +++ b/drivers/mtd/spi-nor/issi.c
> >> @@ -49,6 +49,8 @@ static const struct flash_info issi_parts[] =3D {
> >>=20
> >>                              SECT_4K | SPI_NOR_DUAL_READ |
> >>                              SPI_NOR_QUAD_READ
> >> |=20
> >> | SPI_NOR_4B_OPCODES)
> >> |=20
> >>                 .fixups =3D &is25lp256_fixups },
> >>=20
> >> +       { "is25lp01g",  INFO(0x9d601b, 0, 64 * 1024, 2048,
> >=20
> > There is a "K" flavor of this flash which has 512 Byte Page size with 2=
56
> > KB Block size. While the page size can be determined by parsing SFDP, I
> > think we will have some problems with sector_size because as of now, th=
e
> > sector_size is always set to 64KB. An incorrect sector_size will affect
> > erases and locking.
> Thanks, I did not noticed that ! If I understand, this will require to
> modify the core to handle sector size the same way as page_size and
> probably add a fixup to detect the "K" options from SFDP ?

Right. You can add a post_bfpt fixup hook for this flash. You can=20
differentiate between the "K" version and the rest by the page size. Since =
the=20
page size is tightly coupled with the sector size, you can amend both in th=
e=20
post_bfpt hook.

> This is probably more changes than I can handle, and you can probably dro=
p
> this patch since not really functional for "K" type flash.

I dropped it. You should try to fix it, I can guide you if needed. Or I can=
 do=20
it myself, but I'll need some help from you at testing.

Cheers,
ta