Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4348209ybz; Mon, 20 Apr 2020 21:51:42 -0700 (PDT) X-Google-Smtp-Source: APiQypKi1Nus1x+Ap/McrB29ZTUkm+0jHIkk+0t8Yrt3ZF5sOQ5me/icNfOdZia7bdwV2aso3p85 X-Received: by 2002:a17:906:15d4:: with SMTP id l20mr19075702ejd.91.1587444702288; Mon, 20 Apr 2020 21:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587444702; cv=none; d=google.com; s=arc-20160816; b=a/Gfv9YpYYJZkCSCG4PwWMQngDO9T1/S9vxN1cThmQoel6CpFYjlfOioGRs7dbL54J vdy6zmuKcyMK88eyQZteTg+cvEPCUE/oOyI8KsS/0lhGxzkp+1c85NgmSCN2is71QqDH X33c/VPtbkx1u57Wz6kPsWl66yQ7k0/MafgC9xsRrFLmfSLpqdB9IYr9mDr6e9y5+PoD mpFYto55rSvEfaPRwa7wr/YO6xAdpYaMXJ1N8OBZpmI0k7fNvPMxuPu9x4s4LsHDwoyV nD+NVH7CucmD14lFJZNqqz2GtJ+9j35Yu9lVw9b4STjIewU5M7dlYjwzI8D6guLaVfh1 fwBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=gSocD5b62mB6My10HgyjlcZ+p43kTd3iT2gMDWMfzV4=; b=vo7QbD+Cj/0zUBINQesXAZfFimKuZt8gV+UPUFZY2vdhMeI/U9nwsx7fWz1jXxq/jM QAFREaMEJBFf66xObaxu1lEBej1N2HbsrUblSc6gZMsuG4R8Ez2z0BMY9O+6JsdQ4Ozd o3UL1DmwztTOcaq2uYCyR7MevNUM5G3HxpBJTeFBeQsyDoFlXzso6n18jI5Pv3udTvVE YvUXucyEAZymr3bcu5jh654F5/Cy51xj9SDF/PbGDjBOIna95E+wRfnlA95FE87/zTCC nKcdMsy7If5TuaZ7Ot7H7aLLptBrbwnrYJgB5ruYyufzxcliDCSnbU2nKIcPt3vj6V8q gCIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org ([23.128.96.18]) by mx.google.com with ESMTP id k5si833255ejk.345.2020.04.20.21.51.19; Mon, 20 Apr 2020 21:51:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726364AbgDUEuW convert rfc822-to-8bit (ORCPT + 99 others); Tue, 21 Apr 2020 00:50:22 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36597 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbgDUEuV (ORCPT ); Tue, 21 Apr 2020 00:50:21 -0400 Received: from mail-pf1-f200.google.com ([209.85.210.200]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jQkrS-0005jV-HD for linux-kernel@vger.kernel.org; Tue, 21 Apr 2020 04:50:18 +0000 Received: by mail-pf1-f200.google.com with SMTP id a5so12152105pfk.6 for ; Mon, 20 Apr 2020 21:50:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iS1UqusYi3xL6rontdMWpTi7+P7gRt1tPUDk5laBrGI=; b=XLqHg8paK9hGyreGx00xNeWeTKkk0Z2KF9k7sne8gp2OEaOhy8s2bfZSk+VY/4UFDn 95tSz2m6kgnFby20F+MULohgMv1u6Kmm0YVXR2uxf+JbNZGB8QxcpTbT68NLv/b2wrcp 4GOnIqD46yN4lgD1f67dBisAd2NYuP7GWFAuSnaEmHxsXrXq4NTbXJoLkmosbu2/4uki 1qtK/xyWmzb+ZKdaFuCp445R+vLGkJpTBbKZzEQunLTUBdwWduYkVG5dh38feFkriJiC oDCu6F4e51ieg61Hs5fbWUV0A+/vR87UeokNEE+kk0woQYg/CYw1oyLgCmiUkztHEQK2 WzOQ== X-Gm-Message-State: AGi0PuZ951bW/6qR19ZcvtN7eY6ySXURMx84rY3MeO+nBwl4xRnGnvtm ka16o35HipQKs3QX0zUYOgNcNd+VT7R3J83LaKZ7gOBaysQLcsNWiAhUfVjIimbHhnnyQ+SNHRj JGgbkDrg1WoU2lirxYB+ol2y3KF8pbfW/V0kTy99XCA== X-Received: by 2002:a17:90a:f0d0:: with SMTP id fa16mr3510960pjb.33.1587444616958; Mon, 20 Apr 2020 21:50:16 -0700 (PDT) X-Received: by 2002:a17:90a:f0d0:: with SMTP id fa16mr3510934pjb.33.1587444616480; Mon, 20 Apr 2020 21:50:16 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id o1sm1007174pjs.39.2020.04.20.21.50.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2020 21:50:15 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [Intel-wired-lan] [PATCH 1/1] e1000e: Disable s0ix flow for X1 Carbon 7th From: Kai-Heng Feng In-Reply-To: Date: Tue, 21 Apr 2020 12:50:12 +0800 Cc: "Kirsher, Jeffrey T" , "open list:NETWORKING DRIVERS" , "moderated list:INTEL ETHERNET DRIVERS" , "David S. Miller" , open list Content-Transfer-Encoding: 8BIT Message-Id: References: <20200319052629.7282-1-kai.heng.feng@canonical.com> To: "Brown, Aaron F" X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > On Apr 21, 2020, at 04:27, Brown, Aaron F wrote: > >> From: Intel-wired-lan On Behalf Of Kai- >> Heng Feng >> Sent: Wednesday, March 18, 2020 10:26 PM >> To: Kirsher, Jeffrey T >> Cc: open list:NETWORKING DRIVERS ; Kai-Heng Feng >> ; moderated list:INTEL ETHERNET DRIVERS >> ; David S. Miller ; >> open list >> Subject: [Intel-wired-lan] [PATCH 1/1] e1000e: Disable s0ix flow for X1 Carbon >> 7th >> >> The s0ix flow makes X1 Carbon 7th can only run S2Idle for only once. >> >> Temporarily disable it until Intel found a solution. >> >> Link: https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon- >> 20200316/019222.html >> BugLink: https://bugs.launchpad.net/bugs/1865570 >> Signed-off-by: Kai-Heng Feng >> --- >> drivers/net/ethernet/intel/e1000e/netdev.c | 16 ++++++++++++++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) > > I do not have access to the "X1 Carbon 7th" this patch targets, but from a regression perspective against a number of other e1000e based parts: This patch can be superseded by "e1000e: bump up timeout to wait when ME un-configure ULP mode". So it's better to drop this patch in favor of a more generic solution. Kai-Heng > Tested-by: Aaron Brown