Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4348971ybz; Mon, 20 Apr 2020 21:53:06 -0700 (PDT) X-Google-Smtp-Source: APiQypKNhfNIRUKMpywlD6m1no+LpXpoXzMBx65qBehfobeePJcTBigHCdnjcTKkdklegzrFzjEs X-Received: by 2002:a05:6402:95e:: with SMTP id h30mr12466783edz.117.1587444785855; Mon, 20 Apr 2020 21:53:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587444785; cv=none; d=google.com; s=arc-20160816; b=rVs5PH6fj0wJMuA2s3tMwmojlweT4TJ/HANkwlfnTHlaxyaaqmxnk3Q4YhQh24FZCx hvpC43NNOMToEWgLIOl5n0tLxCuWVPyjVpsPmnUOG/GX8k8Qw3BkxdEPqmHgRBxhkbAg jFwsOogK+KlEBtXC1e2mgHkvlx6y88ZZkHkL87fJgs4mUPX+Eg+7qzLpIvU+0d5evKRd 5kjoDqu+WtqprgTNuJHla868STb2MvgALW3WCILbjvk397bWtwB8NsiMh6tzcglUiWGH 8EyRB013kqhqETqhXTPgzj4kXC4RSe6DcplbCSqB3zAHYurPLhBiepZcaahm9RpZvx+7 7H7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=amUV47/Nv/3vEwYeUg4k0mUATPXPnvUAf2W+Nxnnel0=; b=B2mm0I5fTvKJDNJ/kaegavsrXYX9yNddhRZ04fTjTWJHy2hHHYkumTLEjitkKJ4ibR PT6xc6wz3pL74R8kc/3fx8QvUWxk+ij7cxqisZSGM9we11hAYef8Gpn4au8TLrrDW93X HXhsdChnmc0euBy3wRMNWZnCdJlgtwHV07Ax7D+WjgG4TQByI3260TmlO8tD8Gfumi75 lgkMwlHjfP2fy1wssYMcumMc/ISkcDhRBUCZcu5cF/ivDyF0NK3vk0Z5U9T2rjqkz8Rg pU2TQHdLKktxdA0X9I+PHroQ54O1BsBqQx3cGT8tvVJowuG+JYBfkIl3KDIYL6GygTx5 XPpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id la2si890054ejb.371.2020.04.20.21.52.43; Mon, 20 Apr 2020 21:53:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbgDUEv0 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 21 Apr 2020 00:51:26 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36610 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbgDUEv0 (ORCPT ); Tue, 21 Apr 2020 00:51:26 -0400 Received: from mail-pj1-f72.google.com ([209.85.216.72]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jQksV-0005qS-R0 for linux-kernel@vger.kernel.org; Tue, 21 Apr 2020 04:51:24 +0000 Received: by mail-pj1-f72.google.com with SMTP id bg6so2203696pjb.2 for ; Mon, 20 Apr 2020 21:51:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BLtq2QdjOzCrJMLFZ+hejhyptyhEVzibl60GGDinzt4=; b=j/mArgB442WbWM6AzvWEOkcD+7DFUVt59u4DEzWIiYsNqTRnUyaSUXET0HtxEsgvfe c/TWrPl4L5OF11tEluMcJSioM3+08NPilu4bmaiCFT5w+h8WwCJv8qWi5DEZqTm9Dac9 Ti5YeVfVrzXF4/gduKvEuq52rGiH7A0m4EAQbUyLJ/kT1CEUrInXpMBEUOZnTjTfrE07 TbJxEdf4aoB1jvF7cJaLTBvZXIsC6TsYFN58N9OsVzuxNHtXeXaOlePulcZdZ7CymPuN mqkuNNikZIDLWPFilfjgTI4CzHPghEJ/heMXhzVLwhlLEU3qZeKWKkOUKcOsk7QLq8Gg +hAQ== X-Gm-Message-State: AGi0PuY24vXXM0DKMyE/PGVI78GuDuHGpmMk6V1xRE5zHOtjYIoM4NUS 0LX7quI7HnzAZeYX41GeUsTAFQxbsGGtsKKjWD3Mxwj+VP0oGYfd2B2SbMsYwOQmrrxYtxoLp+w JRWvg3FQMAPeN0RHGaPJ8qBmnAZXMeYsjWD5iJ4ykSA== X-Received: by 2002:a17:90a:7349:: with SMTP id j9mr3358500pjs.196.1587444682538; Mon, 20 Apr 2020 21:51:22 -0700 (PDT) X-Received: by 2002:a17:90a:7349:: with SMTP id j9mr3358482pjs.196.1587444682263; Mon, 20 Apr 2020 21:51:22 -0700 (PDT) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id mq6sm1074269pjb.38.2020.04.20.21.51.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2020 21:51:21 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [PATCH] nvme/pci: Use Discard instead of Write Zeroes on SK hynix SC300 From: Kai-Heng Feng In-Reply-To: <20200417125929.GA5053@lst.de> Date: Tue, 21 Apr 2020 12:51:18 +0800 Cc: Keith Busch , Jens Axboe , Sagi Grimberg , linux-stable , "open list:NVM EXPRESS DRIVER" , open list Content-Transfer-Encoding: 8BIT Message-Id: <33565F7F-307C-408C-861D-72517F564967@canonical.com> References: <20200417083641.28205-1-kai.heng.feng@canonical.com> <20200417125929.GA5053@lst.de> To: Christoph Hellwig X-Mailer: Apple Mail (2.3608.80.23.2.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Apr 17, 2020, at 20:59, Christoph Hellwig wrote: > > On Fri, Apr 17, 2020 at 04:36:41PM +0800, Kai-Heng Feng wrote: >> After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes >> command"), SK hynix SC300 becomes very slow with the following error >> message: >> [ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0] >> >> Use quirk NVME_QUIRK_DEALLOCATE_ZEROES to workaround this issue. > > Do you have a written guarantee from SK Hynix that it will always zero > all blocks discarded? Raised the issue to SK Hynix and waiting for their reply... Kai-Heng