Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Abhishek Sahu <abhsahu@nvidia.com>
Subject: Re: [PATCH] x86/mm: fix compilation error for unknown type name
 pgprot_t
To:     Logan Gunthorpe <logang@deltatee.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20200420082231.4202-1-abhsahu@nvidia.com>
 <02c40a96-b9dd-14d8-57f4-426322b76bf2@deltatee.com>
Message-ID: <24e4100d-f59b-daa6-801b-28c9d062f262@nvidia.com>
Date:   Tue, 21 Apr 2020 11:18:41 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <02c40a96-b9dd-14d8-57f4-426322b76bf2@deltatee.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/20/2020 10:14 PM, Logan Gunthorpe wrote:
> External email: Use caution opening links or attachments
> 
> 	
> On 2020-04-20 2:22 a.m., Abhishek Sahu wrote:
>> commit 30796e18c299 ("x86/mm: introduce __set_memory_prot()")
>> added the function __set_memory_prot() which uses pgprot_t in
>> function prototype. The currently included header files in
>> <arch/x86/include/asm/set_memory.h> do not include type name
>> pgprot_t. The pgprot_t is defined in <asm/pgtable_types.h>.
>>
>> Fixes: 30796e18c299 ("x86/mm: introduce __set_memory_prot()")
>> Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
> 
> I assume this is only hit with a specific driver or something that
> includes set_memory.h without including pgtable_types.h before hand.
> 
> It certainly compiles fine for me and the kbuild robot has had lots of
> time to test it with random configs.
> 
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

  Thanks Logan.

  Yes. The mainline is compiling fine with default config.
  This problem is coming while compiling Out of tree NVIDIA driver.
  But this problem can happen for the drivers which don't include
  <pgtable_types.h>. I am not sure if this problem will come with
  some other configs. Normally, the header files should not be
  dependent upon the callers.

  Regards,
  Abhishek