Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp4394677ybz; Mon, 20 Apr 2020 23:02:43 -0700 (PDT) X-Google-Smtp-Source: APiQypJ4lG/Cdvsc6975YzqZE20DtUyaLQ9PLkvJMiZKJxy+gmAGhyXnQBSmGW+jz5ZWkDLvbMtR X-Received: by 2002:a50:eb8e:: with SMTP id y14mr17401941edr.270.1587448963340; Mon, 20 Apr 2020 23:02:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587448963; cv=none; d=google.com; s=arc-20160816; b=z7fUzwmB3JgByroFslpN1sRH1JRhjk5jUFhjLjXlcEb8FThhEueo+dzxrqU+XYi64w aPVzAYU2omtZZO5osaxdyr4Yk6ZUrRMPR6XdVs3+swXgtuHBv2eFBOu4ngSuOTBrtixo zxye6mCUKwIKZ/sPXAmRL45jnRinsbBqufXUuF1PWHJ7gZk2jt606X83XTz+9dzdclSB Auu/kDu/6evTPKEmKRsrvVMfRxb4h6AdCf6YEZrePyx6ELYI6vIP4Xi3sHhGfjTT0+zO dI2nZo3OZDAcDuc0bMP5pm9iEp/jiRZyXz5+f990SEApl4K4K/AhlLtJtMH5uJ/q1X4U F4mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2++lltyIHYMAMAI5zyqaQmWBPop53Y9cfuLXENska98=; b=pTTblDE/N77bRTksexP72498BQYbjBXEMJz6cYwuuG1DH7csLnt1NnwH6VhCw869ue 1uWQ/DePCg7G91d8oGvA4AHdTfI5G71X4Vx7njy1AFeGIxjJ+XZTWKT+jaE1o24w0/t8 MC9lg3S1LiEXFuEVUKPWfeGb02XdIzIri+F/M2YXGIZDuDqEfzYiKosW4yzW2wQ8sega +6B1vcpneJ2Yo3PWJ7PHYOD9WdHXGmHLaTwuIH2wQ4cAeVhuHHDLzI2yYVuiaRf70nw6 27UCtrdeyJwxg21JeT8GF1MV3YoGVTw7jIO+rmFKW+WGHZOV5XkSJmDAECbpGCR5/Ucl azyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H5+C9ijm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k15si1150279edk.194.2020.04.20.23.02.19; Mon, 20 Apr 2020 23:02:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H5+C9ijm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbgDUF77 (ORCPT + 99 others); Tue, 21 Apr 2020 01:59:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:39076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726079AbgDUF77 (ORCPT ); Tue, 21 Apr 2020 01:59:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9AF142076C; Tue, 21 Apr 2020 05:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587448799; bh=x/6mU5SMHCOal2Ij3Hc+/MYIcd7Tq+Ern6HXgC449+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H5+C9ijmAKKwg5eA4F+D37RqPPHLN1J5FazJcIEAkv68dz5mXlKIYxcTJk6FSa7/2 LDbsxye0ooxHr0WomgQU4wQDwfs1SdKy06J/Xsikrp24brXyuoPHuqqL2MIJqXfHzZ 4GQBfzYb0i3k5LWvFkgmFKhyKi+igmk/Cq9bOoy4= Date: Tue, 21 Apr 2020 07:59:55 +0200 From: Greg KH To: Evalds Iodzevics Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, ben@decadent.org.uk Subject: Re: [PATCH v2] x86/microcode/intel: replace sync_core() with native_cpuid_reg(eax) Message-ID: <20200421055955.GA343434@kroah.com> References: <20200420120037.1537-1-evalds.iodzevics@gmail.com> <20200421085344.1804-1-evalds.iodzevics@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421085344.1804-1-evalds.iodzevics@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2020 at 11:53:44AM +0300, Evalds Iodzevics wrote: > On Intel it is required to do CPUID(1) before reading the microcode > revision MSR. Current code in 4.4 an 4.9 relies on sync_core() to call > CPUID, unfortunately on 32 bit machines code inside sync_core() always > jumps past CPUID instruction as it depends on data structure boot_cpu_data > witch are not populated correctly so early in boot sequence. > > It depends on: > commit 5dedade6dfa2 ("x86/CPU: Add native CPUID variants returning a single > datum") > > This patch is for 4.4 but also should apply to 4.9 > > Signed-off-by: Evalds Iodzevics > --- > arch/x86/include/asm/microcode_intel.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Why are you not sending this to the stable mailing list like I have pointed out numerous times by sending you a link to _how_ to get a patch into the stable kernel trees? Again, here it is: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html Please follow that so that we can do this correctly. thanks, greg k-h