Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1587309963.git.yu.c.chen@intel.com> <7c1eab789cb4b53ec5f54644c089ce27ea14088a.1587309963.git.yu.c.chen@intel.com>
 <20200420183232.16b83374@gandalf.local.home> <jhjwo69lqcm.mognet@arm.com>
 <20200420231355.GU2483@worktop.programming.kicks-ass.net> <20200420222319.34f9f646@oasis.local.home>
In-Reply-To: <20200420222319.34f9f646@oasis.local.home>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Tue, 21 Apr 2020 09:42:26 +0200
Message-ID: <CAKfTPtBG=Nu+76NywfD0rk-BmT=2egTd_9FaPU4oCP1D_eyuBQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] sched: Extract the task putting code from pick_next_task()
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Chen Yu <yu.c.chen@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 21 Apr 2020 at 04:23, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 21 Apr 2020 01:13:55 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > The 'finish' thing isn't too far from the truth; it's the last thing we
> > > need to do with the prev task (in terms of sched bookkeeping, I mean) -
> > > and in Chen's defence ISTR Peter suggested that name.
> > >
> > > Seeing as it's a "supercharged" put_prev_task(), I could live with the
> > > marginally shorter "put_prev_task_balance()".
> >
> > What Valentin said; it's the last put we do before picking a new task.
> > Also, I don't like long names. That said, I'm open to short and
> > appropriate suggestions.
>
> I wont bikeshed this too much.
>
> Is the "finish" more appropriate with the other use cases that are
> coming. I do like that "put_prev_task_balance()" too.

This name looks reasonnable

>
> -- Steve